Skip to content

Enhanced ChatGPT Clone: Features Agents, MCP, Skills, DeepSeek, Anthropic, AWS, OpenAI, Responses API, Azure, Groq, o1, GPT-5, Mistral, OpenRouter, Vertex AI, Gemini, Artifacts, AI model switching, message search, Code Interpreter, langchain, DALL-E-3, OpenAPI Actions, Functions, Secure Multi-User Auth, Presets, open-source for self-hosting. Active

3.7 KB
Raw Blame
import fs from 'fs';
import os from 'os';
import path from 'path';
import { createLocalFileDeleter } from './local';

describe('local file deletion', () => {
  let root: string;
  let req: { user: { id: string }; config: { paths: { publicPath: string; uploads: string } } };
  const deleteRagFile = jest.fn().mockResolvedValue(undefined);
  const logger = { warn: jest.fn(), error: jest.fn() };
  const remove = createLocalFileDeleter({ deleteRagFile, logger });

  beforeEach(() => {
    jest.clearAllMocks();
    root = fs.mkdtempSync(path.join(os.tmpdir(), 'local-delete-'));
    req = {
      user: { id: 'user-1' },
      config: {
        paths: { publicPath: path.join(root, 'public'), uploads: path.join(root, 'uploads') },
      },
    };
  });

  afterEach(() => fs.rmSync(root, { recursive: true, force: true }));

  const uploadedFile = (name: string, owner = 'user-1') => {
    const dir = path.join(root, 'uploads', owner);
    fs.mkdirSync(dir, { recursive: true });
    fs.writeFileSync(path.join(dir, name), 'contents');
    return { file_id: 'file-1', filepath: `/uploads/${owner}/${name}`, user: owner };
  };

  it('removes uploaded bytes and RAG data', async () => {
    const file = uploadedFile('knowledge.txt');
    await remove(req, file);
    expect(fs.existsSync(path.join(root, 'uploads', 'user-1', 'knowledge.txt'))).toBe(false);
    expect(deleteRagFile).toHaveBeenCalledWith({ userId: 'user-1', file });
  });

  it('preserves bytes when vector cleanup returns false', async () => {
    const file = uploadedFile('retained.txt');
    deleteRagFile.mockResolvedValueOnce(false);
    await expect(remove(req, file)).rejects.toThrow('Vector deletion was not confirmed');
    expect(fs.existsSync(path.join(root, 'uploads', 'user-1', 'retained.txt'))).toBe(true);
  });

  it('accepts missing storage but rejects other unlink failures', async () => {
    const file = { file_id: 'file-1', filepath: '/uploads/user-1/missing.txt', user: 'user-1' };
    await expect(remove(req, file)).resolves.toBeUndefined();

    const directory = path.join(root, 'uploads', 'user-1', 'not-a-file');
    fs.mkdirSync(directory, { recursive: true });
    const existing = { file_id: 'file-2', filepath: '/uploads/user-1/not-a-file', user: 'user-1' };
    await expect(remove(req, existing)).rejects.toThrow();
    expect(fs.existsSync(directory)).toBe(true);
  });

  it('keeps deletion scoped to the request owner, not descriptor metadata', async () => {
    const file = uploadedFile('managed.txt', 'user-2');
    await expect(remove(req, file)).rejects.toThrow('Invalid file path');
    expect(deleteRagFile).not.toHaveBeenCalled();
    expect(fs.existsSync(path.join(root, 'uploads', 'user-2', 'managed.txt'))).toBe(true);

    req.user.id = 'user-2';
    await remove(req, file);
    expect(deleteRagFile).toHaveBeenCalledWith({ userId: 'user-2', file });

    const other = uploadedFile('protected.txt', 'user-2');
    req.user.id = 'user-3';
    deleteRagFile.mockClear();
    await expect(remove(req, other)).rejects.toThrow('Invalid file path');
    expect(deleteRagFile).not.toHaveBeenCalled();
  });

  it('cleans up RAG data for a legacy agent record without a disk path', async () => {
    const file = { file_id: 'file-1', filepath: 'agents', user: 'user-2' };
    await remove(req, file);
    expect(deleteRagFile).toHaveBeenCalledWith({ userId: 'user-1', file });
  });

  it('rejects an empty request owner before touching storage or RAG data', async () => {
    const file = uploadedFile('retained.txt');
    req.user.id = '';
    await expect(remove(req, file)).rejects.toThrow('Invalid file owner');
    expect(deleteRagFile).not.toHaveBeenCalled();
    expect(fs.existsSync(path.join(root, 'uploads', 'user-1', 'retained.txt'))).toBe(true);
  });
});