Enhanced ChatGPT Clone: Features Agents, MCP, Skills, DeepSeek, Anthropic, AWS, OpenAI, Responses API, Azure, Groq, o1, GPT-5, Mistral, OpenRouter, Vertex AI, Gemini, Artifacts, AI model switching, message search, Code Interpreter, langchain, DALL-E-3, OpenAPI Actions, Functions, Secure Multi-User Auth, Presets, open-source for self-hosting. Active
TypeScript aianthropicartifactsawsazurechatgptchatgpt-cloneclaudeclonedeepseekgeminigooglegpt-5librechatmcpo1openairesponses-apivisionwebui
🧪 ci: Resolve DataTable test infinite re-render (#13947)
Danny Avila03ecac8ac1c2
diff --git a/.github/workflows/frontend-review.yml b/.github/workflows/frontend-review.ymlindex a3f31efba6..db84d055c5 100644--- a/.github/workflows/frontend-review.yml+++ b/.github/workflows/frontend-review.yml@@ -122,6 +122,44 @@ jobs:run: npm run typecheckworking-directory: client+ test-packages-client:+ name: 'Tests: @librechat/client'+ needs: build+ runs-on: ubuntu-latest+ timeout-minutes: 10+ steps:+ - uses: actions/checkout@v4++ - name: Use Node.js 24.16.0+ uses: actions/setup-node@v4+ with:+ node-version: '24.16.0'++ - name: Restore node_modules cache+ id: cache-node-modules+ uses: actions/cache@v4+ with:+ path: |+ node_modules+ client/node_modules+ packages/client/node_modules+ packages/data-provider/node_modules+ key: node-modules-frontend-${{ runner.os }}-24.16.0-${{ hashFiles('package-lock.json') }}++ - name: Install dependencies+ if: steps.cache-node-modules.outputs.cache-hit != 'true'+ run: npm ci++ - name: Download data-provider build+ uses: actions/download-artifact@v4+ with:+ name: build-data-provider+ path: packages/data-provider/dist++ - name: Run unit tests+ run: npm run test:ci+ working-directory: packages/client+test-ubuntu:name: 'Tests: Ubuntu (shard ${{ matrix.shard }}/4)'needs: builddiff --git a/packages/client/package.json b/packages/client/package.jsonindex 6c33db4714..7b04926cab 100644--- a/packages/client/package.json+++ b/packages/client/package.json@@ -33,7 +33,9 @@"build:dev": "npm run clean && NODE_ENV=development tsdown","b:build": "bun run b:clean && bun run tsdown","build:watch": "tsdown --watch",- "dev": "tsdown --watch"+ "dev": "tsdown --watch",+ "test": "jest",+ "test:ci": "jest --ci"},"peerDependencies": {"@ariakit/react": "^0.4.29",diff --git a/packages/client/src/components/DataTable/DataTable.spec.tsx b/packages/client/src/components/DataTable/DataTable.spec.tsxindex f9897acb7e..491ea96823 100644--- a/packages/client/src/components/DataTable/DataTable.spec.tsx+++ b/packages/client/src/components/DataTable/DataTable.spec.tsx@@ -1,9 +1,9 @@import React from 'react';-import { render, screen, fireEvent, waitFor } from '@testing-library/react';import { Provider as JotaiProvider } from 'jotai';-import DataTable from './DataTable';-import type { TableColumn } from './DataTable.types';+import { render, screen, fireEvent, waitFor } from '@testing-library/react';import type { SortingState } from '@tanstack/react-table';+import type { TableColumn } from './DataTable.types';+import DataTable from './DataTable';// Mock utilitiesjest.mock('~/utils', () => ({@@ -30,6 +30,35 @@ jest.mock('~/hooks', () => ({useMediaQuery: jest.fn(() => false),}));+// jsdom can't measure layout, so @tanstack/react-virtual's measurement-driven re-render loop+// never converges (infinite "Too many re-renders"). Stub it to render every row deterministically.+jest.mock('@tanstack/react-virtual', () => ({+ useVirtualizer: ({+ count,+ estimateSize,+ }: {+ count: number;+ estimateSize?: (index: number) => number;+ }) => {+ const size = estimateSize ? estimateSize(0) : 56;+ return {+ getVirtualItems: () =>+ Array.from({ length: count }, (_, index) => ({+ index,+ key: index,+ start: index * size,+ end: (index + 1) * size,+ size,+ lane: 0,+ })),+ getTotalSize: () => count * size,+ calculateRange: () => {},+ measureElement: () => {},+ scrollToIndex: () => {},+ };+ },+}));+// Mock svgsjest.mock('~/svgs', () => ({Spinner: ({ className }: { className?: string }) => (diff --git a/packages/client/src/components/DataTable/DataTable.tsx b/packages/client/src/components/DataTable/DataTable.tsxindex 2c11155e0a..20bcb7e019 100644--- a/packages/client/src/components/DataTable/DataTable.tsx+++ b/packages/client/src/components/DataTable/DataTable.tsx@@ -271,8 +271,10 @@ function DataTable<TData extends Record<string, unknown>, TValue>({overscan: dynamicOverscan,});- const virtualRows = rowVirtualizer.getVirtualItems();- const totalSize = rowVirtualizer.getTotalSize();+ // Only read the virtualizer when active; the non-virtualized branch renders rows directly,+ // so engaging it for small tables is wasted render-phase work.+ const virtualRows = virtualizationActive ? rowVirtualizer.getVirtualItems() : [];+ const totalSize = virtualizationActive ? rowVirtualizer.getTotalSize() : 0;const paddingTop = virtualRows[0]?.start ?? 0;const paddingBottom =virtualRows.length > 0 ? totalSize - (virtualRows[virtualRows.length - 1]?.end ?? 0) : 0;