Skip to content

Enhanced ChatGPT Clone: Features Agents, MCP, Skills, DeepSeek, Anthropic, AWS, OpenAI, Responses API, Azure, Groq, o1, GPT-5, Mistral, OpenRouter, Vertex AI, Gemini, Artifacts, AI model switching, message search, Code Interpreter, langchain, DALL-E-3, OpenAPI Actions, Functions, Secure Multi-User Auth, Presets, open-source for self-hosting. Active

🧬 feat: Allow Agent Editors to Duplicate Agents (#12041)

Peter Nancarrow14bcab60b3b9
diff --git a/api/server/routes/agents/v1.js b/api/server/routes/agents/v1.js
index 682a9c795f..ed989bcf44 100644
--- a/api/server/routes/agents/v1.js
+++ b/api/server/routes/agents/v1.js
@@ -117,7 +117,7 @@ router.post(
'/:id/duplicate',
checkAgentCreate,
canAccessAgentResource({
- requiredPermission: PermissionBits.VIEW,
+ requiredPermission: PermissionBits.EDIT,
resourceIdParam: 'id',
}),
v1.duplicateAgent,
diff --git a/client/src/components/SidePanel/Agents/AgentFooter.tsx b/client/src/components/SidePanel/Agents/AgentFooter.tsx
index b2fa996596..ff98f7c48b 100644
--- a/client/src/components/SidePanel/Agents/AgentFooter.tsx
+++ b/client/src/components/SidePanel/Agents/AgentFooter.tsx
@@ -57,6 +57,7 @@ export default function AgentFooter({
useResourcePermissions(ResourceType.REMOTE_AGENT, agent?._id || '');
const canShareThisAgent = hasPermission(PermissionBits.SHARE);
+ const canEditThisAgent = hasPermission(PermissionBits.EDIT);
const canDeleteThisAgent = hasPermission(PermissionBits.DELETE);
const canShareRemoteAgent = hasRemoteAgentPermission(PermissionBits.SHARE);
const isSaving = createMutation.isLoading || updateMutation.isLoading || isAvatarUploading;
@@ -118,7 +119,8 @@ export default function AgentFooter({
</button>
</GenericGrantAccessDialog>
)}
- {agent && agent.author === user?.id && <DuplicateAgent agent_id={agent_id} />}
+ {(agent?.author === user?.id || user?.role === SystemRoles.ADMIN || canEditThisAgent) &&
+ !permissionsLoading && <DuplicateAgent agent_id={agent_id} />}
{/* Submit Button */}
<button
className="btn btn-primary focus:shadow-outline flex h-9 w-full items-center justify-center px-4 py-2 font-semibold text-white hover:bg-green-600 focus:border-green-500"
diff --git a/client/src/components/SidePanel/Agents/DeleteButton.tsx b/client/src/components/SidePanel/Agents/DeleteButton.tsx
index 9758f80abe..b3c81debd4 100644
--- a/client/src/components/SidePanel/Agents/DeleteButton.tsx
+++ b/client/src/components/SidePanel/Agents/DeleteButton.tsx
@@ -88,6 +88,7 @@ export default function DeleteButton({
size="sm"
variant="outline"
aria-label={localize('com_ui_delete_agent')}
+ title={localize('com_ui_delete_agent')}
type="button"
>
<div className="flex w-full items-center justify-center gap-2 text-red-500">
diff --git a/client/src/components/SidePanel/Agents/DuplicateAgent.tsx b/client/src/components/SidePanel/Agents/DuplicateAgent.tsx
index 089dea0732..1e598d528d 100644
--- a/client/src/components/SidePanel/Agents/DuplicateAgent.tsx
+++ b/client/src/components/SidePanel/Agents/DuplicateAgent.tsx
@@ -37,6 +37,7 @@ export default function DuplicateAgent({ agent_id }: { agent_id: string }) {
size="sm"
variant="outline"
aria-label={localize('com_ui_duplicate_agent')}
+ title={localize('com_ui_duplicate_agent')}
type="button"
onClick={handleDuplicate}
>
diff --git a/client/src/components/SidePanel/Agents/__tests__/AgentFooter.spec.tsx b/client/src/components/SidePanel/Agents/__tests__/AgentFooter.spec.tsx
index 8d882bffe8..cfceeacb33 100644
--- a/client/src/components/SidePanel/Agents/__tests__/AgentFooter.spec.tsx
+++ b/client/src/components/SidePanel/Agents/__tests__/AgentFooter.spec.tsx
@@ -362,9 +362,15 @@ describe('AgentFooter', () => {
}
return undefined;
});
+ mockUseHasAccess.mockReturnValue(true);
+ mockUseResourcePermissions.mockReturnValue({
+ hasPermission: () => false,
+ isLoading: false,
+ permissionBits: 0,
+ });
render(<AgentFooter {...defaultProps} />);
- expect(screen.queryByTestId('grant-access-dialog-agent')).toBeInTheDocument(); // Still shows because hasAccess is true
- expect(screen.queryByTestId('duplicate-agent')).not.toBeInTheDocument(); // Should not show for different author
+ expect(screen.queryByTestId('grant-access-dialog-agent')).not.toBeInTheDocument(); // No share permission
+ expect(screen.queryByTestId('duplicate-button')).not.toBeInTheDocument(); // No edit permission
});
test('adjusts UI based on permissions', () => {
@@ -420,7 +426,84 @@ describe('AgentFooter', () => {
render(<AgentFooter {...defaultProps} />);
expect(screen.queryByTestId('delete-button')).not.toBeInTheDocument();
expect(screen.queryByTestId('grant-access-dialog-agent')).not.toBeInTheDocument();
- // Duplicate button should still show as it doesn't depend on permissions loading
+ expect(screen.queryByTestId('duplicate-button')).not.toBeInTheDocument();
+ });
+
+ test('shows duplicate button for non-owner with EDIT permission', () => {
+ mockUseAuthContext.mockReturnValue(createAuthContext(mockUsers.different));
+ mockUseWatch.mockImplementation(({ name }) => {
+ if (name === 'agent') {
+ return {
+ _id: 'agent-db-123',
+ name: 'Test Agent',
+ author: 'user-123',
+ projectIds: ['project-1'],
+ isCollaborative: false,
+ };
+ }
+ if (name === 'id') {
+ return 'agent-123';
+ }
+ return undefined;
+ });
+ mockUseResourcePermissions.mockReturnValue({
+ hasPermission: (bit: number) => bit === 2,
+ isLoading: false,
+ permissionBits: 2,
+ });
+ render(<AgentFooter {...defaultProps} />);
+ expect(screen.getByTestId('duplicate-button')).toBeInTheDocument();
+ });
+
+ test('hides duplicate button for non-owner with only VIEW permission', () => {
+ mockUseAuthContext.mockReturnValue(createAuthContext(mockUsers.different));
+ mockUseWatch.mockImplementation(({ name }) => {
+ if (name === 'agent') {
+ return {
+ _id: 'agent-db-123',
+ name: 'Test Agent',
+ author: 'user-123',
+ projectIds: ['project-1'],
+ isCollaborative: false,
+ };
+ }
+ if (name === 'id') {
+ return 'agent-123';
+ }
+ return undefined;
+ });
+ mockUseResourcePermissions.mockReturnValue({
+ hasPermission: () => false,
+ isLoading: false,
+ permissionBits: 1,
+ });
+ render(<AgentFooter {...defaultProps} />);
+ expect(screen.queryByTestId('duplicate-button')).not.toBeInTheDocument();
+ });
+
+ test('shows duplicate button for admin who is not the author', () => {
+ mockUseAuthContext.mockReturnValue(createAuthContext(mockUsers.admin));
+ mockUseWatch.mockImplementation(({ name }) => {
+ if (name === 'agent') {
+ return {
+ _id: 'agent-db-123',
+ name: 'Test Agent',
+ author: 'user-123',
+ projectIds: ['project-1'],
+ isCollaborative: false,
+ };
+ }
+ if (name === 'id') {
+ return 'agent-123';
+ }
+ return undefined;
+ });
+ mockUseResourcePermissions.mockReturnValue({
+ hasPermission: () => false,
+ isLoading: false,
+ permissionBits: 0,
+ });
+ render(<AgentFooter {...defaultProps} />);
expect(screen.getByTestId('duplicate-button')).toBeInTheDocument();
});
});