Enhanced ChatGPT Clone: Features Agents, MCP, Skills, DeepSeek, Anthropic, AWS, OpenAI, Responses API, Azure, Groq, o1, GPT-5, Mistral, OpenRouter, Vertex AI, Gemini, Artifacts, AI model switching, message search, Code Interpreter, langchain, DALL-E-3, OpenAPI Actions, Functions, Secure Multi-User Auth, Presets, open-source for self-hosting. Active
TypeScript aianthropicartifactsawsazurechatgptchatgpt-cloneclaudeclonedeepseekgeminigooglegpt-5librechatmcpo1openairesponses-apivisionwebui
🦭 fix: Require Full-Length Private Text Authentication Tags (#17646)
lia-by-librechat[bot]295cb633f428
diff --git a/packages/api/src/protection/private/crypto.spec.ts b/packages/api/src/protection/private/crypto.spec.tsnew file mode 100644index 0000000000..e79bfc2c00--- /dev/null+++ b/packages/api/src/protection/private/crypto.spec.ts@@ -0,0 +1,47 @@+import { createPrivateTextCipher } from './crypto';++const cipher = createPrivateTextCipher('ab'.repeat(32));+const binding = ['owner', 'tenant-a', 'message-1'];++// Generated by seal() before authTagLength was specified.+const legacyEnvelope = 'v1:68pebNDOtCw9330w:gkL8WAsny7wcvwxHF+BTfA==:xZCEA00xZU/kYxx7BNAI';++describe('private text cipher', () => {+ it.each(['', 'private message', '秘密 🔐'])('round-trips %j with a 16-byte tag', (text) => {+ const envelope = cipher.seal(text, binding);+ expect(Buffer.from(envelope.split(':')[2], 'base64')).toHaveLength(16);+ expect(cipher.open(envelope, binding)).toBe(text);+ });++ it('opens existing envelopes with full-length tags', () => {+ expect(cipher.open(legacyEnvelope, binding)).toBe('private message');+ });++ it.each(Array.from({ length: 16 }, (_, length) => length))(+ 'rejects a tag truncated to %i bytes',+ (length) => {+ const [version, nonce, tag, ciphertext] = cipher.seal('private message', binding).split(':');+ const truncated = Buffer.from(tag, 'base64').subarray(0, length).toString('base64');+ const envelope = [version, nonce, truncated, ciphertext].join(':');+ expect(() => cipher.open(envelope, binding)).toThrow('Private message text is unavailable.');+ },+ );++ it.each([17, 32])('rejects an oversized %i-byte tag', (length) => {+ const [version, nonce, tag, ciphertext] = cipher.seal('private message', binding).split(':');+ const extended = Buffer.concat([+ Buffer.from(tag, 'base64'),+ Buffer.alloc(length - 16),+ ]).toString('base64');+ const envelope = [version, nonce, extended, ciphertext].join(':');+ expect(() => cipher.open(envelope, binding)).toThrow('Private message text is unavailable.');+ });++ it('rejects a modified full-length tag', () => {+ const [version, nonce, tag, ciphertext] = cipher.seal('private message', binding).split(':');+ const modified = Buffer.from(tag, 'base64');+ modified[0] ^= 1;+ const envelope = [version, nonce, modified.toString('base64'), ciphertext].join(':');+ expect(() => cipher.open(envelope, binding)).toThrow('Private message text is unavailable.');+ });+});diff --git a/packages/api/src/protection/private/crypto.ts b/packages/api/src/protection/private/crypto.tsindex 20aa47451c..944b2c3998 100644--- a/packages/api/src/protection/private/crypto.ts+++ b/packages/api/src/protection/private/crypto.ts@@ -22,7 +22,7 @@ export function createPrivateTextCipher(hexKey: string): PrivateTextCipher {},seal(text, binding) {const nonce = randomBytes(12);- const cipher = createCipheriv('aes-256-gcm', key, nonce);+ const cipher = createCipheriv('aes-256-gcm', key, nonce, { authTagLength: 16 });cipher.setAAD(aad(binding));const ciphertext = Buffer.concat([cipher.update(text, 'utf8'), cipher.final()]);return [@@ -38,7 +38,9 @@ export function createPrivateTextCipher(hexKey: string): PrivateTextCipher {if (version !== 'v1' || extra != null || !nonce || !tag || ciphertext == null) {throw new Error();}- const decipher = createDecipheriv('aes-256-gcm', key, Buffer.from(nonce, 'base64'));+ const decipher = createDecipheriv('aes-256-gcm', key, Buffer.from(nonce, 'base64'), {+ authTagLength: 16,+ });decipher.setAAD(aad(binding));decipher.setAuthTag(Buffer.from(tag, 'base64'));return Buffer.concat([