Skip to content

Enhanced ChatGPT Clone: Features Agents, MCP, Skills, DeepSeek, Anthropic, AWS, OpenAI, Responses API, Azure, Groq, o1, GPT-5, Mistral, OpenRouter, Vertex AI, Gemini, Artifacts, AI model switching, message search, Code Interpreter, langchain, DALL-E-3, OpenAPI Actions, Functions, Secure Multi-User Auth, Presets, open-source for self-hosting. Active

🚫 fix: Decline to Name a Heif Container With Unreported Compression (#15612)

Danny Avila3200f0133ac5
diff --git a/packages/api/src/files/mime.spec.ts b/packages/api/src/files/mime.spec.ts
index b841c7f7eb..9f28fb170b 100644
--- a/packages/api/src/files/mime.spec.ts
+++ b/packages/api/src/files/mime.spec.ts
@@ -40,4 +40,9 @@ describe('resolveImageMimeType', () => {
expect(resolveImageMimeType({ format: 'svg' })).toBeUndefined();
expect(resolveImageMimeType({ format: 'raw' })).toBeUndefined();
});
+
+ it('declines to name a heif container whose compression sharp did not report', () => {
+ expect(resolveImageMimeType({ format: 'heif' })).toBeUndefined();
+ expect(resolveImageMimeType({ format: 'heif', compression: undefined })).toBeUndefined();
+ });
});
diff --git a/packages/api/src/files/mime.ts b/packages/api/src/files/mime.ts
index a4bebb9fe8..1fa85a46d0 100644
--- a/packages/api/src/files/mime.ts
+++ b/packages/api/src/files/mime.ts
@@ -27,8 +27,9 @@ export type EncodedImageMetadata = Pick<Metadata, 'format' | 'compression'>;
* bytes leaves a file whose `type` misdescribes its own contents, and that type is later handed
* to providers verbatim as `media_type`/`mimeType`, so it has to describe the bytes on disk.
*
- * Returns `undefined` when sharp reports a format with no media type of its own, leaving the
- * caller to decide what to record rather than guessing here.
+ * Returns `undefined` when the bytes cannot be named confidently — a format with no media type of
+ * its own, or a heif container whose compression sharp did not report — leaving the caller to fall
+ * back to what it already knows. Naming one of those anyway would be the guess this exists to stop.
*/
export function resolveImageMimeType(metadata: EncodedImageMetadata): string | undefined {
const { format } = metadata;
@@ -36,7 +37,10 @@ export function resolveImageMimeType(metadata: EncodedImageMetadata): string | u
return undefined;
}
if (format === 'heif') {
- return metadata.compression === 'av1' ? 'image/avif' : 'image/heic';
+ if (metadata.compression === 'av1') {
+ return 'image/avif';
+ }
+ return metadata.compression === 'hevc' ? 'image/heic' : undefined;
}
return SHARP_FORMAT_MIME_TYPES[format];
}