Skip to content

Enhanced ChatGPT Clone: Features Agents, MCP, Skills, DeepSeek, Anthropic, AWS, OpenAI, Responses API, Azure, Groq, o1, GPT-5, Mistral, OpenRouter, Vertex AI, Gemini, Artifacts, AI model switching, message search, Code Interpreter, langchain, DALL-E-3, OpenAPI Actions, Functions, Secure Multi-User Auth, Presets, open-source for self-hosting. Active

🧾 refactor: Drop the Unsent Request/Response Pair From ChatErrorData (#17221)

Marco Beretta553c5ca63c39
diff --git a/e2e/specs/mock/scenarios/chat-error-event.spec.ts b/e2e/specs/mock/scenarios/chat-error-event.spec.ts
new file mode 100644
index 0000000000..7243a71534
--- /dev/null
+++ b/e2e/specs/mock/scenarios/chat-error-event.spec.ts
@@ -0,0 +1,36 @@
+import { expect, test } from '@playwright/test';
+import {
+ MOCK_ENDPOINTS,
+ NEW_CHAT_PATH,
+ messagesView,
+ selectMockEndpoint,
+ sendMessage,
+} from '../helpers';
+
+/**
+ * The fake model throws mid-stream for `E2E_FORCED_ERROR:`, so the server ends the
+ * turn on the SSE `error` event; the transport parses that body as `ChatErrorData`.
+ */
+test.describe('served stream error', () => {
+ test('a turn that fails mid-stream shows the provider error and settles the composer @scenario:failed-turn-shows-served-error', async ({
+ page,
+ }) => {
+ test.setTimeout(90_000);
+ const label = `served-error-${Date.now()}`;
+ const providerError = `E2E forced stream error ${label}`;
+
+ await page.goto(NEW_CHAT_PATH, { timeout: 15_000 });
+ await selectMockEndpoint(page, MOCK_ENDPOINTS[0]);
+
+ const response = await sendMessage(page, `E2E_FORCED_ERROR:${label}`);
+ expect(response.ok()).toBeTruthy();
+ await expect(page).toHaveURL(/\/c\/(?!new)/, { timeout: 15_000 });
+
+ await expect(messagesView(page).getByText(providerError)).toBeVisible({ timeout: 30_000 });
+ await expect(page.getByRole('button', { name: 'Stop generating' })).toHaveCount(0);
+ await expect(page.getByRole('textbox', { name: 'Message input' })).toBeEnabled();
+
+ await page.reload();
+ await expect(messagesView(page).getByText(providerError)).toBeVisible({ timeout: 30_000 });
+ });
+});
diff --git a/packages/data-provider/src/types/transport.ts b/packages/data-provider/src/types/transport.ts
index 1f14fba902..752d293cb9 100644
--- a/packages/data-provider/src/types/transport.ts
+++ b/packages/data-provider/src/types/transport.ts
@@ -162,8 +162,9 @@ export type ChatFrame =
/**
* The body of the SSE `error` event: a bare message string (`handleError`),
- * `{ error, generationProtocolVersion }` from the agents stream route, or a
- * failed turn's partial request/response pair.
+ * `{ error, generationProtocolVersion }` from the agents stream route, or the
+ * error message `sendError` builds once headers are sent. No emitter sends a
+ * request/response pair here; a failed turn's pair arrives on `ChatFinalFrame`.
*/
export type ChatErrorData =
| string
@@ -174,8 +175,6 @@ export type ChatErrorData =
error?: boolean | string | { message?: string };
generationProtocolVersion?: number;
conversation?: Partial<TConversation>;
- requestMessage?: TMessage;
- responseMessage?: TMessage;
};
/**