Enhanced ChatGPT Clone: Features Agents, MCP, Skills, DeepSeek, Anthropic, AWS, OpenAI, Responses API, Azure, Groq, o1, GPT-5, Mistral, OpenRouter, Vertex AI, Gemini, Artifacts, AI model switching, message search, Code Interpreter, langchain, DALL-E-3, OpenAPI Actions, Functions, Secure Multi-User Auth, Presets, open-source for self-hosting. Active
TypeScript aianthropicartifactsawsazurechatgptchatgpt-cloneclaudeclonedeepseekgeminigooglegpt-5librechatmcpo1openairesponses-apivisionwebui
🛡️ fix: Sanitize HTML In Admin Banner And MCP Config Dialog (#12927)
Danny Avila619f28d76d73
diff --git a/client/src/components/Banners/Banner.tsx b/client/src/components/Banners/Banner.tsxindex b10fa70941..a1e9056c07 100644--- a/client/src/components/Banners/Banner.tsx+++ b/client/src/components/Banners/Banner.tsx@@ -1,7 +1,8 @@-import { useEffect, useRef } from 'react';+import DOMPurify from 'dompurify';import { XIcon } from 'lucide-react';import { useRecoilState } from 'recoil';import { Button, cn } from '@librechat/client';+import { useEffect, useMemo, useRef } from 'react';import { useGetBannerQuery } from '~/data-provider';import store from '~/store';@@ -10,6 +11,25 @@ export const Banner = ({ onHeightChange }: { onHeightChange?: (height: number) =const [hideBannerHint, setHideBannerHint] = useRecoilState<string[]>(store.hideBannerHint);const bannerRef = useRef<HTMLDivElement>(null);+ const sanitizedMessage = useMemo(() => {+ if (!banner?.message) {+ return '';+ }+ const sanitizer = DOMPurify();+ sanitizer.addHook('afterSanitizeAttributes', (node) => {+ if (node.tagName === 'A') {+ node.setAttribute('target', '_blank');+ node.setAttribute('rel', 'noopener noreferrer');+ }+ });+ return sanitizer.sanitize(banner.message, {+ ALLOWED_TAGS: ['a', 'strong', 'b', 'em', 'i', 'br', 'code', 'span'],+ ALLOWED_ATTR: ['href', 'class', 'target', 'rel'],+ ALLOW_DATA_ATTR: false,+ ALLOW_ARIA_ATTR: false,+ });+ }, [banner?.message]);+useEffect(() => {if (onHeightChange && bannerRef.current) {onHeightChange(bannerRef.current.offsetHeight);@@ -45,7 +65,7 @@ export const Banner = ({ onHeightChange }: { onHeightChange?: (height: number) ='text-md w-full truncate text-center [&_a]:text-blue-700 [&_a]:underline dark:[&_a]:text-blue-400',!banner.persistable && 'px-4',)}- dangerouslySetInnerHTML={{ __html: banner.message }}+ dangerouslySetInnerHTML={{ __html: sanitizedMessage }}></div>{!banner.persistable && (<Buttondiff --git a/client/src/components/Chat/Input/MCPConfigDialog.tsx b/client/src/components/Chat/Input/MCPConfigDialog.tsxindex 3a8f77a8de..a4cb03251e 100644--- a/client/src/components/Chat/Input/MCPConfigDialog.tsx+++ b/client/src/components/Chat/Input/MCPConfigDialog.tsx@@ -1,4 +1,5 @@-import React, { useEffect } from 'react';+import DOMPurify from 'dompurify';+import React, { useEffect, useMemo } from 'react';import { useForm, Controller } from 'react-hook-form';import { Button, Input, Label, OGDialog, OGDialogTemplate } from '@librechat/client';import type { ConfigFieldDetail } from '~/common';@@ -35,6 +36,25 @@ export default function MCPConfigDialog({defaultValues: initialValues,});+ const sanitizer = useMemo(() => {+ const instance = DOMPurify();+ instance.addHook('afterSanitizeAttributes', (node) => {+ if (node.tagName === 'A') {+ node.setAttribute('target', '_blank');+ node.setAttribute('rel', 'noopener noreferrer');+ }+ });+ return instance;+ }, []);++ const sanitize = (html: string) =>+ sanitizer.sanitize(html, {+ ALLOWED_TAGS: ['a', 'strong', 'b', 'em', 'i', 'br', 'code', 'span', 'p'],+ ALLOWED_ATTR: ['href', 'class', 'target', 'rel'],+ ALLOW_DATA_ATTR: false,+ ALLOW_ARIA_ATTR: false,+ });+useEffect(() => {if (isOpen) {reset(initialValues);@@ -83,7 +103,7 @@ export default function MCPConfigDialog({{details.description && (<pclassName="text-xs text-text-secondary [&_a]:text-blue-500 [&_a]:hover:text-blue-600 dark:[&_a]:text-blue-400 dark:[&_a]:hover:text-blue-300"- dangerouslySetInnerHTML={{ __html: details.description }}+ dangerouslySetInnerHTML={{ __html: sanitize(details.description) }}/>)}{errors[key] && <p className="text-xs text-red-500">{errors[key]?.message}</p>}