Enhanced ChatGPT Clone: Features Agents, MCP, Skills, DeepSeek, Anthropic, AWS, OpenAI, Responses API, Azure, Groq, o1, GPT-5, Mistral, OpenRouter, Vertex AI, Gemini, Artifacts, AI model switching, message search, Code Interpreter, langchain, DALL-E-3, OpenAPI Actions, Functions, Secure Multi-User Auth, Presets, open-source for self-hosting. Active
TypeScript aianthropicartifactsawsazurechatgptchatgpt-cloneclaudeclonedeepseekgeminigooglegpt-5librechatmcpo1openairesponses-apivisionwebui
🔒 fix: Remove Owner Email from Agent `owner_contact` Fallback (#14541)
Danny Avila8e165eb451a0
diff --git a/api/server/controllers/agents/v1.spec.js b/api/server/controllers/agents/v1.spec.jsindex eecae7e537..bcababc9fe 100644--- a/api/server/controllers/agents/v1.spec.js+++ b/api/server/controllers/agents/v1.spec.js@@ -603,10 +603,30 @@ describe('Agent Controllers - Mass Assignment Protection', () => {expect(mockRes.status).toHaveBeenCalledWith(200);const response = mockRes.json.mock.calls[0][0];- expect(response.owner_contact).toEqual({- name: 'Primary Owner',- email: '[email protected]',+ expect(response.owner_contact).toEqual({ name: 'Primary Owner' });+ expect(response.owner_contact).not.toHaveProperty('email');+ });++ test('should omit owner_contact when the owner name and username are the account email', async () => {+ const email = '[email protected]';+ const owner = await createOwner({ name: email, username: email, email });+ const agent = await Agent.create({+ id: `agent_${uuidv4()}`,+ name: 'SSO Owner Agent',+ description: 'Owner has email-shaped name from SSO fallback',+ provider: 'openai',+ model: 'gpt-4',+ author: owner._id,});+ await grantAgentOwner({ agent, owner });++ mockReq.params = { id: agent.id };++ await getAgentHandler(mockReq, mockRes);++ expect(mockRes.status).toHaveBeenCalledWith(200);+ const response = mockRes.json.mock.calls[0][0];+ expect(response.owner_contact).toBeUndefined();});test('should not return owner_contact when support_contact is present', async () => {@@ -1556,10 +1576,8 @@ describe('Agent Controllers - Mass Assignment Protection', () => {await getListAgentsHandler(mockReq, mockRes);const response = mockRes.json.mock.calls[0][0];- expect(response.data[0].owner_contact).toEqual({- name: 'List Owner',- email: '[email protected]',- });+ expect(response.data[0].owner_contact).toEqual({ name: 'List Owner' });+ expect(response.data[0].owner_contact).not.toHaveProperty('email');});test('should use the first ACL owner when an agent has multiple owners', async () => {@@ -1589,10 +1607,7 @@ describe('Agent Controllers - Mass Assignment Protection', () => {await getListAgentsHandler(mockReq, mockRes);const response = mockRes.json.mock.calls[0][0];- expect(response.data[0].owner_contact).toEqual({- name: 'First Owner',- email: '[email protected]',- });+ expect(response.data[0].owner_contact).toEqual({ name: 'First Owner' });});test('should omit owner_contact when no owner user can be resolved', async () => {diff --git a/api/server/services/Agents/ownerContact.js b/api/server/services/Agents/ownerContact.jsindex f73e704276..61a9b2a2c6 100644--- a/api/server/services/Agents/ownerContact.js+++ b/api/server/services/Agents/ownerContact.js@@ -59,7 +59,7 @@ const attachOwnerContacts = async (agents) => {let ownersById = new Map();if (ownerIds.length > 0) {try {- const users = await db.findUsers({ _id: { $in: ownerIds } }, 'name username email');+ const users = await db.findUsers({ _id: { $in: ownerIds } }, 'name username');ownersById = new Map(users.map((user) => [user?._id?.toString(), user]));} catch (error) {logger.warn('[/Agents] Failed to resolve agent owner users', error);diff --git a/client/src/components/Agents/AgentContact.tsx b/client/src/components/Agents/AgentContact.tsxindex 73f8524165..34319a01eb 100644--- a/client/src/components/Agents/AgentContact.tsx+++ b/client/src/components/Agents/AgentContact.tsx@@ -12,12 +12,11 @@ export default function AgentContact({ agent, className = '' }: AgentContactPropconst supportName = agent?.support_contact?.name?.trim() ?? '';const supportEmail = agent?.support_contact?.email?.trim() ?? '';const ownerName = agent?.owner_contact?.name?.trim() ?? '';- const ownerEmail = agent?.owner_contact?.email?.trim() ?? '';let contact: { name: string; email: string } | null = null;if (supportName || supportEmail) {contact = { name: supportName, email: supportEmail };- } else if (ownerName || ownerEmail) {- contact = { name: ownerName, email: ownerEmail };+ } else if (ownerName) {+ contact = { name: ownerName, email: '' };}const label = contact?.name || contact?.email || localize('com_agents_no_contact_available');diff --git a/client/src/components/Agents/tests/AgentCard.spec.tsx b/client/src/components/Agents/tests/AgentCard.spec.tsxindex 1d968f34ea..99395d80cb 100644--- a/client/src/components/Agents/tests/AgentCard.spec.tsx+++ b/client/src/components/Agents/tests/AgentCard.spec.tsx@@ -324,7 +324,6 @@ describe('AgentCard', () => {authorName: 'John Doe',owner_contact: {name: 'Owner User',- email: '[email protected]',},};@@ -335,10 +334,8 @@ describe('AgentCard', () => {);expect(screen.getByText('Contact:')).toBeInTheDocument();- expect(screen.getByRole('link', { name: 'Owner User' })).toHaveAttribute(- 'href',- 'mailto:[email protected]',- );+ expect(screen.getByText('Owner User')).toBeInTheDocument();+ expect(screen.queryByRole('link', { name: 'Owner User' })).not.toBeInTheDocument();expect(screen.queryByText('by John Doe')).not.toBeInTheDocument();});diff --git a/client/src/components/Agents/tests/AgentContact.spec.tsx b/client/src/components/Agents/tests/AgentContact.spec.tsxindex 5225f6c85c..c5f2d72bda 100644--- a/client/src/components/Agents/tests/AgentContact.spec.tsx+++ b/client/src/components/Agents/tests/AgentContact.spec.tsx@@ -24,7 +24,7 @@ describe('AgentContact', () => {agent={{support_contact: { name: 'Support Team', email: '[email protected]' },- owner_contact: { name: 'Owner User', email: '[email protected]' },+ owner_contact: { name: 'Owner User' },} as any}/>,@@ -38,7 +38,7 @@ describe('AgentContact', () => {expect(screen.queryByText('Owner User')).not.toBeInTheDocument();});- it('falls back to owner contact', () => {+ it('falls back to owner contact as a plain name without a mailto link', () => {render(<AgentContactagent={@@ -50,15 +50,6 @@ describe('AgentContact', () => {/>,);- expect(screen.getByRole('link', { name: 'Owner User' })).toHaveAttribute(- 'href',- 'mailto:[email protected]',- );- });-- it('renders a plain name when no email is available', () => {- render(<AgentContact agent={{ owner_contact: { name: 'Owner User' } } as any} />);-expect(screen.getByText('Owner User')).toBeInTheDocument();expect(screen.queryByRole('link')).not.toBeInTheDocument();});diff --git a/client/src/components/Agents/tests/AgentDetailContent.spec.tsx b/client/src/components/Agents/tests/AgentDetailContent.spec.tsxindex 19a2b5ef6d..a60b8dd870 100644--- a/client/src/components/Agents/tests/AgentDetailContent.spec.tsx+++ b/client/src/components/Agents/tests/AgentDetailContent.spec.tsx@@ -101,7 +101,7 @@ describe('AgentDetailContent', () => {{...baseAgent,support_contact: { name: 'Support Team', email: '[email protected]' },- owner_contact: { name: 'Owner User', email: '[email protected]' },+ owner_contact: { name: 'Owner User' },} as any}/>,@@ -121,15 +121,13 @@ describe('AgentDetailContent', () => {agent={{...baseAgent,- owner_contact: { name: 'Owner User', email: '[email protected]' },+ owner_contact: { name: 'Owner User' },} as any}/>,);- expect(screen.getByRole('link', { name: 'Owner User' })).toHaveAttribute(- 'href',- 'mailto:[email protected]',- );+ expect(screen.getByText('Owner User')).toBeInTheDocument();+ expect(screen.queryByRole('link', { name: 'Owner User' })).not.toBeInTheDocument();});});diff --git a/client/src/components/Chat/__tests__/Landing.agent-contact.spec.tsx b/client/src/components/Chat/__tests__/Landing.agent-contact.spec.tsxindex d954c3c91b..367ffe012f 100644--- a/client/src/components/Chat/__tests__/Landing.agent-contact.spec.tsx+++ b/client/src/components/Chat/__tests__/Landing.agent-contact.spec.tsx@@ -106,7 +106,7 @@ describe('Landing agent contact', () => {id: 'agent-1',name: 'Portal Remote Agent',description: 'Remote Agent Showcase',- owner_contact: { name: 'Owner User', email: '[email protected]' },+ owner_contact: { name: 'Owner User' },},};@@ -115,10 +115,8 @@ describe('Landing agent contact', () => {expect(screen.getByText('Portal Remote Agent')).toBeInTheDocument();expect(screen.getByText('Remote Agent Showcase')).toBeInTheDocument();expect(screen.getByText('Contact:')).toBeInTheDocument();- expect(screen.getByRole('link', { name: 'Owner User' })).toHaveAttribute(- 'href',- 'mailto:[email protected]',- );+ expect(screen.getByText('Owner User')).toBeInTheDocument();+ expect(screen.queryByRole('link', { name: 'Owner User' })).not.toBeInTheDocument();});it('does not show contact when the selected agent is missing from agentsMap', () => {diff --git a/packages/api/src/agents/contact.spec.ts b/packages/api/src/agents/contact.spec.tsindex 1ac5d81ae2..d8a1cd7ff3 100644--- a/packages/api/src/agents/contact.spec.ts+++ b/packages/api/src/agents/contact.spec.ts@@ -1,10 +1,11 @@+import type { AgentOwnerContactSource } from './contact';import { resolveAgentOwnerContact } from './contact';describe('resolveAgentOwnerContact', () => {it('omits owner fallback when support contact has a name', () => {const result = resolveAgentOwnerContact({ support_contact: { name: 'Support Team' } },- { name: 'Agent Owner', email: '[email protected]' },+ { name: 'Agent Owner' },);expect(result).toBeUndefined();@@ -13,19 +14,56 @@ describe('resolveAgentOwnerContact', () => {it('omits owner fallback when support contact has an email', () => {const result = resolveAgentOwnerContact({ support_contact: { email: '[email protected]' } },- { name: 'Agent Owner', email: '[email protected]' },+ { name: 'Agent Owner' },);expect(result).toBeUndefined();});- it('uses owner name and email when support contact is empty', () => {+ it('uses owner name when support contact is empty', () => {const result = resolveAgentOwnerContact({ support_contact: { name: ' ', email: '' } },- { name: ' Agent Owner ', email: ' [email protected] ' },+ { name: ' Agent Owner ' },);- expect(result).toEqual({ name: 'Agent Owner', email: '[email protected]' });+ expect(result).toEqual({ name: 'Agent Owner' });+ });++ it('never exposes an owner account email', () => {+ const result = resolveAgentOwnerContact({}, {+ name: 'Agent Owner',+ email: '[email protected]',+ } as AgentOwnerContactSource);++ expect(result).toEqual({ name: 'Agent Owner' });+ expect(result).not.toHaveProperty('email');+ });++ it('skips email-shaped owner names from auth-strategy fallbacks', () => {+ const result = resolveAgentOwnerContact(+ {},+ { name: '[email protected]', username: 'owner.user' },+ );++ expect(result).toEqual({ name: 'owner.user' });+ });++ it('omits owner contact when every display-name candidate is email-shaped', () => {+ const result = resolveAgentOwnerContact(+ { authorName: '[email protected]' },+ { name: '[email protected]', username: '[email protected]' },+ );++ expect(result).toBeUndefined();+ });++ it('skips emails with quoted local parts containing whitespace', () => {+ const result = resolveAgentOwnerContact(+ {},+ { name: '"given family"@example.com', username: 'owner.user' },+ );++ expect(result).toEqual({ name: 'owner.user' });});it('falls back to username for owner display name', () => {@@ -35,12 +73,9 @@ describe('resolveAgentOwnerContact', () => {});it('falls back to authorName when owner has no display name', () => {- const result = resolveAgentOwnerContact(- { authorName: 'Legacy Author' },- { email: '[email protected]' },- );+ const result = resolveAgentOwnerContact({ authorName: 'Legacy Author' }, { name: '' });- expect(result).toEqual({ name: 'Legacy Author', email: '[email protected]' });+ expect(result).toEqual({ name: 'Legacy Author' });});it('omits owner contact when no owner can be resolved', () => {@@ -49,11 +84,12 @@ describe('resolveAgentOwnerContact', () => {expect(result).toBeUndefined();});- it('omits owner contact when all candidate fields are empty', () => {- const result = resolveAgentOwnerContact(- { authorName: ' ' },- { name: '', username: ' ', email: ' ' },- );+ it('omits owner contact when no display name is available', () => {+ const result = resolveAgentOwnerContact({ authorName: ' ' }, {+ name: '',+ username: ' ',+ email: '[email protected]',+ } as AgentOwnerContactSource);expect(result).toBeUndefined();});diff --git a/packages/api/src/agents/contact.ts b/packages/api/src/agents/contact.tsindex e5a9824e0c..5a320f06d4 100644--- a/packages/api/src/agents/contact.ts+++ b/packages/api/src/agents/contact.ts@@ -11,7 +11,6 @@ export interface AgentContactSource {export interface AgentOwnerContactSource {name?: string | null;username?: string | null;- email?: string | null;}const normalizeContactValue = (value?: string | null): string | undefined => {@@ -22,6 +21,17 @@ const normalizeContactValue = (value?: string | null): string | undefined => {return trimmed.length > 0 ? trimmed : undefined;};+/** Auth strategies fall back to the account email for name/username, and legal+ * email forms include quoted local parts with whitespace, so any '@'-containing+ * value is treated as email-derived and never used as a public display name. */+const normalizeDisplayName = (value?: string | null): string | undefined => {+ const normalized = normalizeContactValue(value);+ if (normalized == null || normalized.includes('@')) {+ return undefined;+ }+ return normalized;+};+export const hasSupportContact = (agent: AgentContactSource): boolean => {const support = agent.support_contact;if (!support) {@@ -30,6 +40,11 @@ export const hasSupportContact = (agent: AgentContactSource): boolean => {return !!normalizeContactValue(support.name) || !!normalizeContactValue(support.email);};+/**+ * Resolves a display-only owner contact for agents without an explicit support contact.+ * Never includes the owner's account email, nor email-shaped display names; emails are+ * only exposed when the owner opts in by configuring `support_contact`.+ */export function resolveAgentOwnerContact(agent: AgentContactSource,owner: AgentOwnerContactSource | null,@@ -39,17 +54,13 @@ export function resolveAgentOwnerContact(}const name =- normalizeContactValue(owner.name) ??- normalizeContactValue(owner.username) ??- normalizeContactValue(agent.authorName);- const email = normalizeContactValue(owner.email);+ normalizeDisplayName(owner.name) ??+ normalizeDisplayName(owner.username) ??+ normalizeDisplayName(agent.authorName);- if (!name && !email) {+ if (!name) {return undefined;}- return {- ...(name ? { name } : {}),- ...(email ? { email } : {}),- };+ return { name };}diff --git a/packages/data-provider/src/types/assistants.ts b/packages/data-provider/src/types/assistants.tsindex 0a84f21e3d..7f6710a705 100644--- a/packages/data-provider/src/types/assistants.ts+++ b/packages/data-provider/src/types/assistants.ts@@ -211,7 +211,6 @@ export type SupportContact = {export type AgentOwnerContact = {name?: string;- email?: string;};/**