Enhanced ChatGPT Clone: Features Agents, MCP, Skills, DeepSeek, Anthropic, AWS, OpenAI, Responses API, Azure, Groq, o1, GPT-5, Mistral, OpenRouter, Vertex AI, Gemini, Artifacts, AI model switching, message search, Code Interpreter, langchain, DALL-E-3, OpenAPI Actions, Functions, Secure Multi-User Auth, Presets, open-source for self-hosting. Active
TypeScript aianthropicartifactsawsazurechatgptchatgpt-cloneclaudeclonedeepseekgeminigooglegpt-5librechatmcpo1openairesponses-apivisionwebui
🪤 chore: Scope Assistant Tool-Resource Lookups (#15579)
Danny Avila9a4336266374
diff --git a/api/server/routes/files/files.js b/api/server/routes/files/files.jsindex 7b2c3935c8..281afd1d54 100644--- a/api/server/routes/files/files.js+++ b/api/server/routes/files/files.js@@ -289,10 +289,10 @@ router.delete('/', async (req, res) => {/* Handle assistant unlinking even if no valid files to delete */if (req.body.assistant_id && req.body.tool_resource && dbFiles.length === 0) {const assistant = await db.getAssistant({- id: req.body.assistant_id,+ assistant_id: req.body.assistant_id,});- const toolResourceFiles = assistant.tool_resources?.[req.body.tool_resource]?.file_ids ?? [];+ const toolResourceFiles = assistant?.tool_resources?.[req.body.tool_resource]?.file_ids ?? [];const assistantFiles = files.filter((f) => toolResourceFiles.includes(f.file_id));const result = await processDeleteRequest({ req, files: assistantFiles });diff --git a/api/server/routes/files/files.test.js b/api/server/routes/files/files.test.jsindex 8d80a9bbf0..2ad58d350d 100644--- a/api/server/routes/files/files.test.js+++ b/api/server/routes/files/files.test.js@@ -694,6 +694,83 @@ describe('File Routes - Delete with Agent Access', () => {});});+ /* Mirrors api/db/connect.js, which sets strictQuery for the running server. Under it+ Mongoose DROPS filter keys absent from the schema, so a lookup on a misspelled path+ degrades to findOne({}) — the first document in the collection, whoever owns it. */+ describe('DELETE /files - assistant tool resource unlinking', () => {+ let previousStrictQuery;++ beforeAll(() => {+ previousStrictQuery = mongoose.get('strictQuery');+ mongoose.set('strictQuery', true);+ });++ afterAll(async () => {+ mongoose.set('strictQuery', previousStrictQuery);+ await mongoose.connection.collection('assistants').deleteMany({});+ });++ beforeEach(async () => {+ await mongoose.connection.collection('assistants').deleteMany({});+ });++ it("does not unlink another user's assistant files when the requested assistant is missing", async () => {+ const strangerFileId = uuidv4();+ /* Written straight to the collection: `tool_resources` predates the current schema. */+ await mongoose.connection.collection('assistants').insertOne({+ user: new mongoose.Types.ObjectId(),+ assistant_id: 'asst_belonging_to_someone_else',+ tool_resources: { file_search: { file_ids: [strangerFileId] } },+ });++ const response = await request(app)+ .delete('/files')+ .send({+ assistant_id: 'asst_that_does_not_exist',+ tool_resource: 'file_search',+ files: [{ file_id: strangerFileId, filepath: '/uploads/stranger.txt' }],+ });++ expect(response.status).toBe(200);+ expect(processDeleteRequest).toHaveBeenCalledWith(expect.objectContaining({ files: [] }));+ });++ it('unlinks the requested assistant own files', async () => {+ const ownFileId = uuidv4();+ await mongoose.connection.collection('assistants').insertOne({+ user: new mongoose.Types.ObjectId(),+ assistant_id: 'asst_requested',+ tool_resources: { file_search: { file_ids: [ownFileId] } },+ });++ const response = await request(app)+ .delete('/files')+ .send({+ assistant_id: 'asst_requested',+ tool_resource: 'file_search',+ files: [{ file_id: ownFileId, filepath: '/uploads/own.txt' }],+ });++ expect(response.status).toBe(200);+ expect(processDeleteRequest).toHaveBeenCalledWith(+ expect.objectContaining({ files: [expect.objectContaining({ file_id: ownFileId })] }),+ );+ });++ it('answers instead of throwing when no assistants exist at all', async () => {+ const response = await request(app)+ .delete('/files')+ .send({+ assistant_id: 'asst_that_does_not_exist',+ tool_resource: 'file_search',+ files: [{ file_id: uuidv4(), filepath: '/uploads/ghost.txt' }],+ });++ expect(response.status).toBe(200);+ expect(processDeleteRequest).toHaveBeenCalledWith(expect.objectContaining({ files: [] }));+ });+ });+describe('GET /files/download-url/:userId/:file_id', () => {it('returns a direct signed download URL when the strategy supports it', async () => {const userFileId = uuidv4();