Skip to content

Enhanced ChatGPT Clone: Features Agents, MCP, Skills, DeepSeek, Anthropic, AWS, OpenAI, Responses API, Azure, Groq, o1, GPT-5, Mistral, OpenRouter, Vertex AI, Gemini, Artifacts, AI model switching, message search, Code Interpreter, langchain, DALL-E-3, OpenAPI Actions, Functions, Secure Multi-User Auth, Presets, open-source for self-hosting. Active

🥇 fix: Read Account Deletion Fences From the Primary (#17456)

lia-by-librechat[bot]a63e96a07255
diff --git a/packages/data-schemas/src/methods/triggerDelivery.spec.ts b/packages/data-schemas/src/methods/triggerDelivery.spec.ts
index 0ac73a3f28..65ccd3ef03 100644
--- a/packages/data-schemas/src/methods/triggerDelivery.spec.ts
+++ b/packages/data-schemas/src/methods/triggerDelivery.spec.ts
@@ -53,14 +53,22 @@ let counter = 0;
beforeAll(async () => {
mongoServer = await MongoMemoryServer.create();
- await mongoose.connect(mongoServer.getUri());
+ const uri = new URL(mongoServer.getUri());
+ uri.searchParams.set('readPreference', 'secondaryPreferred');
+ await mongoose.connect(uri.href);
Delivery = createAgentTriggerDeliveryModel(mongoose);
LaneSequence = createAgentTriggerLaneSequenceModel(mongoose);
UserPurge = createAgentTriggerUserPurgeModel(mongoose);
User = createUserModel(mongoose);
createConversationModel(mongoose);
createMessageModel(mongoose);
- await Promise.all([Delivery.init(), LaneSequence.init(), UserPurge.init(), User.init()]);
+ // Secondary-read connections disable Mongoose's automatic index creation.
+ await Promise.all([
+ Delivery.createIndexes(),
+ LaneSequence.createIndexes(),
+ UserPurge.createIndexes(),
+ User.createIndexes(),
+ ]);
methods = createAgentTriggerDeliveryMethods(mongoose, {
releaseBatchProjections: createMessageMethods(mongoose).releaseBackgroundToolResultClaims,
});
@@ -5498,6 +5506,7 @@ describe('agent trigger delivery methods', () => {
});
it('serializes account deletion against action admission on each delivery row', async () => {
+ expect(mongoose.connection.getClient().options.readPreference?.mode).toBe('secondaryPreferred');
const user = new mongoose.Types.ObjectId();
const fenceStartedAt = new Date(START);
await User.create({
@@ -5529,8 +5538,13 @@ describe('agent trigger delivery methods', () => {
admissionId: 'admission-before-purge',
};
+ const fenceReads = jest.spyOn(User.collection, 'findOne');
await expect(methods.admitAgentEventActorAction(admission)).resolves.toBe(true);
await methods.prepareAgentTriggerUserPurge(user, fenceStartedAt);
+ expect(fenceReads).toHaveBeenLastCalledWith(
+ { _id: user, agentTriggerDeletionStartedAt: fenceStartedAt },
+ expect.objectContaining({ readPreference: { mode: 'primary' } }),
+ );
await expect(
methods.countActiveAgentTriggerDeliveriesByUser(user, new Date(START.getTime() + 60_001)),
).resolves.toBe(1);
@@ -5545,7 +5559,12 @@ describe('agent trigger delivery methods', () => {
Delivery.countDocuments({ user, actorActionAdmissionClosedAt: fenceStartedAt }),
).resolves.toBe(2);
+ fenceReads.mockClear();
await expect(methods.cancelAgentTriggerUserPurge(user, fenceStartedAt)).resolves.toBe(true);
+ expect(fenceReads).toHaveBeenCalledWith(
+ { _id: user, agentTriggerDeletionStartedAt: fenceStartedAt },
+ expect.objectContaining({ readPreference: { mode: 'primary' } }),
+ );
await expect(
Delivery.countDocuments({ user, actorActionAdmissionClosedAt: { $exists: true } }),
).resolves.toBe(0);
@@ -5631,7 +5650,15 @@ describe('agent trigger delivery methods', () => {
await methods.enqueueAgentTriggerDelivery(enqueueInput({ user }));
await methods.prepareAgentTriggerUserPurge(user, fenceStartedAt, 'tenant-1');
+ const fenceReads = jest.spyOn(User.collection, 'find');
await expect(methods.recoverAgentTriggerUserPurges()).resolves.toBe(0);
+ expect(fenceReads).toHaveBeenCalledWith(
+ { _id: { $in: [user] } },
+ expect.objectContaining({
+ projection: { agentTriggerDeletionStartedAt: 1 },
+ readPreference: { mode: 'primary' },
+ }),
+ );
expect(await Delivery.countDocuments({ user })).toBe(1);
expect(await UserPurge.countDocuments({ _id: user })).toBe(1);
diff --git a/packages/data-schemas/src/methods/triggerDelivery.ts b/packages/data-schemas/src/methods/triggerDelivery.ts
index d269edd28d..bc54552e50 100644
--- a/packages/data-schemas/src/methods/triggerDelivery.ts
+++ b/packages/data-schemas/src/methods/triggerDelivery.ts
@@ -4827,7 +4827,7 @@ export function createAgentTriggerDeliveryMethods(
const ownsFence = await mongoose.models.User.exists({
_id: user,
agentTriggerDeletionStartedAt: fenceStartedAt,
- });
+ }).read('primary');
if (ownsFence == null) {
throw new Error('Cannot prepare trigger purge without owning the user deletion fence');
}
@@ -4856,7 +4856,7 @@ export function createAgentTriggerDeliveryMethods(
const ownsLiveFence = await mongoose.models.User.exists({
_id: user,
agentTriggerDeletionStartedAt: fenceStartedAt,
- });
+ }).read('primary');
if (ownsLiveFence == null) {
return false;
}
@@ -4912,6 +4912,7 @@ export function createAgentTriggerDeliveryMethods(
const users =
markers.length > 0
? await mongoose.models.User.find({ _id: { $in: markers.map((marker) => marker._id) } })
+ .read('primary')
.select('agentTriggerDeletionStartedAt')
.lean<Array<{ _id: Types.ObjectId; agentTriggerDeletionStartedAt?: Date }>>()
: [];