Enhanced ChatGPT Clone: Features Agents, MCP, Skills, DeepSeek, Anthropic, AWS, OpenAI, Responses API, Azure, Groq, o1, GPT-5, Mistral, OpenRouter, Vertex AI, Gemini, Artifacts, AI model switching, message search, Code Interpreter, langchain, DALL-E-3, OpenAPI Actions, Functions, Secure Multi-User Auth, Presets, open-source for self-hosting. Active
TypeScript aianthropicartifactsawsazurechatgptchatgpt-cloneclaudeclonedeepseekgeminigooglegpt-5librechatmcpo1openairesponses-apivisionwebui
👻 fix: Prevent Async Title Generation From Recreating Deleted Conversations (#11797)
Danny Avilab0a32b7d6d79
diff --git a/api/models/Conversation.js b/api/models/Conversation.jsindex a8f5f9a36c..32eac1a764 100644--- a/api/models/Conversation.js+++ b/api/models/Conversation.js@@ -124,10 +124,15 @@ module.exports = {updateOperation,{new: true,- upsert: true,+ upsert: metadata?.noUpsert !== true,},);+ if (!conversation) {+ logger.debug('[saveConvo] Conversation not found, skipping update');+ return null;+ }+return conversation.toObject();} catch (error) {logger.error('[saveConvo] Error saving conversation', error);diff --git a/api/models/Conversation.spec.js b/api/models/Conversation.spec.jsindex b6237d5f15..bd415b4165 100644--- a/api/models/Conversation.spec.js+++ b/api/models/Conversation.spec.js@@ -106,6 +106,47 @@ describe('Conversation Operations', () => {expect(result.conversationId).toBe(newConversationId);});+ it('should not create a conversation when noUpsert is true and conversation does not exist', async () => {+ const nonExistentId = uuidv4();+ const result = await saveConvo(+ mockReq,+ { conversationId: nonExistentId, title: 'Ghost Title' },+ { noUpsert: true },+ );++ expect(result).toBeNull();++ const dbConvo = await Conversation.findOne({ conversationId: nonExistentId });+ expect(dbConvo).toBeNull();+ });++ it('should update an existing conversation when noUpsert is true', async () => {+ await saveConvo(mockReq, mockConversationData);++ const result = await saveConvo(+ mockReq,+ { conversationId: mockConversationData.conversationId, title: 'Updated Title' },+ { noUpsert: true },+ );++ expect(result).not.toBeNull();+ expect(result.title).toBe('Updated Title');+ expect(result.conversationId).toBe(mockConversationData.conversationId);+ });++ it('should still upsert by default when noUpsert is not provided', async () => {+ const newId = uuidv4();+ const result = await saveConvo(mockReq, {+ conversationId: newId,+ title: 'New Conversation',+ endpoint: EModelEndpoint.openAI,+ });++ expect(result).not.toBeNull();+ expect(result.conversationId).toBe(newId);+ expect(result.title).toBe('New Conversation');+ });+it('should handle unsetFields metadata', async () => {const metadata = {unsetFields: { someField: 1 },@@ -122,7 +163,6 @@ describe('Conversation Operations', () => {describe('isTemporary conversation handling', () => {it('should save a conversation with expiredAt when isTemporary is true', async () => {- // Mock app config with 24 hour retentionmockReq.config.interfaceConfig.temporaryChatRetention = 24;mockReq.body = { isTemporary: true };@@ -135,7 +175,6 @@ describe('Conversation Operations', () => {expect(result.expiredAt).toBeDefined();expect(result.expiredAt).toBeInstanceOf(Date);- // Verify expiredAt is approximately 24 hours in the futureconst expectedExpirationTime = new Date(beforeSave.getTime() + 24 * 60 * 60 * 1000);const actualExpirationTime = new Date(result.expiredAt);@@ -157,7 +196,6 @@ describe('Conversation Operations', () => {});it('should save a conversation without expiredAt when isTemporary is not provided', async () => {- // No isTemporary in bodymockReq.body = {};const result = await saveConvo(mockReq, mockConversationData);@@ -167,7 +205,6 @@ describe('Conversation Operations', () => {});it('should use custom retention period from config', async () => {- // Mock app config with 48 hour retentionmockReq.config.interfaceConfig.temporaryChatRetention = 48;mockReq.body = { isTemporary: true };diff --git a/api/server/services/Endpoints/agents/title.js b/api/server/services/Endpoints/agents/title.jsindex 1d6d359bd6..e31cdeea11 100644--- a/api/server/services/Endpoints/agents/title.js+++ b/api/server/services/Endpoints/agents/title.js@@ -71,7 +71,7 @@ const addTitle = async (req, { text, response, client }) => {conversationId: response.conversationId,title,},- { context: 'api/server/services/Endpoints/agents/title.js' },+ { context: 'api/server/services/Endpoints/agents/title.js', noUpsert: true },);} catch (error) {logger.error('Error generating title:', error);diff --git a/api/server/services/Endpoints/assistants/title.js b/api/server/services/Endpoints/assistants/title.jsindex a34de4d1af..1fae68cf54 100644--- a/api/server/services/Endpoints/assistants/title.js+++ b/api/server/services/Endpoints/assistants/title.js@@ -69,7 +69,7 @@ const addTitle = async (req, { text, responseText, conversationId }) => {conversationId,title,},- { context: 'api/server/services/Endpoints/assistants/addTitle.js' },+ { context: 'api/server/services/Endpoints/assistants/addTitle.js', noUpsert: true },);} catch (error) {logger.error('[addTitle] Error generating title:', error);@@ -81,7 +81,7 @@ const addTitle = async (req, { text, responseText, conversationId }) => {conversationId,title: fallbackTitle,},- { context: 'api/server/services/Endpoints/assistants/addTitle.js' },+ { context: 'api/server/services/Endpoints/assistants/addTitle.js', noUpsert: true },);}};