Skip to content

Enhanced ChatGPT Clone: Features Agents, MCP, Skills, DeepSeek, Anthropic, AWS, OpenAI, Responses API, Azure, Groq, o1, GPT-5, Mistral, OpenRouter, Vertex AI, Gemini, Artifacts, AI model switching, message search, Code Interpreter, langchain, DALL-E-3, OpenAPI Actions, Functions, Secure Multi-User Auth, Presets, open-source for self-hosting. Active

🌐 fix(actions): Correct URL Formation for Subdomains in `createURL` (#3149)

Danny Avilab2b469bd3dbe
diff --git a/packages/data-provider/specs/actions.spec.ts b/packages/data-provider/specs/actions.spec.ts
index 09ddf857b1..9e18a48ad8 100644
--- a/packages/data-provider/specs/actions.spec.ts
+++ b/packages/data-provider/specs/actions.spec.ts
@@ -1,6 +1,7 @@
import axios from 'axios';
import { OpenAPIV3 } from 'openapi-types';
import {
+ createURL,
resolveRef,
ActionRequest,
openapiToFunction,
@@ -506,3 +507,45 @@ describe('validateAndParseOpenAPISpec', () => {
expect(requestBuilders).toHaveProperty('saveCitation');
});
});
+
+describe('createURL', () => {
+ it('correctly combines domain and path', () => {
+ expect(createURL('https://example.com', '/api/v1/users')).toBe(
+ 'https://example.com/api/v1/users',
+ );
+ });
+
+ it('handles domain with trailing slash', () => {
+ expect(createURL('https://example.com/', '/api/v1/users')).toBe(
+ 'https://example.com/api/v1/users',
+ );
+ });
+
+ it('handles path with leading slash', () => {
+ expect(createURL('https://example.com', 'api/v1/users')).toBe(
+ 'https://example.com/api/v1/users',
+ );
+ });
+
+ it('handles domain with trailing slash and path with leading slash', () => {
+ expect(createURL('https://example.com/', '/api/v1/users')).toBe(
+ 'https://example.com/api/v1/users',
+ );
+ });
+
+ it('handles domain without trailing slash and path without leading slash', () => {
+ expect(createURL('https://example.com', 'api/v1/users')).toBe(
+ 'https://example.com/api/v1/users',
+ );
+ });
+
+ it('handles empty path', () => {
+ expect(createURL('https://example.com', '')).toBe('https://example.com/');
+ });
+
+ it('handles domain with subdirectory', () => {
+ expect(createURL('https://example.com/subdirectory', '/api/v1/users')).toBe(
+ 'https://example.com/subdirectory/api/v1/users',
+ );
+ });
+});
diff --git a/packages/data-provider/src/actions.ts b/packages/data-provider/src/actions.ts
index 120ab3d7b4..0e1260d5db 100644
--- a/packages/data-provider/src/actions.ts
+++ b/packages/data-provider/src/actions.ts
@@ -32,8 +32,10 @@ export function sha1(input: string) {
}
export function createURL(domain: string, path: string) {
- const myURL = new URL(path, domain);
- return myURL.toString();
+ const cleanDomain = domain.replace(/\/$/, '');
+ const cleanPath = path.replace(/^\//, '');
+ const fullURL = `${cleanDomain}/${cleanPath}`;
+ return new URL(fullURL).toString();
}
export class FunctionSignature {
@@ -92,7 +94,7 @@ export class ActionRequest {
private authHeaders: Record<string, string> = {};
private authToken?: string;
- async setParams(params: object) {
+ setParams(params: object) {
this.operationHash = sha1(JSON.stringify(params));
this.params = params;