Enhanced ChatGPT Clone: Features Agents, MCP, Skills, DeepSeek, Anthropic, AWS, OpenAI, Responses API, Azure, Groq, o1, GPT-5, Mistral, OpenRouter, Vertex AI, Gemini, Artifacts, AI model switching, message search, Code Interpreter, langchain, DALL-E-3, OpenAPI Actions, Functions, Secure Multi-User Auth, Presets, open-source for self-hosting. Active
TypeScript aianthropicartifactsawsazurechatgptchatgpt-cloneclaudeclonedeepseekgeminigooglegpt-5librechatmcpo1openairesponses-apivisionwebui
🍃 test: Restore Sweep Coverage of Typed-Criteria Methods (#15609)
Danny Avilac13990a39890
diff --git a/packages/data-schemas/misc/documentdb/documentdb-compat.md b/packages/data-schemas/misc/documentdb/documentdb-compat.mdindex 245ab2b4e7..8152e360c2 100644--- a/packages/data-schemas/misc/documentdb/documentdb-compat.md+++ b/packages/data-schemas/misc/documentdb/documentdb-compat.md@@ -263,10 +263,16 @@ matrices (`SWEEP_REPORT_PATH`).Corrected-harness baseline (replica-set MongoDB, real ACL cascades, index DDLand transaction-lifecycle instrumentation, per-invocation async attribution,seeded authority-transaction case, constructor exports excluded, a fresh-method bundle per case): **370 of 509 methods issue at least one query; zero-rejections on MongoDB**. The remaining 139 issue none (validation+method bundle per case, criteria-shaped parameters synthesized as objects):+**385 of 518 methods issue at least one query; zero rejections on MongoDB**.+The remaining 133 issue none (validationrejected the synthesized arguments, or a guard short-circuited); they are-listed in the matrix and shrink by adding `ARG_OVERRIDES` entries. The report's `rows` payload is normalized for+listed in the matrix and shrink by adding `ARG_OVERRIDES` entries. Watch this count across releases: the typed+criteria refactor (#15580) silently took six adjudicated methods to+un-driven because the sweep synthesized a string for a `query` parameter and+`buildFilter` fails closed on it — a coverage regression that a green suite+hides. Diffing matrices, not reading the pass line, is what catches it. The+report's `rows` payload is normalized forcross-engine diffing (`diff <(jq .rows a.json) <(jq .rows b.json)`); runmetadata lives outside it.diff --git a/packages/data-schemas/misc/documentdb/sweep.documentdb.spec.ts b/packages/data-schemas/misc/documentdb/sweep.documentdb.spec.tsindex b579718173..9e5eae1cfb 100644--- a/packages/data-schemas/misc/documentdb/sweep.documentdb.spec.ts+++ b/packages/data-schemas/misc/documentdb/sweep.documentdb.spec.ts@@ -260,6 +260,16 @@ const ARRAY_PARAMS =function valueFor(name: string): unknown {if (name === 'mongoose') return mongoose;if (name === 'kind') return 'manual';+ /** Typed-criteria parameters (`utils/criteria.ts`) are validated key by key+ * and fail closed, so a synthesized string is read as a criteria object and+ * rejected at index '0'. An empty criteria object is valid, builds an empty+ * filter, and still reaches the engine. `searchMessages` is the sole method+ * whose `query` parameter is a genuine string (verified across+ * `src/methods`); it carries an `ARG_OVERRIDES` entry so it keeps one. A+ * future string-valued `query`/`criteria`/`filter` parameter would need the+ * same treatment — the symptom is a method reporting `threw` on a type+ * error rather than reaching the database. */+ if (/^(query|criteria|filter)$/.test(name)) return {};if (/pipeline/i.test(name)) return [{ $match: { _id: objectId() } }];if (OBJECT_ID_PARAMS.test(name)) return objectId();if (ARRAY_PARAMS.test(name)) return [`sweep-${name}-${runId}`];@@ -289,7 +299,7 @@ function replaceValue(node: unknown, target: string, replacement: unknown): unkn/** Repairs synthesized arguments from a validation error's own message, so the* retry reaches the database instead of being reported `not-driven`. Returns* the repaired arguments, or null when the error is not machine-repairable. */-function adaptArgs(args: unknown[], error: unknown): unknown[] | null {+function adaptArgs(args: unknown[], error: unknown, paramNames: string[] = []): unknown[] | null {const message = String((error as { message?: string })?.message ?? '');let match = /Cast to (?:\[)?ObjectId(?:\])? failed for value "+?\[?'?"?([^"'\]]+)/.exec(message);if (match != null) {@@ -349,6 +359,11 @@ const ARG_OVERRIDES: Record<string, () => SweepCase | Promise<SweepCase>> = {/** Positional (searchParameter, id): a synthesized string for the first* parameter lands inside a `$match` and malforms it on both engines. */getAgentWithVersionCount: () => ({ args: [{ id: `agent-sweep-${runId}` }] }),+ /** Takes a genuine search string, not typed criteria: the criteria-shaped+ * synthesis above would hand it an object, which a Meili-enabled deployment+ * forwards verbatim into `meiliSearch` and adjudicates a harness-generated+ * request instead of the method's real behavior. */+ searchMessages: () => ({ args: [`sweep-search-${runId}`, { page: 1, limit: 2 }, false] }),/** The bounded authority snapshot is the one production path that COMMITS a* transaction; generic synthesis dies on target validation before a session* ever starts, which would leave the session instrumentation exercising