Skip to content

Enhanced ChatGPT Clone: Features Agents, MCP, Skills, DeepSeek, Anthropic, AWS, OpenAI, Responses API, Azure, Groq, o1, GPT-5, Mistral, OpenRouter, Vertex AI, Gemini, Artifacts, AI model switching, message search, Code Interpreter, langchain, DALL-E-3, OpenAPI Actions, Functions, Secure Multi-User Auth, Presets, open-source for self-hosting. Active

🐛 fix: RAG Results Sorted By Distance (#5931)

Danny Avilaecddffa7b241
diff --git a/api/app/clients/tools/util/fileSearch.js b/api/app/clients/tools/util/fileSearch.js
index c48adc2eb4..54da483362 100644
--- a/api/app/clients/tools/util/fileSearch.js
+++ b/api/app/clients/tools/util/fileSearch.js
@@ -106,19 +106,21 @@ const createFileSearchTool = async ({ req, files, entity_id }) => {
const formattedResults = validResults
.flatMap((result) =>
- result.data.map(([docInfo, relevanceScore]) => ({
+ result.data.map(([docInfo, distance]) => ({
filename: docInfo.metadata.source.split('/').pop(),
content: docInfo.page_content,
- relevanceScore,
+ distance,
})),
)
- .sort((a, b) => b.relevanceScore - a.relevanceScore)
- .slice(0, 5);
+ // TODO: results should be sorted by relevance, not distance
+ .sort((a, b) => a.distance - b.distance)
+ // TODO: make this configurable
+ .slice(0, 10);
const formattedString = formattedResults
.map(
(result) =>
- `File: ${result.filename}\nRelevance: ${result.relevanceScore.toFixed(4)}\nContent: ${
+ `File: ${result.filename}\nRelevance: ${1.0 - result.distance.toFixed(4)}\nContent: ${
result.content
}\n`,
)
diff --git a/api/server/services/Files/Local/crud.js b/api/server/services/Files/Local/crud.js
index e004eab79e..97a067d794 100644
--- a/api/server/services/Files/Local/crud.js
+++ b/api/server/services/Files/Local/crud.js
@@ -175,6 +175,17 @@ const isValidPath = (req, base, subfolder, filepath) => {
return normalizedFilepath.startsWith(normalizedBase);
};
+/**
+ * @param {string} filepath
+ */
+const unlinkFile = async (filepath) => {
+ try {
+ await fs.promises.unlink(filepath);
+ } catch (error) {
+ logger.error('Error deleting file:', error);
+ }
+};
+
/**
* Deletes a file from the filesystem. This function takes a file object, constructs the full path, and
* verifies the path's validity before deleting the file. If the path is invalid, an error is thrown.
@@ -217,7 +228,7 @@ const deleteLocalFile = async (req, file) => {
throw new Error(`Invalid file path: ${file.filepath}`);
}
- await fs.promises.unlink(filepath);
+ await unlinkFile(filepath);
return;
}
@@ -233,7 +244,7 @@ const deleteLocalFile = async (req, file) => {
throw new Error('Invalid file path');
}
- await fs.promises.unlink(filepath);
+ await unlinkFile(filepath);
};
/**