Enhanced ChatGPT Clone: Features Agents, MCP, Skills, DeepSeek, Anthropic, AWS, OpenAI, Responses API, Azure, Groq, o1, GPT-5, Mistral, OpenRouter, Vertex AI, Gemini, Artifacts, AI model switching, message search, Code Interpreter, langchain, DALL-E-3, OpenAPI Actions, Functions, Secure Multi-User Auth, Presets, open-source for self-hosting. Active
TypeScript aianthropicartifactsawsazurechatgptchatgpt-cloneclaudeclonedeepseekgeminigooglegpt-5librechatmcpo1openairesponses-apivisionwebui
🗂️ fix: Allow Empty-Overrides Scope Creation in Admin Config (#12492)
Danny Avilaf8405e731b35
diff --git a/packages/api/src/admin/config.handler.spec.ts b/packages/api/src/admin/config.handler.spec.tsindex bd1664fc90..ad33f5f158 100644--- a/packages/api/src/admin/config.handler.spec.ts+++ b/packages/api/src/admin/config.handler.spec.ts@@ -535,6 +535,93 @@ describe('createAdminConfigHandlers', () => {});});+ describe('upsertConfigOverrides — empty-overrides scope creation', () => {+ it('creates config document when overrides is empty but priority is provided', async () => {+ const upsertConfig = jest.fn().mockResolvedValue({+ _id: 'c1',+ principalType: 'role',+ principalId: 'admin',+ overrides: {},+ configVersion: 1,+ });+ const { handlers } = createHandlers({ upsertConfig });+ const req = mockReq({+ params: { principalType: 'role', principalId: 'admin' },+ body: { overrides: {}, priority: 5 },+ });+ const res = mockRes();++ await handlers.upsertConfigOverrides(req, res);++ expect(res.statusCode).toBe(201);+ expect(res.body).toHaveProperty('config');+ expect(res.body?.config).toHaveProperty('_id', 'c1');+ expect(upsertConfig).toHaveBeenCalledWith('role', 'admin', expect.anything(), {}, 5);+ });++ it('returns no-op message when overrides is empty and no priority is provided', async () => {+ const upsertConfig = jest.fn().mockResolvedValue(null);+ const { handlers } = createHandlers({ upsertConfig });+ const req = mockReq({+ params: { principalType: 'role', principalId: 'admin' },+ body: { overrides: {} },+ });+ const res = mockRes();++ await handlers.upsertConfigOverrides(req, res);++ expect(res.statusCode).toBe(200);+ expect(res.body).toHaveProperty('message', 'No actionable override sections provided');+ expect(upsertConfig).not.toHaveBeenCalled();+ });++ it('calls general manage check exactly once when overrides is empty with priority', async () => {+ const hasConfigCapability = jest.fn().mockResolvedValue(true);+ const { handlers } = createHandlers({ hasConfigCapability });+ const req = mockReq({+ params: { principalType: 'role', principalId: 'admin' },+ body: { overrides: {}, priority: 3 },+ });+ const res = mockRes();++ await handlers.upsertConfigOverrides(req, res);++ expect(hasConfigCapability).toHaveBeenCalledTimes(1);+ expect(hasConfigCapability).toHaveBeenCalledWith(expect.anything(), null, 'manage');+ expect(res.statusCode).toBe(201);+ expect(res.body).toHaveProperty('config');+ });++ it('returns 403 for empty overrides with priority when user lacks MANAGE_CONFIGS', async () => {+ const { handlers } = createHandlers({+ hasConfigCapability: jest.fn().mockResolvedValue(false),+ });+ const req = mockReq({+ params: { principalType: 'role', principalId: 'admin' },+ body: { overrides: {}, priority: 5 },+ });+ const res = mockRes();++ await handlers.upsertConfigOverrides(req, res);++ expect(res.statusCode).toBe(403);+ });++ it('returns 401 for empty overrides with priority when unauthenticated', async () => {+ const { handlers } = createHandlers();+ const req = mockReq({+ params: { principalType: 'role', principalId: 'admin' },+ body: { overrides: {}, priority: 5 },+ user: undefined,+ });+ const res = mockRes();++ await handlers.upsertConfigOverrides(req, res);++ expect(res.statusCode).toBe(401);+ });+ });+// ── Invariant tests: rules that must hold across ALL handlers ──────const MUTATION_HANDLERS: Array<{diff --git a/packages/api/src/admin/config.ts b/packages/api/src/admin/config.tsindex cca2d9901c..357096da9b 100644--- a/packages/api/src/admin/config.ts+++ b/packages/api/src/admin/config.ts@@ -333,18 +333,20 @@ export function createAdminConfigHandlers(deps: AdminConfigDeps) {const overrideSections = Object.keys(filteredOverrides);- if (overrideSections.length === 0) {+ if (overrideSections.length === 0 && priority == null) {return res.status(200).json({ message: 'No actionable override sections provided' });}- const allowed = await Promise.all(- overrideSections.map((s) => hasConfigCapability(user, s as ConfigSection, 'manage')),- );- const denied = overrideSections.find((_, i) => !allowed[i]);- if (denied) {- return res.status(403).json({- error: `Insufficient permissions for config section: ${denied}`,- });+ if (overrideSections.length > 0) {+ const allowed = await Promise.all(+ overrideSections.map((s) => hasConfigCapability(user, s as ConfigSection, 'manage')),+ );+ const denied = overrideSections.find((_, i) => !allowed[i]);+ if (denied) {+ return res.status(403).json({+ error: `Insufficient permissions for config section: ${denied}`,+ });+ }}const config = await upsertConfig(