Skip to content

Self-hosted workflows for coding-agent delivery. Orchestrate CodeBuddy, Codex and Claude Code with scripts and human approval gates. Includes Local workflows for coding assistants.

5.8 KB
Raw Blame
package repo

import (
	"strings"
	"testing"

	"agentflow/internal/domain"
)

func testStoreWithGenericTemplates(t *testing.T) *Store {
	t.Helper()
	s, err := OpenTest()
	if err != nil {
		t.Fatal(err)
	}
	t.Cleanup(func() { s.Close() })
	if err := SeedTestGenericTemplates(s); err != nil {
		t.Fatal(err)
	}
	return s
}

func TestGenericTemplatesLiveInDedicatedTable(t *testing.T) {
	s := testStoreWithGenericTemplates(t)
	want := []string{GenericBackendDeliveryWorkflowID, GenericProductDeliveryWorkflowID, GenericFrontendDeliveryWorkflowID}
	for _, id := range want {
		if _, stored := payloadOne[domain.WorkflowDefinition](s.DB, "workflows", id); stored {
			t.Fatalf("generic template %q must not occupy the workflows table", id)
		}
		template, ok := s.GenericTemplateByWorkflow(id)
		if !ok || !template.Workflow.Generic || template.Workflow.ID != id {
			t.Fatalf("generic template %q missing from generic_templates: %+v", id, template)
		}
		if wf, ok := s.Workflow(id); !ok || !wf.Generic {
			t.Fatalf("store Workflow(%q) missed the generic_templates row", id)
		}
	}
	listed := s.Workflows()
	seen := 0
	for _, workflow := range listed {
		if workflow.Generic {
			seen++
		}
	}
	if seen < 3 {
		t.Fatalf("store listed %d generic workflows, want at least 3", seen)
	}
}

func TestUpdateGenericWorkflowGuardsStaleWritesAndKeepsHistory(t *testing.T) {
	s := testStoreWithGenericTemplates(t)
	before, ok := s.GenericWorkflowByID(GenericBackendDeliveryWorkflowID)
	if !ok {
		t.Fatal("backend template missing")
	}
	first := before
	first.Description = "admin A"
	saved, err := s.UpdateGenericWorkflow(first)
	if err != nil {
		t.Fatal(err)
	}
	if saved.Revision != before.Revision+1 {
		t.Fatalf("revision = %d, want %d", saved.Revision, before.Revision+1)
	}
	stale := before
	stale.Description = "admin B"
	if _, err := s.UpdateGenericWorkflow(stale); err == nil || !strings.Contains(err.Error(), "revision conflict") {
		t.Fatalf("stale write error = %v, want revision conflict", err)
	}
	current, _ := s.GenericWorkflowByID(GenericBackendDeliveryWorkflowID)
	if current.Description != "admin A" {
		t.Fatalf("stale write overwrote the saved edit: %q", current.Description)
	}
	revisions := s.Revisions("workflow", GenericBackendDeliveryWorkflowID)
	if len(revisions) == 0 {
		t.Fatal("admin edit left no revision history to roll back to")
	}
}

func TestUpdateGenericAgentStaysInTemplateAndIgnoresProjectCatalog(t *testing.T) {
	s := testStoreWithGenericTemplates(t)
	if err := s.PutProject(domain.Project{ID: "skillhub", Key: "SH", Name: "SkillHub"}); err != nil {
		t.Fatal(err)
	}
	hijack := domain.AgentDefinition{ID: GenericAgentReview, Name: "SkillHub 评审", ProjectID: "skillhub", Version: 9, Prompt: "project copy"}
	if err := s.PutAgent(hijack); err != nil {
		t.Fatal(err)
	}
	template, ok := s.GenericTemplateByWorkflow(GenericBackendDeliveryWorkflowID)
	if !ok {
		t.Fatal("backend template missing")
	}
	var review domain.AgentDefinition
	for _, agent := range template.Agents {
		if agent.ID == GenericAgentReview {
			review = agent
		}
	}
	if review.ID == "" {
		t.Fatal("review role missing from template")
	}
	review.Prompt = "platform review instructions"
	saved, err := s.UpdateGenericAgent(GenericBackendDeliveryWorkflowID, review)
	if err != nil {
		t.Fatal(err)
	}
	if saved.ProjectID != "" || saved.Prompt != "platform review instructions" {
		t.Fatalf("generic agent save leaked a project identity: %+v", saved)
	}
	got, _ := s.GenericAgentByID(GenericAgentReview)
	if got.Prompt != "platform review instructions" {
		t.Fatalf("template role was not updated: %+v", got)
	}
	projectCopy, _ := s.Agent(GenericAgentReview)
	if projectCopy.Prompt != "project copy" || projectCopy.ProjectID != "skillhub" {
		t.Fatalf("project catalog role was overwritten: %+v", projectCopy)
	}
	if _, err := s.UpdateGenericAgent(GenericBackendDeliveryWorkflowID, domain.AgentDefinition{ID: "skillhub-reviewer"}); err == nil {
		t.Fatal("updating a role that is not on the template must fail")
	}
}

func TestUpdateGenericAgentRejectsStaleWrite(t *testing.T) {
	s := testStoreWithGenericTemplates(t)
	base, ok := s.GenericAgentByID(GenericAgentReview)
	if !ok {
		t.Fatal("review role missing")
	}
	first, second := base, base
	first.Description = "先保存的人写的"
	first.Version = base.Version
	saved, err := s.UpdateGenericAgent(GenericBackendDeliveryWorkflowID, first)
	if err != nil {
		t.Fatal(err)
	}
	if saved.Version != base.Version+1 {
		t.Fatalf("version = %d, want %d", saved.Version, base.Version+1)
	}
	second.Description = "后保存的人写的"
	second.Version = base.Version
	if _, err := s.UpdateGenericAgent(GenericBackendDeliveryWorkflowID, second); err == nil {
		t.Fatal("a stale write silently overwrote the other admin's edit")
	}
	got, _ := s.GenericAgentByID(GenericAgentReview)
	if got.Description != "先保存的人写的" {
		t.Fatalf("stored description = %q", got.Description)
	}
}

func TestUpdateGenericAgentAcceptsUnversionedWrite(t *testing.T) {
	s := testStoreWithGenericTemplates(t)
	base, _ := s.GenericAgentByID(GenericAgentReview)
	patch := base
	patch.Version = 0
	patch.Description = "脚本改的"
	saved, err := s.UpdateGenericAgent(GenericBackendDeliveryWorkflowID, patch)
	if err != nil {
		t.Fatal(err)
	}
	if saved.Version != base.Version+1 {
		t.Fatalf("version = %d, want %d", saved.Version, base.Version+1)
	}
}

func TestPublishGenericWorkflow(t *testing.T) {
	s := testStoreWithGenericTemplates(t)
	before, _ := s.GenericWorkflowByID(GenericBackendDeliveryWorkflowID)
	before.Description += " updated"
	if _, err := s.UpdateGenericWorkflow(before); err != nil {
		t.Fatal(err)
	}
	published, err := s.PublishGenericWorkflow(GenericBackendDeliveryWorkflowID)
	if err != nil {
		t.Fatal(err)
	}
	if published.Status != "published" || published.Version != before.Version+1 {
		t.Fatalf("publish = %+v", published)
	}
}