Skip to content

Self-hosted workflows for coding-agent delivery. Orchestrate CodeBuddy, Codex and Claude Code with scripts and human approval gates. Includes Local workflows for coding assistants.

feat(chatbot): remember the chat model and approval mode

roberttwang1667e42a47a3
diff --git a/chatbot/src/App.jsx b/chatbot/src/App.jsx
index cb95eae9..9a70c4b9 100644
--- a/chatbot/src/App.jsx
+++ b/chatbot/src/App.jsx
@@ -75,7 +75,7 @@ import { usePanelPresence } from "./usePanelPresence";
import HomeWelcome from "./HomeWelcome";
import ModelPicker from "./ModelPicker";
import ModelProviderIcon, { hasProviderLogo } from "./ModelProviderIcon";
-import PermissionPicker from "./PermissionPicker";
+import PermissionPicker, { rememberApprovalMode, storedApprovalMode } from "./PermissionPicker";
import { conversationEngine, engineBrand } from "./engines.js";
import { effortOptions } from "./effort.js";
import QuickAccessWizard from "./QuickAccessWizard";
@@ -342,12 +342,16 @@ export default function App() {
[repositorySelections, setRepositorySelections] = useState({}),
[uploading, setUploading] = useState(false),
[runsRefresh, setRunsRefresh] = useState(0),
- [approval, setApproval] = useState("confirm"),
+ [approval, setApprovalState] = useState(storedApprovalMode),
[quickAccessOpen, setQuickAccessOpen] = useState(
() => new URLSearchParams(location.search).get("quickAccess") === "1",
),
[theme, setTheme] = useState(() => readThemePreference(localStorage)),
[environmentVisibility, setEnvironmentVisibility] = useState(() => readJSON(environmentVisibilityKey, {}));
+ function setApproval(value) {
+ setApprovalState(value);
+ rememberApprovalMode(value);
+ }
const environmentPreferenceOwner = String(chat.user?.id || "guest");
const showEnvironmentPicker = environmentVisibility[environmentPreferenceOwner] === true;
function changeEnvironmentVisibility(visible) {
diff --git a/chatbot/src/PermissionPicker.jsx b/chatbot/src/PermissionPicker.jsx
index 087e0dae..0a46edd9 100644
--- a/chatbot/src/PermissionPicker.jsx
+++ b/chatbot/src/PermissionPicker.jsx
@@ -10,6 +10,27 @@ const modes = [
{ id: "auto", icon: "priority-bolt", label: "完全权限", tone: "danger", detail: "工作区文件和命令自动执行;平台及外部操作使用当前账号权限直接执行。" },
];
+// The approval mode is a personal preference: new conversations and reloads
+// keep the last pick instead of going back to "请求批准".
+const APPROVAL_KEY = "loopforge.assistant.approvalMode";
+const knownMode = (value) => modes.some((mode) => mode.id === value);
+export function storedApprovalMode() {
+ try {
+ const value = localStorage.getItem(APPROVAL_KEY);
+ return knownMode(value) ? value : "confirm";
+ } catch {
+ return "confirm";
+ }
+}
+export function rememberApprovalMode(value) {
+ if (!knownMode(value)) return;
+ try {
+ localStorage.setItem(APPROVAL_KEY, value);
+ } catch {
+ // Without storage the pick still applies to this page.
+ }
+}
+
// `glyph` is a rendered brand mark. Options that only set `icon` keep the Harness icon.
export default function PermissionPicker({ value, onSelect, open, onOpenChange, label = "操作确认方式", icon, options = modes }) {
const trigger = useRef(null);
diff --git a/chatbot/src/useChat.js b/chatbot/src/useChat.js
index 3188e4a9..55c9320c 100644
--- a/chatbot/src/useChat.js
+++ b/chatbot/src/useChat.js
@@ -52,6 +52,36 @@ function storedExecutor() {
return "codebuddy";
}
}
+// The chat model is a personal preference like the executor: new
+// conversations and page reloads keep the last pick. Each CLI remembers its
+// own, because model IDs differ between CLIs.
+const MODEL_KEY = "loopforge.assistant.model.";
+function storedModel(executor) {
+ try {
+ return localStorage.getItem(MODEL_KEY + executor) || "";
+ } catch {
+ return "";
+ }
+}
+function rememberModel(executor, id) {
+ if (!id) return;
+ try {
+ localStorage.setItem(MODEL_KEY + executor, id);
+ } catch {
+ // Without storage the pick still applies to this page.
+ }
+}
+const codeBuddyModels = (models) => (models || []).filter((m) => !m.engine || m.engine === "codebuddy");
+const executorModelList = (models, executor) =>
+ executor === "codebuddy" ? codeBuddyModels(models) : engineModels(models, executor);
+// The model a new conversation on executor starts with: the remembered one
+// while list still offers it, else the first listed. Before a CLI's list has
+// loaded the remembered model (or that CLI's own default) holds the place.
+function preferredModel(list, executor) {
+ const remembered = storedModel(executor);
+ if (!list?.length) return remembered || (executor === "codebuddy" ? "" : "default");
+ return list.some((m) => m.id === remembered) ? remembered : list[0].id;
+}
// Mirrors errAssistantSponsoredModel in internal/httpapi/assistant_sponsor.go;
// credentialHint turns it into a "去配置" button.
@@ -96,7 +126,7 @@ export function useChat() {
// the header reveals that conversation's title once it has loaded.
[revealId, setRevealId] = useState(activeId),
[projectId, setProjectId] = useState(initialProject),
- [model, setModel] = useState(""),
+ [model, setModel] = useState(() => storedModel(storedExecutor())),
[effort, setEffort] = useState(""),
[sponsoredModels, setSponsoredModels] = useState([]),
[executor, setExecutorState] = useState(storedExecutor),
@@ -132,8 +162,7 @@ export function useChat() {
applyingRef = useRef(new Set()),
dispatchingRef = useRef(false),
steeringRef = useRef(null),
- selectRef = useRef(null),
- defaultModel = useRef("");
+ selectRef = useRef(null);
currentId.current = activeId;
sessionRef.current = session;
projectRef.current = projectId;
@@ -178,14 +207,12 @@ export function useChat() {
setLive({ answer: "", thinking: "", tools: [] });
setSession(null);
executionMachines.resetMachine();
- // A new conversation starts on the platform default, not on whatever
- // model the previously opened conversation used.
+ // A new conversation starts on the person's remembered model, not on
+ // whatever model the previously opened conversation used.
if (!id) {
const preferred = storedExecutor();
setExecutorState(preferred);
- const next = engineModels(models, preferred);
- if (preferred === "codebuddy") setModel(defaultModel.current || next[0]?.id || "");
- else setModel(next[0]?.id || "default");
+ setModel(preferredModel(executorModelList(models, preferred), preferred));
}
setEffort("");
setSandboxProfileId("");
@@ -219,9 +246,9 @@ export function useChat() {
setProjects(projectRows || []);
setSandboxes(sandboxRows || []);
setModels(catalog.models || []);
- defaultModel.current = catalog.default || "";
setSponsoredModels(sponsoredModelList(catalog));
- setModel(catalog.default);
+ const startExecutor = storedExecutor();
+ setModel(preferredModel(executorModelList(catalog.models, startExecutor), startExecutor));
await refreshSessions();
if (!current) return;
const recovered = connectionError;
@@ -258,8 +285,10 @@ export function useChat() {
// A conversation stays on the CLI that answered it. Replies saved before
// model prefixes keep that CLI on the session executor.
const locked = conversationEngine(stored.messages, models, stored.executor);
- setExecutorState(knownExecutor(locked || stored.executor));
- setModel(stored.model || defaultModel.current || models[0]?.id || "");
+ const storedEngine = knownExecutor(locked || stored.executor);
+ setExecutorState(storedEngine);
+ // A conversation shows the model it runs on.
+ setModel(stored.model || preferredModel(executorModelList(models, storedEngine), storedEngine));
setEffort(stored.effort || "");
setProjectId(stored.projectId || "");
syncProject(stored.projectId || "");
@@ -542,7 +571,7 @@ export function useChat() {
.then((catalog) => {
if (!current) return;
setProviderCatalogs((old) => ({ ...old, [executor]: catalog }));
- setModel((old) => (catalog.models || []).some((m) => m.id === old) ? old : catalog.default || "default");
+ setModel((old) => (catalog.models || []).some((m) => m.id === old) ? old : preferredModel(catalog.models, executor));
})
.catch((e) => current && setError(e.message));
return () => {
@@ -558,10 +587,9 @@ export function useChat() {
localStorage.setItem(EXECUTOR_KEY, id);
} catch {}
setEffort("");
- const next = engineModels(models, id);
- const catalog = id === "codebuddy" ? { default: defaultModel.current } : providerCatalogs[id];
+ const listed = executorModelList(models, id);
setExecutorState(id);
- setModel(next[0]?.id || catalog?.default || (id === "codebuddy" ? defaultModel.current : "default"));
+ setModel(preferredModel(listed.length || id === "codebuddy" ? listed : providerCatalogs[id]?.models, id));
if (locked && locked !== id) open(null);
},
[executor, models, open, providerCatalogs],
@@ -573,10 +601,11 @@ export function useChat() {
return false;
}
setModel(id);
+ rememberModel(executor, id);
setEffort((value) => modelEffort(executorModels.find((m) => m.id === id), value));
return true;
},
- [sponsored, sponsoredModels, executorModels],
+ [sponsored, sponsoredModels, executorModels, executor],
);
// Credential flags are omitted when false, so drop the old ones before
// merging; otherwise a cleared key would still look configured.
@@ -934,7 +963,7 @@ export function useChat() {
);
open(stored.id);
setSession(stored);
- setModel(stored.model || defaultModel.current);
+ setModel(stored.model || preferredModel(executorModels, executor));
setEffort(stored.effort || "");
await refreshSessions();
return stored;
diff --git a/chatbot/tests/app-render.test.jsx b/chatbot/tests/app-render.test.jsx
index 9600276a..9aa30ee7 100644
--- a/chatbot/tests/app-render.test.jsx
+++ b/chatbot/tests/app-render.test.jsx
@@ -91,6 +91,19 @@ describe("App", () => {
Object.assign(chat, previous);
}
});
+ test("keeps the picked approval mode after a reload", async () => {
+ const user = userEvent.setup();
+ const first = render(<App />);
+ await user.click(screen.getByRole("button", { name: "操作确认方式" }));
+ await user.click(screen.getByRole("menuitemradio", { name: "帮我批准" }));
+ expect(screen.getByRole("button", { name: "操作确认方式" })).toHaveTextContent("帮我批准");
+ first.unmount();
+ render(<App />);
+ expect(screen.getByRole("button", { name: "操作确认方式" })).toHaveTextContent("帮我批准");
+ await user.type(screen.getByRole("textbox", { name: /消息|输入/ }), "你好");
+ await user.click(screen.getByRole("button", { name: "发送消息" }));
+ expect(chat.send).toHaveBeenLastCalledWith(expect.objectContaining({ approvalMode: "assisted" }));
+ });
test("does not ask for per-command native approval in a working conversation", () => {
const previous = {...chat};
Object.assign(chat,{activeId:"workspace-chat",busy:true,session:{id:"workspace-chat",runtimeMode:"workspace",messages:[{role:"user",content:"检查目录"}]}});
diff --git a/chatbot/tests/hooks.test.jsx b/chatbot/tests/hooks.test.jsx
index 6f1a5de5..0ce4fc28 100644
--- a/chatbot/tests/hooks.test.jsx
+++ b/chatbot/tests/hooks.test.jsx
@@ -127,6 +127,55 @@ describe("conversation hooks", () => {
}
});
+ test("remembers each CLI's model across new conversations and reloads", async () => {
+ localStorage.removeItem("loopforge.assistant.executor");
+ const original = apiMock.getMockImplementation();
+ apiMock.mockImplementation(async (path, options) => {
+ if (path === "/api/assistant/models")
+ return { default: "default", models: [{ id: "default", name: "CLI 默认模型" }, { id: "claude-opus-5.5", name: "Opus" }] };
+ return original(path, options);
+ });
+ try {
+ const first = renderHook(() => useChat());
+ await waitFor(() => expect(first.result.current.ready).toBe(true));
+ // Nothing remembered yet: the first listed model.
+ expect(first.result.current.model).toBe("default");
+ act(() => { first.result.current.setModel("claude-opus-5.5"); });
+ expect(localStorage.getItem("loopforge.assistant.model.codebuddy")).toBe("claude-opus-5.5");
+ // A new conversation no longer goes back to the default model.
+ act(() => first.result.current.newChat());
+ expect(first.result.current.model).toBe("claude-opus-5.5");
+ await act(() => first.result.current.send({ text: "你好" }));
+ expect(writeMock).toHaveBeenCalledWith(
+ "/api/assistant/generations",
+ expect.objectContaining({ model: "claude-opus-5.5" }),
+ );
+ // Another CLI keeps its own pick and does not overwrite CodeBuddy's.
+ act(() => first.result.current.newChat());
+ act(() => first.result.current.setExecutor("codex"));
+ await waitFor(() => expect(first.result.current.models.map((m) => m.id)).toEqual(["default", "gpt-5"]));
+ act(() => { first.result.current.setModel("gpt-5"); });
+ act(() => first.result.current.setExecutor("codebuddy"));
+ expect(first.result.current.model).toBe("claude-opus-5.5");
+ act(() => first.result.current.setExecutor("codex"));
+ expect(first.result.current.model).toBe("gpt-5");
+ act(() => first.result.current.setExecutor("codebuddy"));
+ first.unmount();
+ // Reloading the home page starts on the remembered model too.
+ history.replaceState({}, "", "/");
+ const reloaded = renderHook(() => useChat());
+ await waitFor(() => expect(reloaded.result.current.ready).toBe(true));
+ expect(reloaded.result.current.model).toBe("claude-opus-5.5");
+ // A remembered model that is no longer offered falls back to the list.
+ localStorage.setItem("loopforge.assistant.model.codebuddy", "retired-model");
+ act(() => reloaded.result.current.newChat());
+ expect(reloaded.result.current.model).toBe("default");
+ } finally {
+ apiMock.mockImplementation(original);
+ localStorage.removeItem("loopforge.assistant.executor");
+ }
+ });
+
test("persists the draft sandbox selection when creating a conversation", async () => {
history.replaceState({}, "", "/?projectId=p1");
const { result } = renderHook(() => useChat());
diff --git a/chatbot/tests/pickers-and-activity.test.jsx b/chatbot/tests/pickers-and-activity.test.jsx
index c33bca66..c6c43960 100644
--- a/chatbot/tests/pickers-and-activity.test.jsx
+++ b/chatbot/tests/pickers-and-activity.test.jsx
@@ -21,7 +21,7 @@ import ActivityTrace from "../src/ActivityTrace.jsx";
import MentionPicker from "../src/MentionPicker.jsx";
import ModelPicker from "../src/ModelPicker.jsx";
import Participants, { Avatar, authorFor, peopleFor } from "../src/Participants.jsx";
-import PermissionPicker from "../src/PermissionPicker.jsx";
+import PermissionPicker, { rememberApprovalMode, storedApprovalMode } from "../src/PermissionPicker.jsx";
import { SidebarSection } from "../src/SidebarPreview.jsx";
describe("pickers and activity", () => {
@@ -81,6 +81,16 @@ describe("pickers and activity", () => {
expect(selectPermission).toHaveBeenCalledWith("auto");
});
+ test("remembers the approval mode and ignores unknown values", () => {
+ expect(storedApprovalMode()).toBe("confirm");
+ rememberApprovalMode("assisted");
+ expect(storedApprovalMode()).toBe("assisted");
+ rememberApprovalMode("bogus");
+ expect(storedApprovalMode()).toBe("assisted");
+ localStorage.setItem("loopforge.assistant.approvalMode", "bogus");
+ expect(storedApprovalMode()).toBe("confirm");
+ });
+
test("expands detailed activity including failures", async () => {
const user = userEvent.setup();
const start = "2026-01-01T00:00:00Z";
diff --git a/internal/httpapi/assistant.go b/internal/httpapi/assistant.go
index d7d04ead..887ee753 100644
--- a/internal/httpapi/assistant.go
+++ b/internal/httpapi/assistant.go
@@ -187,7 +187,7 @@ func (h *assistantHandlers) chat(c *gin.Context) {
catalogEngine, _ := assistantModelEngine(req.Model)
catalog := assistantChatCatalog(c.Request.Context(), user.CodeBuddyInternetEnvironment, nil)
if catalogEngine == assistantEngineCodeBuddy {
- catalog = h.chatCatalog(c.Request.Context(), user)
+ catalog = h.turnCatalog(c.Request.Context(), user, req.Model)
}
req.Model = assistantAllowedUserModel(req.Model, catalog, user)
cliEngine, _ = assistantModelEngine(req.Model)
diff --git a/internal/httpapi/assistant_effort_test.go b/internal/httpapi/assistant_effort_test.go
index 271f2534..c7d33c21 100644
--- a/internal/httpapi/assistant_effort_test.go
+++ b/internal/httpapi/assistant_effort_test.go
@@ -13,6 +13,8 @@ func TestAssistantEffortReachesNativeCLIAndPersists(t *testing.T) {
t.Setenv("AGENTFLOW_ASSISTANT_MODELS", assistantChatDefaultModel)
h, user := workbenchFixture(t)
_, calls := nativeCLIRecorder(t)
+ // calls counts conversation turns; keep model discovery off the fake CLI.
+ stubCLIModelDiscovery(t)
messages := []assistantMessage{{Role: "user", Content: "回答一个简单问题"}}
for _, effort := range []string{"max", "high", ""} {
body, _ := json.Marshal(assistantRequest{SessionID: "effort-native", Model: assistantChatDefaultModel, Effort: effort, Messages: messages})
diff --git a/internal/httpapi/assistant_generation.go b/internal/httpapi/assistant_generation.go
index e29f1fc9..d2c32506 100644
--- a/internal/httpapi/assistant_generation.go
+++ b/internal/httpapi/assistant_generation.go
@@ -95,7 +95,7 @@ func (h *assistantHandlers) startGeneration(c *gin.Context) {
catalogEngine, _ := assistantModelEngine(req.Model)
catalog := assistantChatCatalog(c.Request.Context(), user.CodeBuddyInternetEnvironment, nil)
if catalogEngine == assistantEngineCodeBuddy {
- catalog = h.chatCatalog(c.Request.Context(), user)
+ catalog = h.turnCatalog(c.Request.Context(), user, req.Model)
}
req.Model = assistantAllowedUserModel(req.Model, catalog, user)
cliEngine, _ = assistantModelEngine(req.Model)
diff --git a/internal/httpapi/assistant_sponsor.go b/internal/httpapi/assistant_sponsor.go
index 26b43705..e9e0b30d 100644
--- a/internal/httpapi/assistant_sponsor.go
+++ b/internal/httpapi/assistant_sponsor.go
@@ -76,6 +76,29 @@ func (h *assistantHandlers) chatCatalog(ctx context.Context, user domain.User) a
return restrictAssistantCatalog(assistantChatCatalog(ctx, user.CodeBuddyInternetEnvironment, key.Models), key.Models)
}
+// turnCatalog is chatCatalog for a turn on model. The CodeBuddy model list is
+// cached in memory per instance, so a model picked from another instance's
+// list, or before a restart, would otherwise be replaced by the default
+// without a word. A miss refreshes the list once before deciding.
+func (h *assistantHandlers) turnCatalog(ctx context.Context, user domain.User, model string) assistantModelCatalog {
+ catalog := h.chatCatalog(ctx, user)
+ model = strings.TrimSpace(model)
+ if model == "" || assistantCatalogLists(catalog, model) {
+ return catalog
+ }
+ refreshCLIModels(ctx, user.CodeBuddyInternetEnvironment, user.CodeBuddyAPIKey)
+ return h.chatCatalog(ctx, user)
+}
+
+func assistantCatalogLists(catalog assistantModelCatalog, id string) bool {
+ for _, model := range catalog.Models {
+ if model.ID == id {
+ return true
+ }
+ }
+ return false
+}
+
// restrictAssistantCatalog keeps the allowed models, in the allowed order.
func restrictAssistantCatalog(catalog assistantModelCatalog, allowed []string) assistantModelCatalog {
byID := map[string]assistantModel{}
diff --git a/internal/httpapi/assistant_sponsor_test.go b/internal/httpapi/assistant_sponsor_test.go
index e92b923a..12a4fa21 100644
--- a/internal/httpapi/assistant_sponsor_test.go
+++ b/internal/httpapi/assistant_sponsor_test.go
@@ -304,3 +304,38 @@ func TestAssistantModelsPerExecutor(t *testing.T) {
t.Fatalf("unknown executor: %d %s", rec.Code, rec.Body.String())
}
}
+
+// The model list is cached per instance. A turn on a model this instance has
+// not listed yet (another instance served the picker, or it just restarted)
+// refreshes the list instead of silently running on the default model.
+func TestTurnCatalogRefreshesBeforeFallingBackToTheDefault(t *testing.T) {
+ st, member := sponsorFixture(t)
+ stubCLIModelDiscovery(t)
+ calls := 0
+ discoverCLIModels = func(_ context.Context, _, apiKey string) []string {
+ calls++
+ if apiKey == "own-secret" {
+ return []string{"claude-opus-5.5"}
+ }
+ return nil
+ }
+ if _, err := st.UpdateUserCredentials(member.ID, repo.UserCredentialUpdate{CodeBuddyAPIKey: "own-secret"}); err != nil {
+ t.Fatal(err)
+ }
+ stored, _ := st.User(member.ID)
+ h := &assistantHandlers{deps: &deps{repo: st}}
+ if got := assistantAllowedModel("claude-opus-5.5", h.chatCatalog(context.Background(), stored)); got == "claude-opus-5.5" {
+ t.Fatalf("precondition: a cold cache must not list the model yet")
+ }
+ if got := assistantAllowedModel("claude-opus-5.5", h.turnCatalog(context.Background(), stored, "claude-opus-5.5")); got != "claude-opus-5.5" {
+ t.Fatalf("picked claude-opus-5.5, turn runs on %q", got)
+ }
+ if calls != 1 {
+ t.Fatalf("a missing model must refresh the list once, got %d discoveries", calls)
+ }
+ h.turnCatalog(context.Background(), stored, "claude-opus-5.5")
+ h.turnCatalog(context.Background(), stored, "")
+ if calls != 1 {
+ t.Fatalf("a listed or empty model must not run discovery again, got %d", calls)
+ }
+}