Self-hosted workflows for coding-agent delivery. Orchestrate CodeBuddy, Codex and Claude Code with scripts and human approval gates. Includes Local workflows for coding assistants.
JavaScript agent-orchestrationagentic-workflowai-agentsai-codingclaude-codecode-reviewcodebuddycodexcoding-agentscursordeveloper-toolshuman-on-the-loopllmmcpmulti-agentsdlcself-hostedsopworkflow-automationworkflow-engine
refactor(runeval): extract bumpToolRepeat from BuildFacts (#562)
fx-kurumi2131c5d93242
diff --git a/internal/runeval/facts.go b/internal/runeval/facts.goindex 9a879b91..b74dd5db 100644--- a/internal/runeval/facts.go+++ b/internal/runeval/facts.go@@ -61,25 +61,7 @@ func BuildFacts(run domain.Run, catalog domain.RunEvalCatalog) domain.RunEvalFaccase "verification":verification[ev.NodeID]++case "tool":- name := ev.Name- if ev.Tool != nil && ev.Tool.Name != "" {- name = ev.Tool.Name- }- if name == "" {- name = "tool"- }- key := ev.NodeID + "\x00" + name- item := toolCounts[key]- if item == nil {- item = &domain.RunEvalToolRepeat{NodeID: ev.NodeID, Tool: name}- toolCounts[key] = item- }- if ev.Phase == "" || ev.Phase == "start" || ev.Phase == "finish" {- item.Count++- }- if ev.Error != nil || ev.Phase == "error" || ev.Level == "error" {- item.Failed++- }+ bumpToolRepeat(toolCounts, ev)case "error":text := ev.Messageif ev.Error != nil && ev.Error.Message != "" {@@ -212,6 +194,31 @@ func bumpError(bag map[string]*domain.RunEvalErrorFact, nodeID, text string) {item.Count++}+// bumpToolRepeat accumulates one tool telemetry event into bag, keyed by node+// and tool name. Count grows on phase-less, start and finish events; Failed+// grows on any error signal.+func bumpToolRepeat(bag map[string]*domain.RunEvalToolRepeat, ev domain.TelemetryEvent) {+ name := ev.Name+ if ev.Tool != nil && ev.Tool.Name != "" {+ name = ev.Tool.Name+ }+ if name == "" {+ name = "tool"+ }+ key := ev.NodeID + "\x00" + name+ item := bag[key]+ if item == nil {+ item = &domain.RunEvalToolRepeat{NodeID: ev.NodeID, Tool: name}+ bag[key] = item+ }+ if ev.Phase == "" || ev.Phase == "start" || ev.Phase == "finish" {+ item.Count+++ }+ if ev.Error != nil || ev.Phase == "error" || ev.Level == "error" {+ item.Failed+++ }+}+func rankedTools(bag map[string]*domain.RunEvalToolRepeat) []domain.RunEvalToolRepeat {out := make([]domain.RunEvalToolRepeat, 0, len(bag))for _, item := range bag {diff --git a/internal/runeval/tool_repeat_test.go b/internal/runeval/tool_repeat_test.gonew file mode 100644index 00000000..f6d9e7d3--- /dev/null+++ b/internal/runeval/tool_repeat_test.go@@ -0,0 +1,53 @@+package runeval++import (+ "testing"++ "agentflow/internal/domain"+)++func TestBumpToolRepeatPicksToolName(t *testing.T) {+ bag := map[string]*domain.RunEvalToolRepeat{}+ bumpToolRepeat(bag, domain.TelemetryEvent{NodeID: "n1", Name: "event-name", Tool: &domain.ToolObservation{Name: "Bash"}})+ bumpToolRepeat(bag, domain.TelemetryEvent{NodeID: "n1", Name: "Read", Tool: &domain.ToolObservation{}})+ bumpToolRepeat(bag, domain.TelemetryEvent{NodeID: "n1"})++ for _, name := range []string{"Bash", "Read", "tool"} {+ item := bag["n1\x00"+name]+ if item == nil {+ t.Fatalf("missing entry for %q in %v", name, bag)+ }+ if item.NodeID != "n1" || item.Tool != name || item.Count != 1 || item.Failed != 0 {+ t.Fatalf("entry %q = %+v", name, *item)+ }+ }+ if len(bag) != 3 {+ t.Fatalf("expected 3 entries, got %d", len(bag))+ }+}++func TestBumpToolRepeatCountsPhasesAndFailures(t *testing.T) {+ bag := map[string]*domain.RunEvalToolRepeat{}+ tool := &domain.ToolObservation{Name: "Bash"}+ for _, ev := range []domain.TelemetryEvent{+ {NodeID: "n1", Tool: tool},+ {NodeID: "n1", Tool: tool, Phase: "start"},+ {NodeID: "n1", Tool: tool, Phase: "progress"},+ {NodeID: "n1", Tool: tool, Phase: "finish"},+ {NodeID: "n1", Tool: tool, Phase: "error"},+ {NodeID: "n1", Tool: tool, Phase: "finish", Level: "error"},+ {NodeID: "n1", Tool: tool, Phase: "progress", Error: &domain.ErrorObservation{Message: "boom"}},+ {NodeID: "n2", Tool: tool, Phase: "start"},+ } {+ bumpToolRepeat(bag, ev)+ }++ n1 := bag["n1\x00Bash"]+ if n1 == nil || n1.Count != 4 || n1.Failed != 3 {+ t.Fatalf("n1 entry = %+v, want Count 4 Failed 3", n1)+ }+ n2 := bag["n2\x00Bash"]+ if n2 == nil || n2.NodeID != "n2" || n2.Count != 1 || n2.Failed != 0 {+ t.Fatalf("n2 entry = %+v, want separate entry Count 1 Failed 0", n2)+ }+}