Self-hosted workflows for coding-agent delivery. Orchestrate CodeBuddy, Codex and Claude Code with scripts and human approval gates. Includes Local workflows for coding assistants.
JavaScript agent-orchestrationagentic-workflowai-agentsai-codingclaude-codecode-reviewcodebuddycodexcoding-agentscursordeveloper-toolshuman-on-the-loopllmmcpmulti-agentsdlcself-hostedsopworkflow-automationworkflow-engine
refactor(runeval): use slices.Contains in appendUnique (#416) (#417)
fx-kurumi41cbb0d94ea8
diff --git a/internal/runeval/append_unique_test.go b/internal/runeval/append_unique_test.gonew file mode 100644index 00000000..d7666c17--- /dev/null+++ b/internal/runeval/append_unique_test.go@@ -0,0 +1,30 @@+package runeval++import (+ "slices"+ "testing"+)++func TestAppendUnique(t *testing.T) {+ cases := []struct {+ name string+ list []string+ value string+ want []string+ }{+ {name: "nil list", list: nil, value: "a", want: []string{"a"}},+ {name: "empty list", list: []string{}, value: "a", want: []string{"a"}},+ {name: "already present", list: []string{"a", "b"}, value: "b", want: []string{"a", "b"}},+ {name: "appended at end", list: []string{"a", "b"}, value: "c", want: []string{"a", "b", "c"}},+ {name: "empty value appended once", list: []string{"a"}, value: "", want: []string{"a", ""}},+ {name: "empty value already present", list: []string{"", "a"}, value: "", want: []string{"", "a"}},+ {name: "case sensitive", list: []string{"A"}, value: "a", want: []string{"A", "a"}},+ }+ for _, tc := range cases {+ t.Run(tc.name, func(t *testing.T) {+ if got := appendUnique(tc.list, tc.value); !slices.Equal(got, tc.want) {+ t.Fatalf("appendUnique(%q, %q) = %q, want %q", tc.list, tc.value, got, tc.want)+ }+ })+ }+}diff --git a/internal/runeval/facts.go b/internal/runeval/facts.goindex 133d0d08..9a879b91 100644--- a/internal/runeval/facts.go+++ b/internal/runeval/facts.go@@ -1,6 +1,7 @@package runevalimport (+ "slices""sort""strings""time"@@ -244,10 +245,8 @@ func rankedErrors(bag map[string]*domain.RunEvalErrorFact) []domain.RunEvalError}func appendUnique(list []string, value string) []string {- for _, item := range list {- if item == value {- return list- }+ if slices.Contains(list, value) {+ return list}return append(list, value)}