Skip to content

Self-hosted workflows for coding-agent delivery. Orchestrate CodeBuddy, Codex and Claude Code with scripts and human approval gates. Includes Local workflows for coding assistants.

refactor(runner): share invocation repository fallback via invocationRepositories (#504) (#505)

fx-kurumi4a8107fcd322
diff --git a/internal/runner/daemon.go b/internal/runner/daemon.go
index 279e39d5..b86a9304 100644
--- a/internal/runner/daemon.go
+++ b/internal/runner/daemon.go
@@ -965,14 +965,23 @@ func collectRunnerInvocationArtifacts(workspace string, inv *domain.RunnerInvoca
return artifacts
}
-func invocationRepositoryContexts(inv *domain.RunnerInvocation) []domain.RepositoryContext {
+// invocationRepositories returns the repositories an invocation carries:
+// Repositories when set, otherwise the persisted legacy single Repository.
+func invocationRepositories(inv *domain.RunnerInvocation) []domain.RunnerRepository {
if inv == nil {
return nil
}
- repositories := inv.Repositories
- if len(repositories) == 0 && inv.Repository != nil {
- repositories = []domain.RunnerRepository{*inv.Repository}
+ if len(inv.Repositories) == 0 && inv.Repository != nil {
+ return []domain.RunnerRepository{*inv.Repository}
+ }
+ return inv.Repositories
+}
+
+func invocationRepositoryContexts(inv *domain.RunnerInvocation) []domain.RepositoryContext {
+ if inv == nil {
+ return nil
}
+ repositories := invocationRepositories(inv)
out := make([]domain.RepositoryContext, 0, len(repositories))
for _, repository := range repositories {
out = append(out, domain.RepositoryContext{
@@ -1097,13 +1106,7 @@ func checkoutInvocationRepositories(ctx context.Context, workspace string, inv *
return nil
}
ctx = gitwork.WithSSHKeys(ctx, inv.GitSSHKeys)
- repos := inv.Repositories
- if len(repos) == 0 && inv.Repository != nil {
- if strings.TrimSpace(inv.Repository.CloneURL) == "" {
- return nil
- }
- repos = []domain.RunnerRepository{*inv.Repository}
- }
+ repos := invocationRepositories(inv)
for i := range repos {
repo := repos[i]
if strings.TrimSpace(repo.CloneURL) == "" {
diff --git a/internal/runner/invocation_repositories_test.go b/internal/runner/invocation_repositories_test.go
new file mode 100644
index 00000000..1c3228d8
--- /dev/null
+++ b/internal/runner/invocation_repositories_test.go
@@ -0,0 +1,36 @@
+package runner
+
+import (
+ "context"
+ "testing"
+
+ "agentflow/internal/domain"
+)
+
+func TestInvocationRepositoriesPrefersListAndFallsBackToLegacy(t *testing.T) {
+ if got := invocationRepositories(nil); got != nil {
+ t.Fatalf("nil invocation = %+v", got)
+ }
+ if got := invocationRepositories(&domain.RunnerInvocation{}); len(got) != 0 {
+ t.Fatalf("empty invocation = %+v", got)
+ }
+ legacy := &domain.RunnerInvocation{Repository: &domain.RunnerRepository{RepositoryID: "legacy"}}
+ if got := invocationRepositories(legacy); len(got) != 1 || got[0].RepositoryID != "legacy" {
+ t.Fatalf("legacy fallback = %+v", got)
+ }
+ multi := &domain.RunnerInvocation{
+ Repository: &domain.RunnerRepository{RepositoryID: "legacy"},
+ Repositories: []domain.RunnerRepository{{RepositoryID: "a"}, {RepositoryID: "b"}},
+ }
+ if got := invocationRepositories(multi); len(got) != 2 || got[0].RepositoryID != "a" || got[1].RepositoryID != "b" {
+ t.Fatalf("repositories list = %+v", got)
+ }
+}
+
+func TestCheckoutInvocationRepositoriesSkipsLegacyWithoutCloneURL(t *testing.T) {
+ workspace := t.TempDir()
+ inv := &domain.RunnerInvocation{Repository: &domain.RunnerRepository{RepositoryID: "legacy", CloneURL: " "}}
+ if err := checkoutInvocationRepositories(context.Background(), workspace, inv, "local"); err != nil {
+ t.Fatalf("legacy repository without clone URL should be skipped: %v", err)
+ }
+}