Self-hosted workflows for coding-agent delivery. Orchestrate CodeBuddy, Codex and Claude Code with scripts and human approval gates. Includes Local workflows for coding assistants.
JavaScript agent-orchestrationagentic-workflowai-agentsai-codingclaude-codecode-reviewcodebuddycodexcoding-agentscursordeveloper-toolshuman-on-the-loopllmmcpmulti-agentsdlcself-hostedsopworkflow-automationworkflow-engine
【架构优化】从 linkConversationRequirement 中拆出新需求构造 conversationRequirementIssue (#732)
fx-kurumi51ca43975f10
diff --git a/internal/httpapi/assistant_conversation_issue.go b/internal/httpapi/assistant_conversation_issue.goindex 8af4eb0e..ad4148e0 100644--- a/internal/httpapi/assistant_conversation_issue.go+++ b/internal/httpapi/assistant_conversation_issue.go@@ -86,6 +86,29 @@ func (h *agentToolGateway) linkConversationRequirement(s *AgentToolSession, runif req.Title == "" {return domain.Issue{}, false, nil}+ issue := conversationRequirementIssue(s, run, conv, req)+ if err := h.repo.PutIssue(issue); err != nil {+ return domain.Issue{}, false, err+ }+ if _, err := h.repo.LinkConversationRunIssue(run.ID, issue.ID); err != nil {+ return issue, true, err+ }+ if s.ChatSessionID != "" && s.ChatOwnerID != 0 {+ // A new conversation is saved only when its first turn ends;+ // attributeConversationUsage links it then.+ _, _ = h.repo.LinkAssistantSessionIssue(s.ChatOwnerID, s.ChatSessionID, issue.ID)+ }+ stored, ok := h.repo.Issue(issue.ID)+ if !ok {+ stored = issue+ }+ return stored, true, nil+}++// conversationRequirementIssue builds the requirement a conversation+// workspace creates for req: the default status, source and assignee, the+// run's repositories, and the create operation naming the conversation.+func conversationRequirementIssue(s *AgentToolSession, run domain.Run, conv domain.AssistantSession, req conversationRequirement) domain.Issue {issue := domain.Issue{ID: fmt.Sprintf("issue-%d", time.Now().UnixNano()),ProjectID: s.ProjectID,@@ -116,22 +139,7 @@ func (h *agentToolGateway) linkConversationRequirement(s *AgentToolSession, rundetail = "对话「" + truncateRunes(title, 40) + "」中识别为需求并创建,在对话工作区 " + run.ID + " 直接改代码"}issue.AppendOperation(domain.IssueOperation{Actor: actor, ActorUserID: s.UserID, Action: "create", Detail: detail})- if err := h.repo.PutIssue(issue); err != nil {- return domain.Issue{}, false, err- }- if _, err := h.repo.LinkConversationRunIssue(run.ID, issue.ID); err != nil {- return issue, true, err- }- if s.ChatSessionID != "" && s.ChatOwnerID != 0 {- // A new conversation is saved only when its first turn ends;- // attributeConversationUsage links it then.- _, _ = h.repo.LinkAssistantSessionIssue(s.ChatOwnerID, s.ChatSessionID, issue.ID)- }- stored, ok := h.repo.Issue(issue.ID)- if !ok {- stored = issue- }- return stored, true, nil+ return issue}// recordConversationMRs registers the MRs a conversation workspace submitteddiff --git a/internal/httpapi/assistant_conversation_issue_build_test.go b/internal/httpapi/assistant_conversation_issue_build_test.gonew file mode 100644index 00000000..b4ca338b--- /dev/null+++ b/internal/httpapi/assistant_conversation_issue_build_test.go@@ -0,0 +1,64 @@+package httpapi++import (+ "slices"+ "strings"+ "testing"++ "agentflow/internal/domain"+)++func TestConversationRequirementIssueDefaults(t *testing.T) {+ s := &AgentToolSession{ProjectID: "p", UserID: 7, User: domain.User{LoginName: "alice", ChineseName: " 爱丽丝 "}, ChatSessionID: "chat-1"}+ run := domain.Run{ID: "ws-1", Repositories: []domain.RepositoryContext{{RepositoryID: "repo-web"}, {Name: "no-id"}, {RepositoryID: "repo-api"}}}+ issue := conversationRequirementIssue(s, run, domain.AssistantSession{Title: "修登录页"}, conversationRequirement{Title: "修复登录页文案", Description: "按钮文案错了"})++ if !strings.HasPrefix(issue.ID, "issue-") || issue.ProjectID != "p" || issue.Title != "修复登录页文案" || issue.Description != "按钮文案错了" {+ t.Fatalf("identity fields = %+v", issue)+ }+ if issue.Status != "in_progress" || issue.Priority != "medium" || issue.Kind != "requirement" || issue.Source != "local" || issue.AutomationState != "ignored" {+ t.Fatalf("default fields = %+v", issue)+ }+ if issue.AssigneeUserID != 7 || issue.ConversationSessionID != "chat-1" {+ t.Fatalf("owner fields = %+v", issue)+ }+ if !slices.Equal(issue.RepositoryIDs, []string{"repo-web", "repo-api"}) || issue.RepositoryID != "repo-web" {+ t.Fatalf("repositories = %v / %q", issue.RepositoryIDs, issue.RepositoryID)+ }+ if len(issue.Operations) != 1 {+ t.Fatalf("operations = %+v", issue.Operations)+ }+ op := issue.Operations[0]+ if op.Actor != "爱丽丝" || op.ActorUserID != 7 || op.Action != "create" || op.At.IsZero() {+ t.Fatalf("operation = %+v", op)+ }+ if op.Detail != "对话「修登录页」中识别为需求并创建,在对话工作区 ws-1 直接改代码" {+ t.Fatalf("detail = %q", op.Detail)+ }+}++func TestConversationRequirementIssueFallbacks(t *testing.T) {+ s := &AgentToolSession{ProjectID: "p", UserID: 7, User: domain.User{LoginName: "alice", ChineseName: " "}}+ long := strings.Repeat("长", 250)+ issue := conversationRequirementIssue(s, domain.Run{ID: "ws-2"}, domain.AssistantSession{Title: " "}, conversationRequirement{Title: long})++ if issue.Title != truncateRunes(long, 200) {+ t.Fatalf("title must be truncated to 200 runes, got %d", len([]rune(issue.Title)))+ }+ if issue.RepositoryIDs != nil || issue.RepositoryID != "" {+ t.Fatalf("a run without repositories must not set any: %v / %q", issue.RepositoryIDs, issue.RepositoryID)+ }+ op := issue.Operations[0]+ if op.Actor != "alice" {+ t.Fatalf("actor must fall back to the login name, got %q", op.Actor)+ }+ if op.Detail != "对话中识别为需求并创建,在对话工作区 ws-2 直接改代码" {+ t.Fatalf("detail = %q", op.Detail)+ }++ titled := conversationRequirementIssue(s, domain.Run{ID: "ws-3"}, domain.AssistantSession{Title: strings.Repeat("题", 50)}, conversationRequirement{Title: "t"})+ want := "对话「" + truncateRunes(strings.Repeat("题", 50), 40) + "」中识别为需求并创建,在对话工作区 ws-3 直接改代码"+ if got := titled.Operations[0].Detail; got != want {+ t.Fatalf("detail = %q, want %q", got, want)+ }+}