Skip to content

Self-hosted workflows for coding-agent delivery. Orchestrate CodeBuddy, Codex and Claude Code with scripts and human approval gates. Includes Local workflows for coding assistants.

refactor(domain): split DetectFrontendProject walk into previewDetectSkipDir and frontendFileEvidence (#611)

fx-kurumi54bb632c6d3c
diff --git a/internal/domain/preview_detect.go b/internal/domain/preview_detect.go
index e37d509c..2df2f95f 100644
--- a/internal/domain/preview_detect.go
+++ b/internal/domain/preview_detect.go
@@ -139,12 +139,8 @@ func DetectFrontendProject(root string) (bool, string) {
if rel == "." {
return nil
}
- name := d.Name()
if d.IsDir() {
- if previewDetectSkipDirs[strings.ToLower(name)] {
- return fs.SkipDir
- }
- if strings.Count(filepath.ToSlash(rel), "/") >= maxPreviewDetectDepth {
+ if previewDetectSkipDir(d.Name(), rel) {
return fs.SkipDir
}
return nil
@@ -153,18 +149,9 @@ func DetectFrontendProject(root string) (bool, string) {
if files > maxPreviewDetectFiles {
return fs.SkipAll
}
- lower := strings.ToLower(name)
- if frontendIndexNames[lower] || frontendConfigFiles[lower] {
+ if hit, why := frontendFileEvidence(path, rel, d.Name()); hit {
found = true
- evidence = filepath.ToSlash(rel)
- return fs.SkipAll
- }
- if lower != "package.json" {
- return nil
- }
- if hit, why := packageJSONFrontend(path); hit {
- found = true
- evidence = filepath.ToSlash(rel) + " (" + why + ")"
+ evidence = why
return fs.SkipAll
}
return nil
@@ -175,6 +162,34 @@ func DetectFrontendProject(root string) (bool, string) {
return false, "未发现 Vite/webpack/Next 配置、前端依赖或 index.html"
}
+// previewDetectSkipDir reports whether the directory at rel (relative to the
+// workspace root) should be pruned: well-known dependency/cache/VCS folders,
+// or anything at or beyond maxPreviewDetectDepth.
+func previewDetectSkipDir(name, rel string) bool {
+ if previewDetectSkipDirs[strings.ToLower(name)] {
+ return true
+ }
+ return strings.Count(filepath.ToSlash(rel), "/") >= maxPreviewDetectDepth
+}
+
+// frontendFileEvidence reports whether the file at path (rel relative to the
+// workspace root) marks the workspace as frontend, and the evidence string:
+// an index page or bundler config yields its slash path; a package.json with
+// frontend dependencies or scripts yields "<rel> (<reason>)".
+func frontendFileEvidence(path, rel, name string) (bool, string) {
+ lower := strings.ToLower(name)
+ if frontendIndexNames[lower] || frontendConfigFiles[lower] {
+ return true, filepath.ToSlash(rel)
+ }
+ if lower != "package.json" {
+ return false, ""
+ }
+ if hit, why := packageJSONFrontend(path); hit {
+ return true, filepath.ToSlash(rel) + " (" + why + ")"
+ }
+ return false, ""
+}
+
func packageJSONFrontend(path string) (bool, string) {
raw, err := os.ReadFile(path)
if err != nil {
diff --git a/internal/domain/preview_detect_helpers_test.go b/internal/domain/preview_detect_helpers_test.go
new file mode 100644
index 00000000..9b81279b
--- /dev/null
+++ b/internal/domain/preview_detect_helpers_test.go
@@ -0,0 +1,70 @@
+package domain
+
+import (
+ "os"
+ "path/filepath"
+ "strings"
+ "testing"
+)
+
+func TestPreviewDetectSkipDir(t *testing.T) {
+ t.Parallel()
+
+ deep := strings.Repeat("d/", maxPreviewDetectDepth) + "leaf"
+ shallow := strings.Repeat("d/", maxPreviewDetectDepth-1) + "leaf"
+ cases := []struct {
+ name, rel string
+ want bool
+ }{
+ {"node_modules", "node_modules", true},
+ {"Node_Modules", "web/Node_Modules", true},
+ {".git", ".git", true},
+ {"src", "src", false},
+ {"leaf", shallow, false},
+ {"leaf", deep, true},
+ }
+ for _, tc := range cases {
+ if got := previewDetectSkipDir(tc.name, tc.rel); got != tc.want {
+ t.Errorf("previewDetectSkipDir(%q, %q) = %v, want %v", tc.name, tc.rel, got, tc.want)
+ }
+ }
+}
+
+func TestFrontendFileEvidence(t *testing.T) {
+ t.Parallel()
+
+ dir := t.TempDir()
+ write := func(name, body string) string {
+ t.Helper()
+ path := filepath.Join(dir, name)
+ if err := os.WriteFile(path, []byte(body), 0o644); err != nil {
+ t.Fatal(err)
+ }
+ return path
+ }
+ reactPkg := write("react.json", `{"dependencies":{"react":"18.3.1"}}`)
+ scriptPkg := write("script.json", `{"scripts":{"dev":"VITE_X=1 vite --host"}}`)
+ apiPkg := write("api.json", `{"dependencies":{"express":"^4.19.0"}}`)
+ brokenPkg := write("broken.json", `{not json`)
+
+ cases := []struct {
+ label, path, rel, name string
+ wantHit bool
+ wantEvidence string
+ }{
+ {"index page", "", filepath.Join("dist", "index.html"), "index.html", true, "dist/index.html"},
+ {"index page upper case", "", "INDEX.HTM", "INDEX.HTM", true, "INDEX.HTM"},
+ {"bundler config", "", filepath.Join("web", "vite.config.ts"), "vite.config.ts", true, "web/vite.config.ts"},
+ {"frontend dependency", reactPkg, filepath.Join("app", "package.json"), "package.json", true, "app/package.json (react)"},
+ {"frontend script", scriptPkg, "package.json", "package.json", true, "package.json (scripts:vite)"},
+ {"backend package", apiPkg, "package.json", "package.json", false, ""},
+ {"invalid package", brokenPkg, "package.json", "package.json", false, ""},
+ {"unrelated file", "", "main.go", "main.go", false, ""},
+ }
+ for _, tc := range cases {
+ hit, evidence := frontendFileEvidence(tc.path, tc.rel, tc.name)
+ if hit != tc.wantHit || evidence != tc.wantEvidence {
+ t.Errorf("%s: frontendFileEvidence = (%v, %q), want (%v, %q)", tc.label, hit, evidence, tc.wantHit, tc.wantEvidence)
+ }
+ }
+}