Skip to content

Self-hosted workflows for coding-agent delivery. Orchestrate CodeBuddy, Codex and Claude Code with scripts and human approval gates. Includes Local workflows for coding assistants.

refactor(engine): drop custom max shadowing the builtin (#281)

fx-kurumi62d1eca9915d
diff --git a/internal/engine/core_cases_test.go b/internal/engine/core_cases_test.go
index 97824c64..d0ba8996 100644
--- a/internal/engine/core_cases_test.go
+++ b/internal/engine/core_cases_test.go
@@ -69,9 +69,6 @@ func TestWorkflowGraphValidationAndTraversal(t *testing.T) {
if !hasFailed(valid, run) {
t.Fatal("failure not found")
}
- if max(2, 1) != 2 || max(1, 2) != 2 {
- t.Fatal("max")
- }
cases := []domain.WorkflowDefinition{
{ID: "x", Nodes: valid.Nodes},
diff --git a/internal/engine/workflow_graph.go b/internal/engine/workflow_graph.go
index 2f756334..ed648d3b 100644
--- a/internal/engine/workflow_graph.go
+++ b/internal/engine/workflow_graph.go
@@ -153,13 +153,6 @@ func hasFailed(wf domain.WorkflowDefinition, r domain.Run) bool {
return false
}
-func max(a, b int) int {
- if a > b {
- return a
- }
- return b
-}
-
func validate(wf domain.WorkflowDefinition) error {
if err := domain.ValidateWorkflowPreparation(wf); err != nil {
return err