Skip to content

Self-hosted workflows for coding-agent delivery. Orchestrate CodeBuddy, Codex and Claude Code with scripts and human approval gates. Includes Local workflows for coding assistants.

refactor(runner-cli): extract concurrencyFromEnv and parseLabels from main (#339) (#340)

fx-kurumi641acb1fc6f1
diff --git a/cmd/agentflow-runner/main.go b/cmd/agentflow-runner/main.go
index 76937d6d..ab04d94d 100644
--- a/cmd/agentflow-runner/main.go
+++ b/cmd/agentflow-runner/main.go
@@ -51,18 +51,8 @@ func main() {
ManagedCLIRoot: strings.TrimSpace(os.Getenv("AGENTFLOW_MANAGED_CLI_ROOT")),
DisableRunSandboxReuse: !*reuseSandbox,
}
- if raw := strings.TrimSpace(os.Getenv("AGENTFLOW_RUNNER_CONCURRENCY")); raw != "" {
- if parsed, err := strconv.Atoi(raw); err == nil && parsed > 0 {
- cfg.MaxConcurrency = parsed
- }
- }
- if *labels != "" {
- for _, label := range strings.Split(*labels, ",") {
- if label = strings.TrimSpace(label); label != "" {
- cfg.Labels = append(cfg.Labels, label)
- }
- }
- }
+ cfg.MaxConcurrency = concurrencyFromEnv(cfg.MaxConcurrency)
+ cfg.Labels = parseLabels(*labels)
daemon, err := runner.New(cfg)
if err != nil {
@@ -87,6 +77,29 @@ func main() {
log.Printf("runner stopped")
}
+// concurrencyFromEnv lets AGENTFLOW_RUNNER_CONCURRENCY override the flag value
+// when it holds a positive integer; anything else keeps fallback.
+func concurrencyFromEnv(fallback int) int {
+ if raw := strings.TrimSpace(os.Getenv("AGENTFLOW_RUNNER_CONCURRENCY")); raw != "" {
+ if parsed, err := strconv.Atoi(raw); err == nil && parsed > 0 {
+ return parsed
+ }
+ }
+ return fallback
+}
+
+// parseLabels splits the comma-separated -labels flag, trimming blanks and
+// dropping empty entries. It returns nil when no label remains.
+func parseLabels(raw string) []string {
+ var labels []string
+ for _, label := range strings.Split(raw, ",") {
+ if label = strings.TrimSpace(label); label != "" {
+ labels = append(labels, label)
+ }
+ }
+ return labels
+}
+
func firstNonEmpty(values ...string) string {
for _, v := range values {
if strings.TrimSpace(v) != "" {
diff --git a/cmd/agentflow-runner/main_test.go b/cmd/agentflow-runner/main_test.go
new file mode 100644
index 00000000..6a8e651d
--- /dev/null
+++ b/cmd/agentflow-runner/main_test.go
@@ -0,0 +1,44 @@
+package main
+
+import (
+ "reflect"
+ "testing"
+)
+
+func TestConcurrencyFromEnv(t *testing.T) {
+ cases := []struct {
+ env string
+ want int
+ }{
+ {"", 3},
+ {" ", 3},
+ {"5", 5},
+ {" 7 ", 7},
+ {"0", 3},
+ {"-2", 3},
+ {"abc", 3},
+ }
+ for _, tc := range cases {
+ t.Setenv("AGENTFLOW_RUNNER_CONCURRENCY", tc.env)
+ if got := concurrencyFromEnv(3); got != tc.want {
+ t.Errorf("concurrencyFromEnv(3) with env %q = %d, want %d", tc.env, got, tc.want)
+ }
+ }
+}
+
+func TestParseLabels(t *testing.T) {
+ cases := []struct {
+ raw string
+ want []string
+ }{
+ {"", nil},
+ {" , ,", nil},
+ {"gpu", []string{"gpu"}},
+ {" gpu , linux,,arm64 ", []string{"gpu", "linux", "arm64"}},
+ }
+ for _, tc := range cases {
+ if got := parseLabels(tc.raw); !reflect.DeepEqual(got, tc.want) {
+ t.Errorf("parseLabels(%q) = %#v, want %#v", tc.raw, got, tc.want)
+ }
+ }
+}