Skip to content

Self-hosted workflows for coding-agent delivery. Orchestrate CodeBuddy, Codex and Claude Code with scripts and human approval gates. Includes Local workflows for coding assistants.

feat(market): let market items declare credential authentication (#1072)

jason zhang6c4226fdc712
diff --git a/internal/httpapi/mcp_market.go b/internal/httpapi/mcp_market.go
index 0be40dff..15ad8e9a 100644
--- a/internal/httpapi/mcp_market.go
+++ b/internal/httpapi/mcp_market.go
@@ -33,8 +33,11 @@ type mcpMarketItem struct {
URL string `json:"url"`
Transport string `json:"transport"`
AuthType string `json:"authType"`
- Official bool `json:"official"`
- Aliases []string `json:"aliases,omitempty"`
+ // CredentialKind names the credential bound as the Authorization Bearer
+ // header when AuthType is "credential" (see MCPServerDefinition).
+ CredentialKind string `json:"credentialKind,omitempty"`
+ Official bool `json:"official"`
+ Aliases []string `json:"aliases,omitempty"`
}
type mcpMarketCatalogFile struct {
@@ -100,7 +103,7 @@ func installMarketMCP(st *repo.Store, marketID, projectID string) (domain.MCPSer
server := domain.MCPServerDefinition{
ID: mcpInstallID(item.ID, "project", projectID), MarketID: item.ID, Name: item.Name,
Description: item.Description, IconURL: item.IconURL, Transport: item.Transport,
- URL: item.URL, AuthType: item.AuthType, Scope: "project", ProjectID: projectID,
+ URL: item.URL, AuthType: item.AuthType, CredentialKind: item.CredentialKind, Scope: "project", ProjectID: projectID,
TimeoutSec: 60, UpdatedAt: time.Now().UTC(),
}
if err := st.PutMCPServer(server); err != nil {
diff --git a/internal/httpapi/mcp_market_test.go b/internal/httpapi/mcp_market_test.go
index 15051b74..cdbe6596 100644
--- a/internal/httpapi/mcp_market_test.go
+++ b/internal/httpapi/mcp_market_test.go
@@ -292,3 +292,33 @@ func TestMCPMarketIconsAreLocalAndEmbedded(t *testing.T) {
t.Fatalf("expected local icons, got %d", withIcon)
}
}
+
+func TestMCPMarketInstallCarriesCredentialKind(t *testing.T) {
+ st, err := repo.OpenTest()
+ if err != nil {
+ t.Fatal(err)
+ }
+ t.Cleanup(func() { st.Close() })
+ if err := st.PutProject(domain.Project{ID: "platform", Name: "Platform"}); err != nil {
+ t.Fatal(err)
+ }
+ // Register a credential-authenticated market item (package globals are
+ // the catalog seam); restore the real catalog afterwards.
+ previous := mcpMarketItems
+ mcpMarketItems = append(append([]mcpMarketItem(nil), previous...), mcpMarketItem{
+ ID: "corp-gateway", Name: "Corp Gateway", URL: "https://gateway.internal/mcp",
+ Transport: "http", AuthType: "credential", CredentialKind: "corp-gateway", Official: true,
+ })
+ t.Cleanup(func() { mcpMarketItems = previous })
+
+ server, created, err := installMarketMCP(st, "corp-gateway", "platform")
+ if err != nil || !created {
+ t.Fatalf("installMarketMCP = %v, %v", created, err)
+ }
+ if server.AuthType != "credential" || server.CredentialKind != "corp-gateway" {
+ t.Fatalf("installed server = %+v", server)
+ }
+ if server.Transport != "http" {
+ t.Fatalf("transport = %q", server.Transport)
+ }
+}