Self-hosted workflows for coding-agent delivery. Orchestrate CodeBuddy, Codex and Claude Code with scripts and human approval gates. Includes Local workflows for coding assistants.
JavaScript agent-orchestrationagentic-workflowai-agentsai-codingclaude-codecode-reviewcodebuddycodexcoding-agentscursordeveloper-toolshuman-on-the-loopllmmcpmulti-agentsdlcself-hostedsopworkflow-automationworkflow-engine
refactor(domain): split ApprovalWaitReason helpers (#309) (#310)
fx-kurumi6ea376bcd398
diff --git a/internal/domain/approval_reason.go b/internal/domain/approval_reason.goindex ae6e3e04..f73a082f 100644--- a/internal/domain/approval_reason.go+++ b/internal/domain/approval_reason.go@@ -21,43 +21,9 @@ func ApprovalWaitReason(run Run, nodeID string) string {return ""}node := wf.Nodes[index]- name := func(id string) string {- for _, n := range wf.Nodes {- if n.ID == id {- if strings.TrimSpace(n.Name) != "" {- return "「" + n.Name + "」"- }- return "「" + id + "」"- }- }- return "「" + id + "」"- }- var upstream, downstream []string- for _, edge := range wf.Edges {- if edge.Target == nodeID && edge.Source != "" {- upstream = append(upstream, name(edge.Source))- }- if edge.Source == nodeID && edge.Target != "" {- downstream = append(downstream, name(edge.Target))- }- }- // Workflows without edges run in list order.- if len(wf.Edges) == 0 {- if index > 0 {- upstream = []string{name(wf.Nodes[index-1].ID)}- }- if index+1 < len(wf.Nodes) {- downstream = []string{name(wf.Nodes[index+1].ID)}- }- }+ upstream, downstream := approvalNeighbors(wf, index)var b strings.Builder- sop := strings.TrimSpace(wf.Name)- if sop == "" {- sop = "该 SOP"- } else {- sop = "SOP「" + sop + "」"- }- b.WriteString(sop + "在这一步设置了人工门禁")+ b.WriteString(approvalSOPLabel(wf.Name) + "在这一步设置了人工门禁")if len(upstream) > 0 {b.WriteString(":" + strings.Join(upstream, "、") + "已完成,需要有权限的成员检查结果后确认")} else {@@ -69,7 +35,7 @@ func ApprovalWaitReason(run Run, nodeID string) string {b.WriteString(",确认后运行结束")}if node.RejectTo != "" {- b.WriteString(";不通过可打回到" + name(node.RejectTo) + "重做")+ b.WriteString(";不通过可打回到" + approvalNodeLabel(wf, node.RejectTo) + "重做")}b.WriteString("。")if instructions := strings.TrimSpace(node.TaskPrompt); instructions != "" {@@ -77,3 +43,48 @@ func ApprovalWaitReason(run Run, nodeID string) string {}return b.String()}++// approvalNeighbors returns the labels of the steps feeding into and+// following wf.Nodes[index]. Workflows without edges run in list order.+func approvalNeighbors(wf WorkflowDefinition, index int) (upstream, downstream []string) {+ nodeID := wf.Nodes[index].ID+ for _, edge := range wf.Edges {+ if edge.Target == nodeID && edge.Source != "" {+ upstream = append(upstream, approvalNodeLabel(wf, edge.Source))+ }+ if edge.Source == nodeID && edge.Target != "" {+ downstream = append(downstream, approvalNodeLabel(wf, edge.Target))+ }+ }+ if len(wf.Edges) == 0 {+ if index > 0 {+ upstream = []string{approvalNodeLabel(wf, wf.Nodes[index-1].ID)}+ }+ if index+1 < len(wf.Nodes) {+ downstream = []string{approvalNodeLabel(wf, wf.Nodes[index+1].ID)}+ }+ }+ return upstream, downstream+}++// approvalNodeLabel quotes a node's display name, falling back to its ID when+// the node is unnamed or missing from the snapshot.+func approvalNodeLabel(wf WorkflowDefinition, id string) string {+ for _, n := range wf.Nodes {+ if n.ID == id {+ if strings.TrimSpace(n.Name) != "" {+ return "「" + n.Name + "」"+ }+ break+ }+ }+ return "「" + id + "」"+}++// approvalSOPLabel names the workflow in the reason, or "该 SOP" when unnamed.+func approvalSOPLabel(name string) string {+ if name = strings.TrimSpace(name); name != "" {+ return "SOP「" + name + "」"+ }+ return "该 SOP"+}diff --git a/internal/domain/approval_reason_test.go b/internal/domain/approval_reason_test.goindex 213fd4d6..f2ec6a09 100644--- a/internal/domain/approval_reason_test.go+++ b/internal/domain/approval_reason_test.go@@ -31,3 +31,36 @@ func TestApprovalWaitReason(t *testing.T) {t.Fatal("unknown node must yield empty reason")}}++func TestApprovalWaitReasonFallbacks(t *testing.T) {+ run := Run{WorkflowSnapshot: WorkflowDefinition{+ Nodes: []WorkflowNode{{ID: "gate", Type: "approval"}},+ }}+ want := "该 SOP在这一步设置了人工门禁,需要有权限的成员确认,确认后运行结束。"+ if got := ApprovalWaitReason(run, "gate"); got != want {+ t.Fatalf("got %s\nwant %s", got, want)+ }++ run.WorkflowSnapshot = WorkflowDefinition{+ Name: " ",+ Nodes: []WorkflowNode{{ID: "gate", RejectTo: "ghost"}, {ID: "next", Name: " "}},+ }+ want = "该 SOP在这一步设置了人工门禁,需要有权限的成员确认,确认后继续「next」;不通过可打回到「ghost」重做。"+ if got := ApprovalWaitReason(run, "gate"); got != want {+ t.Fatalf("got %s\nwant %s", got, want)+ }+}++func TestApprovalNeighborsIgnoresEmptyEdgeEnds(t *testing.T) {+ wf := WorkflowDefinition{+ Nodes: []WorkflowNode{{ID: "a", Name: "甲"}, {ID: "gate"}, {ID: "b", Name: "乙"}},+ Edges: []WorkflowEdge{{Source: "", Target: "gate"}, {Source: "gate", Target: ""}, {Source: "a", Target: "gate"}},+ }+ up, down := approvalNeighbors(wf, 1)+ if strings.Join(up, ",") != "「甲」" || len(down) != 0 {+ t.Fatalf("up=%v down=%v", up, down)+ }+ if got := approvalSOPLabel(" 交付 "); got != "SOP「交付」" {+ t.Fatalf("sop label: %s", got)+ }+}