Skip to content

Self-hosted workflows for coding-agent delivery. Orchestrate CodeBuddy, Codex and Claude Code with scripts and human approval gates. Includes Local workflows for coding assistants.

refactor(botinteraction): extract snapshotNode for workflow snapshot lookups (#274)

fx-kurumi73ee73abae1d
diff --git a/internal/botinteraction/cards.go b/internal/botinteraction/cards.go
index 0518230f..09e093df 100644
--- a/internal/botinteraction/cards.go
+++ b/internal/botinteraction/cards.go
@@ -45,18 +45,14 @@ func ActionsForDelivery(store *repo.Store, item domain.NotificationDelivery) []m
if run.Status != "running" {
button("重试", "retry")
}
- for _, n := range run.WorkflowSnapshot.Nodes {
- if n.ID == item.NodeID && n.RejectTo != "" {
- button("退回", "reject")
- }
+ if n, ok := snapshotNode(run, item.NodeID); ok && n.RejectTo != "" {
+ button("退回", "reject")
}
}
case "failed":
button("重试", "retry")
- for _, n := range run.WorkflowSnapshot.Nodes {
- if n.ID == item.NodeID && n.Type == "script" {
- button("手动通过", "pass")
- }
+ if n, ok := snapshotNode(run, item.NodeID); ok && n.Type == "script" {
+ button("手动通过", "pass")
}
default:
return nil
@@ -317,19 +313,24 @@ func notificationCardActions(actions []map[string]any) ([]map[string]any, map[st
return buttons, nil
}
func cardReworkTarget(run domain.Run, nodeID string) string {
- target := ""
- for _, node := range run.WorkflowSnapshot.Nodes {
- if node.ID == nodeID {
- target = node.RejectTo
- break
- }
+ node, ok := snapshotNode(run, nodeID)
+ if !ok || node.RejectTo == "" {
+ return ""
}
- if target != "" {
- for _, node := range run.WorkflowSnapshot.Nodes {
- if node.ID == target {
- return node.Name
- }
- }
+ if target, ok := snapshotNode(run, node.RejectTo); ok {
+ return target.Name
}
return ""
}
+
+// snapshotNode returns the definition of node id frozen in the run's workflow
+// snapshot. Node IDs are unique per workflow (enforced on save), so the first
+// match is the only one.
+func snapshotNode(run domain.Run, id string) (domain.WorkflowNode, bool) {
+ for _, node := range run.WorkflowSnapshot.Nodes {
+ if node.ID == id {
+ return node, true
+ }
+ }
+ return domain.WorkflowNode{}, false
+}
diff --git a/internal/botinteraction/snapshot_node_test.go b/internal/botinteraction/snapshot_node_test.go
new file mode 100644
index 00000000..3356c265
--- /dev/null
+++ b/internal/botinteraction/snapshot_node_test.go
@@ -0,0 +1,80 @@
+package botinteraction
+
+import (
+ "testing"
+ "time"
+
+ "agentflow/internal/domain"
+ "agentflow/internal/repo"
+)
+
+func TestSnapshotNode(t *testing.T) {
+ run := domain.Run{WorkflowSnapshot: domain.WorkflowDefinition{Nodes: []domain.WorkflowNode{
+ {ID: "a", Name: "A"}, {ID: "b", Name: "B", Type: "script"},
+ }}}
+ if node, ok := snapshotNode(run, "b"); !ok || node.Name != "B" || node.Type != "script" {
+ t.Fatalf("snapshotNode(b) = %#v, %v", node, ok)
+ }
+ if node, ok := snapshotNode(run, "missing"); ok || node.ID != "" {
+ t.Fatalf("snapshotNode(missing) = %#v, %v", node, ok)
+ }
+ if _, ok := snapshotNode(domain.Run{}, "a"); ok {
+ t.Fatal("empty snapshot must not match")
+ }
+}
+
+func TestCardReworkTargetMissing(t *testing.T) {
+ run := domain.Run{WorkflowSnapshot: domain.WorkflowDefinition{Nodes: []domain.WorkflowNode{
+ {ID: "review", RejectTo: "gone"}, {ID: "plain"}, {ID: "fix", Name: "修复"},
+ }}}
+ for _, id := range []string{"review", "plain", "unknown"} {
+ if got := cardReworkTarget(run, id); got != "" {
+ t.Fatalf("cardReworkTarget(%s) = %q, want empty", id, got)
+ }
+ }
+}
+
+func TestActionsForDeliverySnapshotButtons(t *testing.T) {
+ st, err := repo.OpenTest()
+ if err != nil {
+ t.Fatal(err)
+ }
+ t.Cleanup(st.Close)
+ keys := func(actions []map[string]any) map[string]bool {
+ out := map[string]bool{}
+ for _, a := range actions {
+ out[a["key"].(string)] = true
+ }
+ return out
+ }
+ cases := []struct {
+ name string
+ def domain.WorkflowNode
+ status string
+ event string
+ key string
+ present bool
+ }{
+ {"reject shown", domain.WorkflowNode{ID: "n", RejectTo: "fix"}, "waiting_approval", "waiting", "reject", true},
+ {"reject hidden", domain.WorkflowNode{ID: "n"}, "waiting_approval", "waiting", "reject", false},
+ {"reject other node", domain.WorkflowNode{ID: "other", RejectTo: "fix"}, "waiting_approval", "waiting", "reject", false},
+ {"pass shown", domain.WorkflowNode{ID: "n", Type: "script"}, "failed", "failed", "pass", true},
+ {"pass hidden", domain.WorkflowNode{ID: "n", Type: "agent"}, "failed", "failed", "pass", false},
+ {"pass other node", domain.WorkflowNode{ID: "other", Type: "script"}, "failed", "failed", "pass", false},
+ }
+ for i, tc := range cases {
+ run := domain.Run{
+ ID: "snapshot-buttons-" + string(rune('a'+i)), Status: "waiting",
+ WorkflowSnapshot: domain.WorkflowDefinition{Nodes: []domain.WorkflowNode{tc.def}},
+ Nodes: map[string]*domain.NodeRun{"n": {NodeID: "n", Status: tc.status}},
+ CreatedAt: time.Now(),
+ }
+ if err := st.PutRun(run); err != nil {
+ t.Fatal(err)
+ }
+ actions := ActionsForDelivery(st, domain.NotificationDelivery{RunID: run.ID, NodeID: "n", EventType: tc.event})
+ if got := keys(actions)[tc.key]; got != tc.present {
+ t.Fatalf("%s: %s present = %v, actions = %#v", tc.name, tc.key, got, actions)
+ }
+ }
+}