Self-hosted workflows for coding-agent delivery. Orchestrate CodeBuddy, Codex and Claude Code with scripts and human approval gates. Includes Local workflows for coding assistants.
JavaScript agent-orchestrationagentic-workflowai-agentsai-codingclaude-codecode-reviewcodebuddycodexcoding-agentscursordeveloper-toolshuman-on-the-loopllmmcpmulti-agentsdlcself-hostedsopworkflow-automationworkflow-engine
refactor(domain): use slices.Contains in IsAgentCLIKind and ValidateAgentEffort (#356)
fx-kurumi8e03e08418d0
diff --git a/internal/domain/agent.go b/internal/domain/agent.goindex e5175425..5e98e7ea 100644--- a/internal/domain/agent.go+++ b/internal/domain/agent.go@@ -2,6 +2,7 @@ package domainimport ("errors"+ "slices""strings""time")@@ -25,12 +26,9 @@ var AgentCLIExecutorKinds = []string{"opencode", "cursor", "agy", "kimi", "pi",func IsAgentCLIKind(kind string) bool {kind = strings.TrimSpace(kind)- for _, k := range AgentCLIExecutorKinds {- if strings.EqualFold(k, kind) {- return true- }- }- return false+ return slices.ContainsFunc(AgentCLIExecutorKinds, func(k string) bool {+ return strings.EqualFold(k, kind)+ })}// ValidateAgentEffort checks a role's reasoning-effort choice against the@@ -44,10 +42,8 @@ func ValidateAgentEffort(effort, executorKind string) error {if !ok {return errors.New("当前 CLI 不支持设置思考强度")}- for _, level := range levels {- if level == effort {- return nil- }+ if slices.Contains(levels, effort) {+ return nil}return errors.New("思考强度取值不被当前 CLI 支持")}diff --git a/internal/domain/agent_kind_effort_test.go b/internal/domain/agent_kind_effort_test.gonew file mode 100644index 00000000..f9f75b8f--- /dev/null+++ b/internal/domain/agent_kind_effort_test.go@@ -0,0 +1,51 @@+package domain++import "testing"++func TestIsAgentCLIKindMatchesCaseInsensitivelyAfterTrim(t *testing.T) {+ cases := map[string]bool{+ "opencode": true,+ " Cursor ": true,+ "ZCODE": true,+ "pi": true,+ "codex": false,+ "claude-code": false,+ "codebuddy": false,+ "": false,+ "open code": false,+ }+ for kind, want := range cases {+ if got := IsAgentCLIKind(kind); got != want {+ t.Errorf("IsAgentCLIKind(%q) = %v, want %v", kind, got, want)+ }+ }+}++func TestValidateAgentEffortChecksPublishedLevels(t *testing.T) {+ cases := []struct {+ effort, kind, wantErr string+ }{+ {effort: "", kind: "unknown"},+ {effort: " ", kind: "codex"},+ {effort: "ultra", kind: "codex"},+ {effort: " max ", kind: "claude-code"},+ {effort: "minimal", kind: " pi "},+ {effort: "high", kind: "kimi", wantErr: "当前 CLI 不支持设置思考强度"},+ {effort: "high", kind: "unknown", wantErr: "当前 CLI 不支持设置思考强度"},+ {effort: "ultracode", kind: "codex", wantErr: "思考强度取值不被当前 CLI 支持"},+ {effort: "HIGH", kind: "codex", wantErr: "思考强度取值不被当前 CLI 支持"},+ {effort: "xhigh", kind: "opencode", wantErr: "思考强度取值不被当前 CLI 支持"},+ }+ for _, tc := range cases {+ err := ValidateAgentEffort(tc.effort, tc.kind)+ if tc.wantErr == "" {+ if err != nil {+ t.Errorf("ValidateAgentEffort(%q, %q) = %v, want nil", tc.effort, tc.kind, err)+ }+ continue+ }+ if err == nil || err.Error() != tc.wantErr {+ t.Errorf("ValidateAgentEffort(%q, %q) = %v, want %q", tc.effort, tc.kind, err, tc.wantErr)+ }+ }+}