Skip to content

Self-hosted workflows for coding-agent delivery. Orchestrate CodeBuddy, Codex and Claude Code with scripts and human approval gates. Includes Local workflows for coding assistants.

fix(schedule): drop the length limit on scheduled task prompts (#212)

crispinhu279d832c770710
diff --git a/docs/api/shared-schedules.md b/docs/api/shared-schedules.md
index 2e78e661..74c5ea2a 100644
--- a/docs/api/shared-schedules.md
+++ b/docs/api/shared-schedules.md
@@ -9,7 +9,7 @@
- 升级沿用保存接口,显式修改 `sharedTaskVersion`。参数按新版定义重新校验;没有隐式升级。运行中的任务仍使用启动时的版本,之后运行使用保存后的版本。
- 新订阅读取、保存、运行和删除按目标项目权限校验;执行使用目标项目 Owner 的凭据。发布者不能通过共享定义取得订阅项目写权限。
-参数结构:`{name,label,type,required,default}`,type 为 string/integer/number/boolean;值均为字符串。提示词使用 `{{params.days}}`。最多 20 个参数,名称唯一;未定义、未知、缺失必填或类型错误返回 400。默认值只用于未提交的字段;显式空值不能绕过必填校验。替换后提示词最多 4000 字节,替换单次完成,参数中的模板表达式保持原文。
+参数结构:`{name,label,type,required,default}`,type 为 string/integer/number/boolean;值均为字符串。提示词使用 `{{params.days}}`。最多 20 个参数,名称唯一;未定义、未知、缺失必填或类型错误返回 400。默认值只用于未提交的字段;显式空值不能绕过必填校验。提示词本身不限长度,替换单次完成,参数中的模板表达式保持原文。
```json
{"name":"需求停滞巡检","prompt":"检查超过 {{params.days}} 天未更新的需求,汇总实际结果。","parameters":[{"name":"days","label":"停滞天数","type":"integer","required":true,"default":"3"}],"baseVersion":0,"changeNote":"首次发布"}
diff --git a/internal/domain/shared_schedule.go b/internal/domain/shared_schedule.go
index 57b7ef65..5aa6cb05 100644
--- a/internal/domain/shared_schedule.go
+++ b/internal/domain/shared_schedule.go
@@ -39,8 +39,8 @@ var scheduleParameterName = regexp.MustCompile(`^[a-zA-Z][a-zA-Z0-9_]{0,31}$`)
var scheduleParameterToken = regexp.MustCompile(`\{\{\s*params\.([^{}]+?)\s*\}\}`)
func (v SharedScheduleVersion) Validate() error {
- if strings.TrimSpace(v.Name) == "" || len(v.Name) > 255 || strings.TrimSpace(v.Prompt) == "" || len(v.Prompt) > 4000 {
- return fmt.Errorf("共享名称和提示词必填,名称最多 255 字节,提示词最多 4000 字节")
+ if strings.TrimSpace(v.Name) == "" || len(v.Name) > 255 || strings.TrimSpace(v.Prompt) == "" {
+ return fmt.Errorf("共享名称和提示词必填,名称最多 255 字节")
}
if len(v.Description) > 2000 || len(v.ChangeNote) > 1000 || len(v.Parameters) > 20 {
return fmt.Errorf("描述、版本说明或参数数量超出限制")
@@ -125,8 +125,5 @@ func (v SharedScheduleVersion) Render(input map[string]string) (string, map[stri
prompt := scheduleParameterToken.ReplaceAllStringFunc(v.Prompt, func(token string) string {
return values[strings.TrimSpace(scheduleParameterToken.FindStringSubmatch(token)[1])]
})
- if len(prompt) > 4000 {
- return "", nil, fmt.Errorf("参数替换后的提示词超过 4000 字节")
- }
return prompt, values, nil
}
diff --git a/internal/domain/shared_schedule_test.go b/internal/domain/shared_schedule_test.go
index 3aec1958..7a09f411 100644
--- a/internal/domain/shared_schedule_test.go
+++ b/internal/domain/shared_schedule_test.go
@@ -54,8 +54,31 @@ func TestSharedScheduleParameters(t *testing.T) {
}
}
long := v
- long.Prompt = strings.Repeat("{{params.team}}", 10)
- if _, _, err := long.Render(map[string]string{"team": strings.Repeat("x", 500)}); err == nil {
- t.Fatal("expanded prompt limit not enforced")
+ long.Prompt = strings.Repeat("{{params.team}}", 10) + strings.Repeat("说明", 2000)
+ got, _, err := long.Render(map[string]string{"team": strings.Repeat("x", 500)})
+ want := strings.Repeat(strings.Repeat("x", 500), 10) + strings.Repeat("说明", 2000)
+ if err != nil || got != want {
+ t.Fatalf("long prompt rejected: %v len=%d", err, len(got))
+ }
+}
+
+// Prompts no longer have a length cap, but the name and blank checks remain.
+func TestSharedScheduleVersionValidatePromptLength(t *testing.T) {
+ long := SharedScheduleVersion{Name: "巡检", Prompt: strings.Repeat("提示", 5000)}
+ if err := long.Validate(); err != nil {
+ t.Fatalf("long prompt rejected: %v", err)
+ }
+ for name, v := range map[string]SharedScheduleVersion{
+ "blank prompt": {Name: "巡检", Prompt: " \n\t "},
+ "empty prompt": {Name: "巡检"},
+ "blank name": {Name: " ", Prompt: "p"},
+ "long name": {Name: strings.Repeat("n", 256), Prompt: strings.Repeat("p", 5000)},
+ } {
+ if v.Validate() == nil {
+ t.Errorf("%s accepted", name)
+ }
+ }
+ if err := (SharedScheduleVersion{Name: strings.Repeat("n", 255), Prompt: "p"}).Validate(); err != nil {
+ t.Fatalf("255-byte name rejected: %v", err)
}
}
diff --git a/internal/httpapi/assistant_cases_test.go b/internal/httpapi/assistant_cases_test.go
index 169386cb..fa6c625d 100644
--- a/internal/httpapi/assistant_cases_test.go
+++ b/internal/httpapi/assistant_cases_test.go
@@ -44,10 +44,14 @@ func TestAssistantTaskValidationPersistenceAndDue(t *testing.T) {
if err != nil || got.ID == "" || got.LastStatus != "idle" || got.CreatedAt.IsZero() {
t.Fatalf("normalize new = %+v, %v", got, err)
}
+ longPrompt := strings.Repeat("p", 8000)
+ long, err := normalizeAssistantTask(assistantTask{Name: "n", Prompt: longPrompt, ProjectID: "p", IntervalSec: 60}, assistantTask{})
+ if err != nil || long.Prompt != longPrompt {
+ t.Fatalf("long prompt rejected: %+v %v", long, err)
+ }
for _, tc := range []assistantTask{
{Prompt: "p", ProjectID: "p", IntervalSec: 60},
{Name: strings.Repeat("名", 81), Prompt: "p", ProjectID: "p", IntervalSec: 60},
- {Name: "n", Prompt: strings.Repeat("p", 4001), ProjectID: "p", IntervalSec: 60},
{Name: "n", Prompt: "p", ProjectID: "p", IntervalSec: 59},
{Name: "n", Prompt: "p", ProjectID: "p", IntervalSec: assistantTaskMaxInterval + 1},
{Name: "n", Prompt: "p", ProjectID: "p", Cron: "bad cron"},
diff --git a/internal/httpapi/assistant_tasks.go b/internal/httpapi/assistant_tasks.go
index 57efff12..f69c8f7c 100644
--- a/internal/httpapi/assistant_tasks.go
+++ b/internal/httpapi/assistant_tasks.go
@@ -349,9 +349,6 @@ func normalizeAssistantTask(in assistantTask, existing assistantTask) (assistant
if len([]rune(in.Name)) > 80 {
return in, errors.New("任务名称过长")
}
- if len(in.Prompt) > 4000 {
- return in, errors.New("任务指令过长")
- }
if in.Cron != "" {
if _, err := parseAssistantCron(in.Cron); err != nil {
return in, errors.New("Cron 表达式无效,需为 5 段(分 时 日 月 周,东八区),例如 0 * * * *")
diff --git a/internal/httpapi/misc_cases_test.go b/internal/httpapi/misc_cases_test.go
index e51726ec..64b93538 100644
--- a/internal/httpapi/misc_cases_test.go
+++ b/internal/httpapi/misc_cases_test.go
@@ -60,11 +60,22 @@ func TestMiscScheduleRemainingHelpersAndHTTP(t *testing.T) {
t.Fatal(err)
}
+ longPrompt := strings.Repeat("x", 8000)
+ longRec := cvBRequest(t, f, http.MethodPost, "/api/schedule-jobs", map[string]any{
+ "name": "long", "skipDispatch": true, "assistantPrompt": longPrompt,
+ }, true)
+ if longRec.Code != http.StatusOK {
+ t.Fatalf("long prompt = %d: %s", longRec.Code, longRec.Body.String())
+ }
+ var longJob domain.ScheduleJob
+ if err := json.Unmarshal(longRec.Body.Bytes(), &longJob); err != nil || longJob.AssistantPrompt != longPrompt {
+ t.Fatalf("long prompt not stored: %v %s", err, longRec.Body.String())
+ }
+
for i, tc := range []struct {
body any
want int
}{
- {map[string]any{"name": "long", "skipDispatch": true, "assistantPrompt": strings.Repeat("x", 4001)}, http.StatusBadRequest},
{map[string]any{"id": "cvb-misc-job", "name": "job", "projectId": "cvb-misc-project", "workflowId": "cvb-misc-wf", "intervalSec": 1}, http.StatusOK},
} {
rec := cvBRequest(t, f, http.MethodPost, "/api/schedule-jobs", tc.body, true)
diff --git a/internal/httpapi/schedule.go b/internal/httpapi/schedule.go
index 3c1e2f70..e87042d5 100644
--- a/internal/httpapi/schedule.go
+++ b/internal/httpapi/schedule.go
@@ -97,10 +97,6 @@ func (h *scheduleHandlers) scheduleJobs(c *gin.Context) {
job.IssueStatuses = append([]string{}, domain.DefaultScheduleIssueStatuses...)
}
}
- if len(job.AssistantPrompt) > 4000 {
- c.JSON(400, map[string]string{"error": "assistantPrompt is too long"})
- return
- }
if job.WorkflowID != "" {
if _, ok := h.repo.Workflow(job.WorkflowID); !ok {
c.JSON(400, map[string]string{"error": "workflow not found"})
diff --git a/web/index.html b/web/index.html
index 4d37d7c3..892bb9ff 100644
--- a/web/index.html
+++ b/web/index.html
@@ -1167,7 +1167,7 @@
</div>
<div data-schedule-kind="assistant" data-schedule-prompt hidden>
<label>提示词</label>
- <textarea name="assistantPrompt" class="input" rows="4" maxlength="4000" placeholder="到点后助手要做的事,原文执行。例如:给能确定仓库的 backlog 绑仓库;没把握的标 ignored。"></textarea>
+ <textarea name="assistantPrompt" class="input" rows="4" placeholder="到点后助手要做的事,原文执行。例如:给能确定仓库的 backlog 绑仓库;没把握的标 ignored。"></textarea>
<p class="schedule-field-hint">到点以与主页 AI 对话相同的完全权限执行提示词,可按需读写平台、启动 SOP、操作工作区及浏览器。</p>
</div>
</div>
@@ -1187,7 +1187,7 @@
<input name="sourceJobId" type="hidden"><input name="sourceProjectId" type="hidden"><input name="baseVersion" type="hidden">
<label>共享名称<input class="input" name="name" required maxlength="255"></label>
<label>用途说明<textarea class="input" name="description" rows="2" maxlength="2000"></textarea></label>
- <label>提示词模板<textarea class="input" name="prompt" required rows="6" maxlength="4000"></textarea></label>
+ <label>提示词模板<textarea class="input" name="prompt" required rows="6"></textarea></label>
<p class="schedule-field-hint">用 {{params.days}} 引用下方参数,例如“检查超过 {{params.days}} 天未更新的需求”。发布内容对平台登录用户可见。</p>
<div class="shared-schedule-section-head"><b>业务参数</b><button id="sharedScheduleAddParameter" type="button" class="button ghost small">添加参数</button></div>
<div id="sharedScheduleParameterRows" class="shared-schedule-parameter-rows"></div>