Self-hosted workflows for coding-agent delivery. Orchestrate CodeBuddy, Codex and Claude Code with scripts and human approval gates. Includes Local workflows for coding assistants.
JavaScript agent-orchestrationagentic-workflowai-agentsai-codingclaude-codecode-reviewcodebuddycodexcoding-agentscursordeveloper-toolshuman-on-the-loopllmmcpmulti-agentsdlcself-hostedsopworkflow-automationworkflow-engine
refactor(managedcli): split candidate into metadata fetch and mature version selection (#330)
fx-kurumid2e870dfa2c4
diff --git a/internal/managedcli/registry.go b/internal/managedcli/registry.goindex baa4f462..c9184606 100644--- a/internal/managedcli/registry.go+++ b/internal/managedcli/registry.go@@ -32,44 +32,77 @@ type packageMetadata struct {func (m *Manager) candidate(ctx context.Context, provider string) (release, error) {spec := providerSpecs[provider]- endpoint := npmRegistry + "/" + url.PathEscape(spec.Package)- request, err := http.NewRequestWithContext(ctx, http.MethodGet, endpoint, nil)+ metadata, err := m.fetchPackageMetadata(ctx, spec.Package)if err != nil {return release{}, err}+ version := metadata.Tags["latest"]+ if metadata.Name != spec.Package || !releaseVersion.MatchString(version) {+ return release{}, errors.New("registry did not provide the expected package and a stable release version")+ }+ if mature := matureVersion(metadata, version, m.Now().Add(-observationWindow)); mature != "" {+ version = mature+ }+ candidate, ok := metadata.Versions[version]+ if !ok || candidate.Name != spec.Package || candidate.Version != version {+ return release{}, errors.New("release missing or inconsistent in registry metadata")+ }+ if candidate.Deprecated != "" {+ return release{}, errors.New("candidate release is deprecated")+ }+ if !validIntegrity(candidate.Dist.Integrity) {+ return release{}, errors.New("candidate requires a valid SHA512 package integrity value")+ }+ if err := json.Unmarshal(metadata.Times[version], &candidate.Published); err != nil || candidate.Published.IsZero() {+ return release{}, errors.New("candidate release has no valid publication time")+ }+ return candidate, nil+}++// fetchPackageMetadata downloads and decodes the full npm registry document+// for pkg.+func (m *Manager) fetchPackageMetadata(ctx context.Context, pkg string) (packageMetadata, error) {+ endpoint := npmRegistry + "/" + url.PathEscape(pkg)+ request, err := http.NewRequestWithContext(ctx, http.MethodGet, endpoint, nil)+ if err != nil {+ return packageMetadata{}, err+ }// The full metadata includes publish times; abbreviated install metadata// does not, and would silently defeat the observation window.request.Header.Set("Accept", "application/json")response, err := m.Client.Do(request)if err != nil {- return release{}, fmt.Errorf("fetch package metadata: %w", err)+ return packageMetadata{}, fmt.Errorf("fetch package metadata: %w", err)}defer response.Body.Close()if response.StatusCode != http.StatusOK {- return release{}, fmt.Errorf("package metadata HTTP %d", response.StatusCode)+ return packageMetadata{}, fmt.Errorf("package metadata HTTP %d", response.StatusCode)}const limit = 64 << 20data, err := io.ReadAll(io.LimitReader(response.Body, limit+1))if err != nil {- return release{}, err+ return packageMetadata{}, err}if len(data) > limit {- return release{}, errors.New("package metadata exceeds size limit")+ return packageMetadata{}, errors.New("package metadata exceeds size limit")}var metadata packageMetadataif err := json.Unmarshal(data, &metadata); err != nil {- return release{}, fmt.Errorf("invalid package metadata: %w", err)- }- version := metadata.Tags["latest"]- if metadata.Name != spec.Package || !releaseVersion.MatchString(version) {- return release{}, errors.New("registry did not provide the expected package and a stable release version")+ return packageMetadata{}, fmt.Errorf("invalid package metadata: %w", err)}- // Fast-moving CLIs may publish several times a day. Merely rejecting- // an immature latest tag would then postpone updates forever. Select- // the newest mature stable release, bounded by the official latest- // tag so versions published only to another channel cannot leak in.- upper, mature := version, ""- cutoff := m.Now().Add(-observationWindow)+ return metadata, nil+}++// matureVersion returns the newest stable, non-deprecated release no newer+// than upper that was published before cutoff, or "" when none qualifies.+//+// Fast-moving CLIs may publish several times a day. Merely rejecting an+// immature latest tag would then postpone updates forever. Selecting the+// newest mature stable release, bounded by the official latest tag, keeps+// updates flowing while versions published only to another channel cannot+// leak in.+func matureVersion(metadata packageMetadata, upper string, cutoff time.Time) string {+ mature := ""for v, entry := range metadata.Versions {if !releaseVersion.MatchString(v) || compareVersions(v, upper) > 0 || entry.Deprecated != "" {continue@@ -82,23 +115,7 @@ func (m *Manager) candidate(ctx context.Context, provider string) (release, erromature = v}}- if mature != "" {- version = mature- }- candidate, ok := metadata.Versions[version]- if !ok || candidate.Name != spec.Package || candidate.Version != version {- return release{}, errors.New("release missing or inconsistent in registry metadata")- }- if candidate.Deprecated != "" {- return release{}, errors.New("candidate release is deprecated")- }- if !validIntegrity(candidate.Dist.Integrity) {- return release{}, errors.New("candidate requires a valid SHA512 package integrity value")- }- if err := json.Unmarshal(metadata.Times[version], &candidate.Published); err != nil || candidate.Published.IsZero() {- return release{}, errors.New("candidate release has no valid publication time")- }- return candidate, nil+ return mature}func validIntegrity(value string) bool {diff --git a/internal/managedcli/registry_mature_test.go b/internal/managedcli/registry_mature_test.gonew file mode 100644index 00000000..89848ebb--- /dev/null+++ b/internal/managedcli/registry_mature_test.go@@ -0,0 +1,56 @@+package managedcli++import (+ "encoding/json"+ "testing"+ "time"+)++func TestMatureVersionSelectsNewestEligibleRelease(t *testing.T) {+ now := time.Date(2026, 1, 1, 0, 0, 0, 0, time.UTC)+ cutoff := now.Add(-observationWindow)+ build := func(entries map[string]time.Duration, deprecated ...string) packageMetadata {+ metadata := packageMetadata{Versions: map[string]release{}, Times: map[string]json.RawMessage{}}+ for version, age := range entries {+ metadata.Versions[version] = release{Version: version}+ metadata.Times[version], _ = json.Marshal(now.Add(-age))+ }+ for _, version := range deprecated {+ entry := metadata.Versions[version]+ entry.Deprecated = "do not use"+ metadata.Versions[version] = entry+ }+ return metadata+ }+ cases := []struct {+ name string+ metadata packageMetadata+ upper string+ want string+ }{+ {"picks newest mature", build(map[string]time.Duration{"1.0.0": 100 * time.Hour, "1.1.0": 36 * time.Hour, "1.2.0": time.Hour}), "1.2.0", "1.1.0"},+ {"bounded by upper", build(map[string]time.Duration{"1.1.0": 36 * time.Hour, "2.0.0": 72 * time.Hour}), "1.2.0", "1.1.0"},+ {"skips prerelease", build(map[string]time.Duration{"1.0.0": 72 * time.Hour, "1.1.0-beta.1": 72 * time.Hour}), "1.2.0", "1.0.0"},+ {"skips deprecated", build(map[string]time.Duration{"1.0.0": 72 * time.Hour, "1.1.0": 72 * time.Hour}, "1.1.0"), "1.2.0", "1.0.0"},+ {"none mature", build(map[string]time.Duration{"1.2.0": time.Hour}), "1.2.0", ""},+ {"upper itself when mature", build(map[string]time.Duration{"1.2.0": 48 * time.Hour}), "1.2.0", "1.2.0"},+ }+ for _, tc := range cases {+ t.Run(tc.name, func(t *testing.T) {+ if got := matureVersion(tc.metadata, tc.upper, cutoff); got != tc.want {+ t.Fatalf("matureVersion = %q, want %q", got, tc.want)+ }+ })+ }+}++func TestMatureVersionIgnoresMissingOrInvalidPublishTime(t *testing.T) {+ cutoff := time.Date(2026, 1, 1, 0, 0, 0, 0, time.UTC)+ metadata := packageMetadata{+ Versions: map[string]release{"1.0.0": {Version: "1.0.0"}, "1.1.0": {Version: "1.1.0"}, "1.2.0": {Version: "1.2.0"}},+ Times: map[string]json.RawMessage{"1.1.0": json.RawMessage(`"not-a-time"`), "1.2.0": json.RawMessage(`"0001-01-01T00:00:00Z"`)},+ }+ if got := matureVersion(metadata, "1.2.0", cutoff); got != "" {+ t.Fatalf("matureVersion = %q, want empty", got)+ }+}