Skip to content

Self-hosted workflows for coding-agent delivery. Orchestrate CodeBuddy, Codex and Claude Code with scripts and human approval gates. Includes Local workflows for coding assistants.

fix(local): preserve manual gates without PyYAML (#63)

Mertense0afaa276834
diff --git a/local/.codebuddy/hooks/devflow-auto-dispatch.py b/local/.codebuddy/hooks/devflow-auto-dispatch.py
index 30238155..bf0d92c1 100644
--- a/local/.codebuddy/hooks/devflow-auto-dispatch.py
+++ b/local/.codebuddy/hooks/devflow-auto-dispatch.py
@@ -16,6 +16,7 @@ Fallback(仍发 main)的场景:
"""
import json
import os
+import re
import sys
from datetime import datetime, timezone
from pathlib import Path
@@ -70,25 +71,88 @@ FALLBACK_EVENTS = {
}
-def _read_config() -> dict:
- """读取 devflow 配置,合并 defaults + 用户覆写。"""
- root = Path(_project_root())
- defaults_path = root / ".codebuddy" / "assets" / "devflow.defaults.yaml"
- config_path = root / ".codebuddy" / "devflow.config.yaml"
+def _read_auto_mode_without_yaml(text: str):
+ """Read only a plain multi.auto_mode block without a YAML dependency.
- config = {}
- for p in [defaults_path, config_path]:
- if not p.is_file():
+ Unsupported syntax raises ValueError. Manual gates then stay with main.
+ """
+ in_multi = False
+ seen_multi = False
+ mode = None
+ child_indent = None
+ for raw in text.splitlines():
+ if raw.lstrip().startswith("#"):
+ continue
+ line = re.split(r"\s+#", raw, maxsplit=1)[0].rstrip()
+ if not line.strip():
continue
+ if "\t" in line:
+ raise ValueError("Unsupported YAML indentation")
+ indent = len(line) - len(line.lstrip(" "))
+ if indent == 0:
+ match = re.fullmatch(r"([A-Za-z_][A-Za-z_0-9-]*):(?:\s+(.*))?", line)
+ if not match:
+ raise ValueError("Unsupported YAML mapping")
+ in_multi = match.group(1) == "multi"
+ if in_multi:
+ if seen_multi or match.group(2):
+ raise ValueError("Unsupported multi mapping")
+ seen_multi = True
+ child_indent = None
+ continue
+ if not in_multi:
+ continue
+ # Complex multi settings need a full YAML parser.
+ if any(char in line for char in "&*|>{}[]"):
+ raise ValueError("Unsupported multi syntax")
+ if child_indent is None:
+ child_indent = indent
+ if indent != child_indent:
+ raise ValueError("Unsupported multi indentation")
+ match = re.fullmatch(r"([A-Za-z_][A-Za-z_0-9-]*):(?:\s+(.*))?", line.strip())
+ if not match:
+ raise ValueError("Unsupported multi setting")
+ if match.group(1) == "auto_mode":
+ value = (match.group(2) or "").lower()
+ if mode is not None or value not in ("true", "false", "yes", "no", "on", "off"):
+ raise ValueError("Invalid auto_mode")
+ mode = value in ("true", "yes", "on")
+ return mode
+
+
+def _read_auto_mode() -> bool:
+ """Read defaults and the project override. Read errors reach the caller."""
+ root = Path(_project_root())
+ paths = [root / ".codebuddy/assets/devflow.defaults.yaml",
+ root / ".codebuddy/devflow.config.yaml"]
+ try:
+ import yaml # type: ignore
+ except ImportError:
+ yaml = None
+
+ auto_mode = True
+ for path in paths:
try:
- import yaml # type: ignore
- with open(p, "r", encoding="utf-8") as f:
- data = yaml.safe_load(f) or {}
- if isinstance(data, dict):
- config.update(data)
- except Exception:
- pass
- return config
+ text = path.read_text(encoding="utf-8")
+ except FileNotFoundError:
+ continue
+ if yaml is None:
+ mode = _read_auto_mode_without_yaml(text)
+ else:
+ data = yaml.safe_load(text)
+ if data is None:
+ continue
+ if not isinstance(data, dict):
+ raise ValueError("Config must be a mapping")
+ multi = data.get("multi", {})
+ if not isinstance(multi, dict):
+ raise ValueError("multi must be a mapping")
+ mode = multi.get("auto_mode")
+ if "auto_mode" in multi and not isinstance(mode, bool):
+ raise ValueError("auto_mode must be a boolean")
+ if mode is not None:
+ auto_mode = mode
+ return auto_mode
def _append_decision(state_path: str, event: str, action: str) -> None:
@@ -212,9 +276,17 @@ def main() -> int:
return 0
# 4. 读配置:检查 auto_mode 和 manual_gates
- config = _read_config()
- multi_cfg = config.get("multi", {}) or {}
- auto_mode = multi_cfg.get("auto_mode", True)
+ try:
+ auto_mode = _read_auto_mode()
+ except Exception:
+ auto_mode = False
+ if event in MANUAL_GATES:
+ _log_hook({
+ "decision": "fallback_to_main", "reason": "config_unreadable",
+ "sender": sender, "recipient": original_recipient, "event": event,
+ })
+ print(json.dumps({"continue": True}))
+ return 0
# auto_mode=false 时,manual_gates 事件需回 main 等用户确认
if not auto_mode and event in MANUAL_GATES:
diff --git a/local/tests/e2e/test_e2e_classic_runtime.py b/local/tests/e2e/test_e2e_classic_runtime.py
index 8399c49a..93a5063b 100644
--- a/local/tests/e2e/test_e2e_classic_runtime.py
+++ b/local/tests/e2e/test_e2e_classic_runtime.py
@@ -7,6 +7,7 @@ record a session, and the dashboard built from what they wrote.
"""
import json
+import sys
import unittest
import urllib.request
@@ -54,6 +55,69 @@ class ClassicCodeBuddyE2E(unittest.TestCase):
gated = self.dispatch("architect", "TASK-02_completed", "developer")
self.assertNotIn("modifiedInput", json.dumps(gated))
+ def dispatch_without_yaml(self, event="TASK-02_completed", target="developer"):
+ hook = self.project / ".codebuddy/hooks/devflow-auto-dispatch.py"
+ output = h.run_hook(
+ self.project,
+ [sys.executable, "-c",
+ "import runpy, sys; sys.modules['yaml'] = None; "
+ "runpy.run_path(sys.argv[1], run_name='__main__')", hook],
+ {"tool_name": "SendMessage", "tool_input": {
+ "type": "message", "from": "architect", "recipient": "main",
+ "content": json.dumps({"event": event, "dispatch_prompt": "continue",
+ "next_target": {"subagent_name": target}})}},
+ )
+ return json.loads(output)
+
+ def test_manual_gates_without_yaml(self):
+ config = self.project / ".codebuddy/devflow.config.yaml"
+ for value in ("false", "true"):
+ config.write_text("multi:\n auto_mode: " + value + " # user choice\n",
+ encoding="utf-8")
+ for _, event, target in (ROUTE[1], ROUTE[3], ROUTE[4]):
+ with self.subTest(value=value, event=event):
+ output = self.dispatch_without_yaml(event, target)
+ self.assertEqual(value == "true", "hookSpecificOutput" in output)
+
+ def test_unreadable_config_keeps_manual_gates_without_yaml(self):
+ config = self.project / ".codebuddy/devflow.config.yaml"
+ for content in ("multi: [", "multi:\n auto_mode: perhaps\n",
+ "multi: {auto_mode: false}\n",
+ "multi:\n auto_mode: true#invalid\n",
+ "multi:\n auto_mode: true\n auto_mode: false\n"):
+ config.write_text(content, encoding="utf-8")
+ with self.subTest(content=content):
+ self.assertEqual({"continue": True}, self.dispatch_without_yaml())
+ records = (self.project / ".codebuddy/hooks/logs/auto-dispatch.log").read_text()
+ record = json.loads(records.splitlines()[-1])
+ self.assertEqual("config_unreadable", record["reason"])
+ self.assertEqual("fallback_to_main", record["decision"])
+ self.assertIn("hookSpecificOutput", self.dispatch_without_yaml(
+ "TASK-01_completed", "architect"))
+
+ def test_partial_override_preserves_default_manual_mode_without_yaml(self):
+ defaults = self.project / ".codebuddy/assets/devflow.defaults.yaml"
+ defaults.write_text("multi:\n auto_mode: false\n", encoding="utf-8")
+ (self.project / ".codebuddy/devflow.config.yaml").write_text(
+ "multi:\n compact_after_brainstorming: true\n", encoding="utf-8")
+ self.assertEqual({"continue": True}, self.dispatch_without_yaml())
+
+ def test_invalid_config_keeps_manual_gates_with_normal_python(self):
+ config = self.project / ".codebuddy/devflow.config.yaml"
+ for content in ("multi: [", "multi: false\n", "multi:\n auto_mode: 'false'\n"):
+ config.write_text(content, encoding="utf-8")
+ with self.subTest(content=content):
+ self.assertEqual({"continue": True},
+ self.dispatch("architect", "TASK-02_completed", "developer"))
+ records = (self.project / ".codebuddy/hooks/logs/auto-dispatch.log").read_text()
+ self.assertEqual("config_unreadable", json.loads(records.splitlines()[-1])["reason"])
+
+ def test_config_read_error_keeps_manual_gates_without_yaml(self):
+ (self.project / ".codebuddy/devflow.config.yaml").mkdir()
+ self.assertEqual({"continue": True}, self.dispatch_without_yaml())
+ records = (self.project / ".codebuddy/hooks/logs/auto-dispatch.log").read_text()
+ self.assertEqual("config_unreadable", json.loads(records.splitlines()[-1])["reason"])
+
def test_recorded_session_shows_up_in_the_local_dashboard(self):
h.record_classic_session(self.project, self.state_path)
built, dashboard = h.build_dashboard(self.project)