Skip to content

Self-hosted workflows for coding-agent delivery. Orchestrate CodeBuddy, Codex and Claude Code with scripts and human approval gates. Includes Local workflows for coding assistants.

refactor(preview): simplify containsIndex with slices.ContainsFunc (#378)

fx-kurumie206ff0a8408
diff --git a/internal/preview/archive.go b/internal/preview/archive.go
index d4031ac4..b0ce5d83 100644
--- a/internal/preview/archive.go
+++ b/internal/preview/archive.go
@@ -12,6 +12,7 @@ import (
"os"
"path"
"path/filepath"
+ "slices"
"sort"
"strings"
"syscall"
@@ -160,12 +161,7 @@ func collectRegularFiles(workspace, root string, limits Limits) ([]fileEntry, in
}
func containsIndex(entries []fileEntry, indexFile string) bool {
- for _, item := range entries {
- if item.name == indexFile {
- return true
- }
- }
- return false
+ return slices.ContainsFunc(entries, func(item fileEntry) bool { return item.name == indexFile })
}
func writeTarFile(tw *tar.Writer, item fileEntry) error {
diff --git a/internal/preview/contains_index_test.go b/internal/preview/contains_index_test.go
new file mode 100644
index 00000000..d586541d
--- /dev/null
+++ b/internal/preview/contains_index_test.go
@@ -0,0 +1,24 @@
+package preview
+
+import "testing"
+
+func TestContainsIndex(t *testing.T) {
+ entries := []fileEntry{{name: "assets/app.js"}, {name: "index.html"}, {name: "sub/index.html"}}
+ cases := []struct {
+ name string
+ entries []fileEntry
+ index string
+ want bool
+ }{
+ {"root index", entries, "index.html", true},
+ {"nested index", entries, "sub/index.html", true},
+ {"missing", entries, "home.html", false},
+ {"exact match only", entries, "INDEX.html", false},
+ {"empty entries", nil, "index.html", false},
+ }
+ for _, tc := range cases {
+ if got := containsIndex(tc.entries, tc.index); got != tc.want {
+ t.Errorf("%s: containsIndex(%q) = %v, want %v", tc.name, tc.index, got, tc.want)
+ }
+ }
+}