Self-hosted workflows for coding-agent delivery. Orchestrate CodeBuddy, Codex and Claude Code with scripts and human approval gates. Includes Local workflows for coding assistants.
JavaScript agent-orchestrationagentic-workflowai-agentsai-codingclaude-codecode-reviewcodebuddycodexcoding-agentscursordeveloper-toolshuman-on-the-loopllmmcpmulti-agentsdlcself-hostedsopworkflow-automationworkflow-engine
fix: explain why an issue cannot be deleted and hide unset stage times (#148)
crispinhu27f21b960f3f84
diff --git a/design.md b/design.mdindex c251ea5a..b71d79cd 100644--- a/design.md+++ b/design.md@@ -164,6 +164,7 @@- 当前环节使用 Status Badge,颜色由环节类型和文字共同决定:运行中蓝色呼吸点、排队中蓝色时钟、待澄清与待确认琥珀色、失败红色、已合入与已完成绿色、已关闭与未开始灰色。映射在 `issueStageTone()`。- 四个筛选由 `hui-select.js` 以触发器模式增强为 Harness Selector:原生 `select` 仍在 DOM 中负责取值和 `change`,增强层通过 MutationObserver 和 `value` 写入同步选项与文字。选项超过 5 个时显示搜索框,选了非默认值时触发器显示淡紫底。- 「更多」菜单、筛选面板和行内「⋯」共用同一套面板规格:8px 圆角、细边框、面板阴影,选项 36px,同一时刻只开一个浮层。+- 需求的「删除需求」入口始终保留;不可删除时置灰,在菜单和详情中直接显示后端返回的具体原因,并提供查看澄清、相关运行或需求详情的入口。批量选择禁用不可删项,同时提供可展开的原因列表;未知删除条件提示刷新,不猜测执行历史。删除限制和服务端最终校验保持不变。- 优先级使用信号格图标,紧急使用闪电图标;责任人前显示首字头像,Agent 用机器人图标,未指定用人像占位。超长编号单行截断,列宽上限 120px,悬停显示完整编号。- 窗口 1200px 以下搜索框、筛选按钮和项目数据块同步收窄,1024px 下筛选栏保持一行;960px 以下标题区、项目条和筛选栏改为上下堆叠。diff --git a/docs/api/openapi.yaml b/docs/api/openapi.yamlindex 0e6e6a64..d70cf5a7 100644--- a/docs/api/openapi.yaml+++ b/docs/api/openapi.yaml@@ -4206,6 +4206,24 @@ components:type: booleanreadOnly: truedescription: Whether deletion is currently permitted, computed from complete task and run history on list and detail responses.+ deletionBlock:+ type: object+ readOnly: true+ description: Present when deletion is blocked. Uses complete execution history; clarification and unfinished work take precedence over historical success and completed issue status. The DELETE conflict response uses the same reason.+ required: [code, reason]+ properties:+ code:+ type: string+ enum: [clarifying, active, succeeded, completed]+ reason:+ type: string+ description: Human-readable explanation suitable for direct display.+ runId:+ type: string+ description: Existing run responsible for the restriction, including legacy task-linked runs outside the current run list.+ taskId:+ type: string+ description: Task responsible for the restriction when there is no corresponding blocking run.id:type: stringprojectId:diff --git a/e2e/api/20-issues.test.mjs b/e2e/api/20-issues.test.mjsindex ced96ac6..171d64b6 100644--- a/e2e/api/20-issues.test.mjs+++ b/e2e/api/20-issues.test.mjs@@ -133,6 +133,8 @@ test('TAPD resync is refused for a local issue', async () => {test('deleting a separate draft issue returns 204 and removes it',async()=>{const draft=await post('/api/issues',{projectId:P,title:'E2E deletable draft',kind:'issue',status:'todo'});+ assert.equal(draft.deletionAllowed, true);+ assert.equal(draft.deletionBlock ?? null, null);await api('DELETE',`/api/issues/${draft.id}`,undefined,{expect:204});await api('GET',`/api/issues/${draft.id}`,undefined,{expect:404});});@@ -157,13 +159,31 @@ test('delete: refused once a run succeeded or while one waits; a cancelled attemtodo: 'POST /api/runs/:id/cancel tears the sandbox down inside the request (docker rm -f of the agentflow-run-*-scripts sidecar, up to dockerTeardownTimeout=60s); under nested Docker that rm hangs, so the call outlives the 60s client timeout',}, async () => {// A requirement that delivered (its dispatched run succeeded) is history.+ // Listing settles task status before the detail reason is shown.+ await get(`/api/issues?projectId=${P}`);+ const deliveredDetail = await detailOf(issue.id);+ assert.equal(deliveredDetail.issue.deletionAllowed, false);+ assert.equal(deliveredDetail.issue.deletionBlock?.code, 'succeeded');+ assert.ok(deliveredDetail.issue.deletionBlock?.runId, `succeeded history has no run: ${JSON.stringify(deliveredDetail.issue.deletionBlock)}`);+ assert.match(deliveredDetail.issue.deletionBlock.reason, /已有成功执行记录/);+ const listed = list(await get(`/api/issues?projectId=${P}`)).find(i => i.id === issue.id);+ assert.equal(listed?.deletionBlock?.reason, deliveredDetail.issue.deletionBlock.reason);+ assert.equal(listed?.deletionBlock?.runId, deliveredDetail.issue.deletionBlock.runId);const delivered = await api('DELETE', `/api/issues/${issue.id}`, undefined, { expect: 409 });- assert.match(JSON.stringify(delivered), /成功运行/);+ assert.equal(delivered.error, deliveredDetail.issue.deletionBlock.reason);+ assert.equal(delivered.deletionBlock?.code, 'succeeded');+ assert.equal(delivered.deletionBlock?.runId, deliveredDetail.issue.deletionBlock.runId);const doomed = await waitingIssue('issue-delete');await post(`/api/issues/${doomed.id}/comments`, { body: 'e2e 删除前的评论' });+ const waiting = await detailOf(doomed.id);+ assert.equal(waiting.issue.deletionAllowed, false);+ assert.equal(waiting.issue.deletionBlock?.code, 'active');+ assert.equal(waiting.issue.deletionBlock?.runId, doomed.runId);+ assert.match(waiting.issue.deletionBlock.reason, /未结束的运行/);const busy = await api('DELETE', `/api/issues/${doomed.id}`, undefined, { expect: 409 });- assert.match(JSON.stringify(busy), /停止/);+ assert.equal(busy.error, waiting.issue.deletionBlock.reason);+ assert.equal(busy.deletionBlock?.runId, doomed.runId);assert.equal((await get(`/api/issues/${doomed.id}`)).issue.id, doomed.id);await post(`/api/runs/${doomed.runId}/cancel`, {});diff --git a/internal/domain/run.go b/internal/domain/run.goindex 106d7c8d..5214e420 100644--- a/internal/domain/run.go+++ b/internal/domain/run.go@@ -124,8 +124,8 @@ type NodeRun struct {ToolCalls int `json:"toolCalls"`GateResult *GateResult `json:"gateResult,omitempty"`ChildRunID string `json:"childRunId,omitempty"`- StartedAt time.Time `json:"startedAt,omitempty"`- FinishedAt time.Time `json:"finishedAt,omitempty"`+ StartedAt time.Time `json:"startedAt,omitzero"`+ FinishedAt time.Time `json:"finishedAt,omitzero"`}// GateResult is the structured terminal decision submitted by an Agent throughdiff --git a/internal/domain/run_timing_test.go b/internal/domain/run_timing_test.goindex 8a71427e..63ab9ca5 100644--- a/internal/domain/run_timing_test.go+++ b/internal/domain/run_timing_test.go@@ -1,6 +1,8 @@package domainimport (+ "encoding/json"+ "strings""testing""time")@@ -13,6 +15,24 @@ func timingEvents(t0 time.Time, specs ...any) []RunEvent {return out}+func TestNodeRunJSONOmitsUnsetStageTimes(t *testing.T) {+ raw, err := json.Marshal(NodeRun{NodeID: "n", Status: "pending"})+ if err != nil {+ t.Fatal(err)+ }+ if strings.Contains(string(raw), "0001-01-01") || strings.Contains(string(raw), "startedAt") || strings.Contains(string(raw), "finishedAt") {+ t.Fatalf("unset stage times leaked: %s", raw)+ }+ started := time.Date(2026, 11, 9, 1, 2, 3, 0, time.UTC)+ raw, err = json.Marshal(NodeRun{NodeID: "n", Status: "running", StartedAt: started})+ if err != nil {+ t.Fatal(err)+ }+ if !strings.Contains(string(raw), `"startedAt":"2026-11-09T01:02:03Z"`) || strings.Contains(string(raw), "finishedAt") {+ t.Fatalf("partial stage window: %s", raw)+ }+}+func TestRunTimingCountsEveryAttemptAndSkipsFailedWait(t *testing.T) {t0 := time.Date(2026, 9, 21, 11, 0, 0, 0, time.UTC)events := timingEvents(t0,diff --git a/internal/httpapi/issue_deletion_view.go b/internal/httpapi/issue_deletion_view.goindex b7af7b48..786f10b2 100644--- a/internal/httpapi/issue_deletion_view.go+++ b/internal/httpapi/issue_deletion_view.go@@ -2,17 +2,20 @@ package httpapiimport ("agentflow/internal/domain"+ "agentflow/internal/repo"+"github.com/gin-gonic/gin")type issueDeletionView struct {domain.Issue- DeletionAllowed bool `json:"deletionAllowed"`- ClosureAllowed bool `json:"closureAllowed"`+ DeletionAllowed bool `json:"deletionAllowed"`+ DeletionBlock *repo.IssueDeletionBlock `json:"deletionBlock,omitempty"`+ ClosureAllowed bool `json:"closureAllowed"`}func (h issuesHandlers) issueDeletionViews(issues []domain.Issue) ([]issueDeletionView, error) {- allowed, err := h.repo.IssueDeletionAllowed(issues)+ blocks, err := h.repo.IssueDeletionBlocks(issues)if err != nil {return nil, err}@@ -25,7 +28,12 @@ func (h issuesHandlers) issueDeletionViews(issues []domain.Issue) ([]issueDeleti}out := make([]issueDeletionView, 0, len(issues))for _, issue := range issues {- out = append(out, issueDeletionView{Issue: issue, DeletionAllowed: allowed[issue.ID], ClosureAllowed: closed[issue.ID]})+ view := issueDeletionView{Issue: issue, DeletionAllowed: true, ClosureAllowed: closed[issue.ID]}+ if block, ok := blocks[issue.ID]; ok {+ view.DeletionAllowed = false+ view.DeletionBlock = &block+ }+ out = append(out, view)}return out, nil}diff --git a/internal/httpapi/issue_routes.go b/internal/httpapi/issue_routes.goindex c5e2878f..25a6331e 100644--- a/internal/httpapi/issue_routes.go+++ b/internal/httpapi/issue_routes.go@@ -348,7 +348,15 @@ func (h issuesHandlers) deleteIssue(c *gin.Context, issue domain.Issue) {if err != nil {switch {case errors.Is(err, repo.ErrIssueBusy), errors.Is(err, repo.ErrIssueSucceeded):- c.JSON(http.StatusConflict, map[string]string{"error": err.Error()})+ // Report the same concrete reason shown by list/detail affordances,+ // including when execution history changed after the menu was opened.+ if blocks, checkErr := h.repo.IssueDeletionBlocks([]domain.Issue{issue}); checkErr == nil {+ if block, ok := blocks[issue.ID]; ok {+ c.JSON(http.StatusConflict, gin.H{"error": block.Reason, "deletionBlock": block})+ return+ }+ }+ c.JSON(http.StatusConflict, gin.H{"error": err.Error()})case errors.Is(err, repo.ErrIssueNotFound):c.JSON(http.StatusNotFound, map[string]string{"error": "issue not found"})default:diff --git a/internal/httpapi/issues_delete_test.go b/internal/httpapi/issues_delete_test.goindex fc499c46..3c5f7ae1 100644--- a/internal/httpapi/issues_delete_test.go+++ b/internal/httpapi/issues_delete_test.go@@ -9,6 +9,7 @@ import ("net/http""net/http/httptest""path/filepath"+ "strings""testing")@@ -80,6 +81,15 @@ func TestDeleteIssueExecutionHistory(t *testing.T) {if detail.Issue.DeletionAllowed == success || len(list) != 1 || list[0].DeletionAllowed == success {t.Fatal("incorrect deletion affordance")}+ if success {+ for _, view := range []issueDeletionView{detail.Issue, list[0]} {+ if view.DeletionBlock == nil || view.DeletionBlock.Code != "succeeded" || view.DeletionBlock.RunID != "succeeded" {+ t.Fatalf("missing deletion reason/destination: %+v", view.DeletionBlock)+ }+ }+ } else if detail.Issue.DeletionBlock != nil || list[0].DeletionBlock != nil {+ t.Fatal("deletable issue has a stale block")+ }rr := httptest.NewRecorder()h.ServeHTTP(rr, httptest.NewRequest(http.MethodDelete, "/api/issues/history", nil))expected := http.StatusNoContent@@ -89,6 +99,9 @@ func TestDeleteIssueExecutionHistory(t *testing.T) {if rr.Code != expected {t.Fatalf("status %d: %s", rr.Code, rr.Body.String())}+ if success && !strings.Contains(rr.Body.String(), detail.Issue.DeletionBlock.Reason) {+ t.Fatalf("delete conflict disagrees with list/detail: %s", rr.Body.String())+ }for _, status := range statuses {_, runExists := st.Run(status)_, taskExists := st.Task(status)diff --git a/internal/repo/issues_delete.go b/internal/repo/issues_delete.goindex 5f46f98b..adaa0148 100644--- a/internal/repo/issues_delete.go+++ b/internal/repo/issues_delete.go@@ -106,20 +106,61 @@ func (r *IssuesRepo) IssueDeletionAllowed(issues []domain.Issue) (map[string]booreturn r.issueActionAllowed(issues, false)}+// IssueDeletionBlock explains a restriction using the complete execution history.+// RunID is only populated for an existing run, including legacy task-linked runs.+type IssueDeletionBlock struct {+ Code string `json:"code"`+ Reason string `json:"reason"`+ RunID string `json:"runId,omitempty"`+ TaskID string `json:"taskId,omitempty"`+}++func (r *IssuesRepo) IssueDeletionBlocks(issues []domain.Issue) (map[string]IssueDeletionBlock, error) {+ return r.issueActionBlocks(issues, false)+}+// IssueClosureAllowed permits settled execution history, but no active work.func (r *IssuesRepo) IssueClosureAllowed(issues []domain.Issue) (map[string]bool, error) {return r.issueActionAllowed(issues, true)}func (r *IssuesRepo) issueActionAllowed(issues []domain.Issue, allowSuccess bool) (map[string]bool, error) {+ blocks, err := r.issueActionBlocks(issues, allowSuccess)+ if err != nil {+ return nil, err+ }allowed := map[string]bool{}+ for _, issue := range issues {+ _, blocked := blocks[issue.ID]+ allowed[issue.ID] = !blocked+ }+ return allowed, nil+}++func (r *IssuesRepo) issueActionBlocks(issues []domain.Issue, allowSuccess bool) (map[string]IssueDeletionBlock, error) {+ blocks := map[string]IssueDeletionBlock{}+ // Prefer actionable temporary blockers, then historical success, then status.+ priority := map[string]int{"completed": 1, "succeeded": 2, "active": 3, "clarifying": 4}+ block := func(id string, next IssueDeletionBlock) {+ prev := blocks[id]+ if priority[next.Code] > priority[prev.Code] || (next.Code == prev.Code && prev.RunID == "" && next.RunID != "") {+ blocks[id] = next+ }+ }ids := make([]string, 0, len(issues))+ issueIDs := map[string]bool{}for _, issue := range issues {ids = append(ids, issue.ID)- allowed[issue.ID] = (allowSuccess || issue.Status != "done") && issue.Clarification.Status != "analyzing"+ issueIDs[issue.ID] = true+ if !allowSuccess && issue.Status == "done" {+ block(issue.ID, IssueDeletionBlock{Code: "completed", Reason: "需求已完成,当前不支持删除"})+ }+ if issue.Clarification.Status == "analyzing" {+ block(issue.ID, IssueDeletionBlock{Code: "clarifying", Reason: "正在澄清,请先停止澄清后再删除"})+ }}if len(ids) == 0 {- return allowed, nil+ return blocks, nil}var tasks []taskRowif err := r.DB.Select("id", "issue_id", "run_id", "status").Where("issue_id IN ?", ids).Find(&tasks).Error; err != nil {@@ -129,7 +170,11 @@ func (r *IssuesRepo) issueActionAllowed(issues []domain.Issue, allowSuccess boolrunIDs := []string{}for _, task := range tasks {if task.Status != "failed" && task.Status != "cancelled" && !(allowSuccess && (task.Status == "completed" || task.Status == "succeeded")) {- allowed[task.IssueID] = false+ restriction := IssueDeletionBlock{Code: "active", Reason: "仍有未结束的任务,请先处理或停止后再删除", TaskID: task.ID}+ if task.Status == "completed" || task.Status == "succeeded" {+ restriction = IssueDeletionBlock{Code: "succeeded", Reason: "已有成功执行记录,当前不支持删除", TaskID: task.ID}+ }+ block(task.IssueID, restriction)}if task.RunID != "" {runIssues[task.RunID] = append(runIssues[task.RunID], task.IssueID)@@ -152,18 +197,22 @@ func (r *IssuesRepo) issueActionAllowed(issues []domain.Issue, allowSuccess boolif run.Status == "failed" || run.Status == "cancelled" || (allowSuccess && run.Status == "succeeded") {continue}+ restriction := IssueDeletionBlock{Code: "active", Reason: "仍有未结束的运行,请先处理或停止后再删除", RunID: run.ID}+ if run.Status == "succeeded" {+ restriction = IssueDeletionBlock{Code: "succeeded", Reason: "已有成功执行记录,当前不支持删除", RunID: run.ID}+ }var ctx domain.TelemetryContextif len(run.ExecutionContext) > 0 {if err := jsonUnmarshal(run.ExecutionContext, &ctx); err != nil {return nil, err}}- if _, ok := allowed[ctx.IssueID]; ok {- allowed[ctx.IssueID] = false+ if issueIDs[ctx.IssueID] {+ block(ctx.IssueID, restriction)}for _, id := range runIssues[run.ID] {- allowed[id] = false+ block(id, restriction)}}- return allowed, nil+ return blocks, nil}diff --git a/internal/repo/issues_delete_test.go b/internal/repo/issues_delete_test.goindex 0ca2e54c..dfd9e221 100644--- a/internal/repo/issues_delete_test.go+++ b/internal/repo/issues_delete_test.go@@ -25,13 +25,17 @@ func TestDeleteIssue(t *testing.T) {t.Fatal(err)}defer s.Close()- for _, status := range []string{"idle", "analyzing", "running", "waiting", "queued", "succeeded", "completed", "done", "failed", "cancelled"} {+ for _, status := range []string{"idle", "closed", "analyzing", "running", "waiting", "queued", "succeeded", "completed", "done", "failed", "cancelled"} {t.Run(status, func(t *testing.T) {id := "delete-boundary-" + statusissue := domain.Issue{ID: id, ProjectID: "platform", Title: "delete test", Status: "backlog", Source: "tapd"}if status == "done" {issue.Status = "done"}+ if status == "closed" {+ issue.Status = "closed"+ issue.CloseSource = "manual"+ }if status == "analyzing" {issue.Clarification.Status = status}@@ -61,10 +65,39 @@ func TestDeleteIssue(t *testing.T) {if err != nil {t.Fatal(err)}- expected := status == "idle" || status == "failed" || status == "cancelled"+ expected := status == "idle" || status == "closed" || status == "failed" || status == "cancelled"if eligibility[id] != expected {t.Fatalf("delete visibility for %s: %v", status, eligibility[id])}+ blocks, err := s.IssueDeletionBlocks([]domain.Issue{issue})+ if err != nil {+ t.Fatal(err)+ }+ block, blocked := blocks[id]+ if blocked == expected {+ t.Fatalf("block and eligibility disagree: %+v", block)+ }+ if blocked {+ code := "active"+ if status == "analyzing" {+ code = "clarifying"+ }+ if status == "done" {+ code = "completed"+ }+ if status == "completed" || status == "succeeded" {+ code = "succeeded"+ }+ if block.Code != code || block.Reason == "" {+ t.Fatalf("incorrect block for %s: %+v", status, block)+ }+ if (status == "running" || status == "waiting" || status == "succeeded") && block.RunID != id+"-run" {+ t.Fatalf("missing run destination: %+v", block)+ }+ if (status == "queued" || status == "completed") && (block.RunID != "" || block.TaskID != id+"-task") {+ t.Fatalf("task-only block points to a missing run: %+v", block)+ }+ }closeAllowed, err := s.IssueClosureAllowed([]domain.Issue{issue})if err != nil {t.Fatal(err)@@ -83,7 +116,7 @@ func TestDeleteIssue(t *testing.T) {}return}- if status != "idle" && status != "failed" && status != "cancelled" {+ if status != "idle" && status != "closed" && status != "failed" && status != "cancelled" {if !errors.Is(err, ErrIssueBusy) {t.Fatalf("expected busy: %v", err)}@@ -123,3 +156,62 @@ func TestDeleteIssue(t *testing.T) {})}}++func TestIssueDeletionBlocksHistory(t *testing.T) {+ for _, driver := range []string{"sqlite", "mysql"} {+ t.Run(driver, func(t *testing.T) {+ var s *Store+ var err error+ if driver == "mysql" {+ dsn := os.Getenv("AGENTFLOW_TEST_MYSQL_DSN")+ if dsn == "" {+ t.Skip("MySQL DSN not set")+ }+ s, err = Open(dsn)+ } else {+ s, err = OpenTest()+ }+ if err != nil {+ t.Fatal(err)+ }+ t.Cleanup(func() { s.Close() })+ issue := domain.Issue{ID: "delete-history", ProjectID: "platform", Status: "closed", CloseSource: "manual"}+ if err := s.PutIssue(issue); err != nil {+ t.Fatal(err)+ }+ t.Cleanup(func() {+ s.DB.Where("issue_id = ?", issue.ID).Delete(&taskRow{})+ s.DB.Where("id IN ?", []string{"delete-history-old", "delete-history-latest", "delete-history-active"}).Delete(&runRow{})+ s.DB.Where("id = ?", issue.ID).Delete(&issueRow{})+ })+ // A legacy success is linked only by a cancelled task; the latest+ // directly linked run failed and must not hide the historical blocker.+ if err := s.PutRun(domain.Run{ID: "delete-history-old", Status: "succeeded"}); err != nil {+ t.Fatal(err)+ }+ if err := s.PutTask(domain.Task{ID: "delete-history-task", IssueID: issue.ID, RunID: "delete-history-old", Status: "cancelled"}); err != nil {+ t.Fatal(err)+ }+ if err := s.PutRun(domain.Run{ID: "delete-history-latest", Status: "failed", ExecutionContext: domain.TelemetryContext{IssueID: issue.ID}}); err != nil {+ t.Fatal(err)+ }+ check := func(code, runID string) {+ t.Helper()+ blocks, err := s.IssueDeletionBlocks([]domain.Issue{issue})+ if err != nil {+ t.Fatal(err)+ }+ if got := blocks[issue.ID]; got.Code != code || got.RunID != runID {+ t.Fatalf("wrong historical blocker: %+v", got)+ }+ }+ check("succeeded", "delete-history-old")+ if err := s.PutRun(domain.Run{ID: "delete-history-active", Status: "running", ExecutionContext: domain.TelemetryContext{IssueID: issue.ID}}); err != nil {+ t.Fatal(err)+ }+ check("active", "delete-history-active")+ issue.Clarification.Status = "analyzing"+ check("clarifying", "")+ })+ }+}diff --git a/web/app/issue-bulk-delete.js b/web/app/issue-bulk-delete.jsindex f1bf3fe3..f3c856bb 100644--- a/web/app/issue-bulk-delete.js+++ b/web/app/issue-bulk-delete.js@@ -33,8 +33,8 @@ function issueSelectAllCheckbox(label,showLabel=false){function issueSelectionCheckbox(issue){if(!state.issueSelectionMode)return '';const allowed=issueCanDelete(issue),disabled=state.issueBulkDeleting||!allowed;- const hint=allowed?'选择此需求':'澄清或执行中、已有成功记录的需求不能删除';- return `<label class="issue-select-label" title="${hint}" draggable="false"><input type="checkbox" class="issue-select-checkbox" data-issue-select="${escapeHTML(issue.id)}" aria-label="选择需求 ${escapeHTML(issue.title||issue.id)}"${state.issueSelection?.has(issue.id)?' checked':''}${disabled?' disabled':''}></label>`;+ const hint=allowed?'选择此需求':issueDeletionBlock(issue).reason;+ return `<label class="issue-select-label" title="${escapeHTML(hint)}" draggable="false"><input type="checkbox" class="issue-select-checkbox" data-issue-select="${escapeHTML(issue.id)}" aria-label="选择需求 ${escapeHTML(issue.title||issue.id)}${allowed?'':`:${escapeHTML(hint)}`}"${state.issueSelection?.has(issue.id)?' checked':''}${disabled?' disabled':''}></label>`;}function renderIssueBulkActions(visibleIssues){@@ -46,10 +46,13 @@ function renderIssueBulkActions(visibleIssues){const selected=state.issueSelection.size,busy=state.issueBulkDeleting,progress=state.issueBulkDeleteProgress,result=state.issueBulkDeleteResult;const scope=state.issueView==='kanban'?'全选当前可删除需求':'全选本页可删除需求';const buttonText=busy?(progress?`正在删除 ${progress.completed}/${progress.total}…`:'等待确认…'):'删除所选';+ const blocked=visibleIssues.filter(i=>!issueCanDelete(i));+ const reasonsOpen=host.querySelector('.issue-bulk-blocked')?.open;host.innerHTML=`<div class="issue-bulk-toolbar"><div class="issue-bulk-summary">${issueSelectAllCheckbox(scope,true)}<span aria-live="polite">已选择 <b>${selected}</b> 项</span><small>可跨页选择;切换筛选条件会清空选择</small></div><div class="issue-bulk-buttons"><button type="button" class="button ghost small" data-issue-cancel-selection${busy?' disabled':''}>取消</button><button type="button" class="button ghost small" data-issue-clear-selection${!selected||busy?' disabled':''}>清空选择</button><button type="button" class="button danger-outline small" data-issue-bulk-delete${!selected||busy?' disabled':''}>${buttonText}</button></div>- </div>${result?.failures.length?`<details class="issue-bulk-result" open><summary>已删除 ${result.deleted} 条,${result.failures.length} 条未删除</summary><ul>${result.failures.map(f=>`<li><b>${escapeHTML(f.title||f.id)}</b>:${escapeHTML(f.message)}</li>`).join('')}</ul></details>`:''}`;+ </div>${blocked.length?`<details class="issue-bulk-blocked"${reasonsOpen?' open':''}><summary>当前列表 ${blocked.length} 项不可删除,查看原因</summary><ul>${blocked.map(i=>`<li><div><b>${escapeHTML(i.title||i.id)}</b><p>${escapeHTML(issueDeletionBlock(i).reason)}</p></div>${issueDeletionContextHTML(i)}</li>`).join('')}</ul></details>`:''}${result?.failures.length?`<details class="issue-bulk-result" open><summary>已删除 ${result.deleted} 条,${result.failures.length} 条未删除</summary><ul>${result.failures.map(f=>`<li><b>${escapeHTML(f.title||f.id)}</b>:${escapeHTML(f.message)}</li>`).join('')}</ul></details>`:''}`;+ bindIssueDeletionContext(host);host.querySelector('[data-issue-cancel-selection]').onclick=()=>setIssueSelectionMode(false);host.querySelector('[data-issue-clear-selection]').onclick=()=>{state.issueSelection.clear();renderIssueBulkActions(visibleIssues);bindIssueSelection(visibleIssues)};host.querySelector('[data-issue-bulk-delete]').onclick=deleteSelectedIssues;diff --git a/web/app/issue-drawer.js b/web/app/issue-drawer.jsindex a4b1766f..a3826d17 100644--- a/web/app/issue-drawer.js+++ b/web/app/issue-drawer.js@@ -25,7 +25,10 @@ async function openIssueDetail(id,tab){$('#issueDetailBody').innerHTML='<div class="detail-empty">正在加载需求详情…</div>';try{const detail=await api(`/api/issues/${encodeURIComponent(issueId)}`);const issue=detail.issue;const comments=detail.comments||[];- const localIssue=(state.data.issues||[]).find(i=>i.id===issueId);if(localIssue)Object.assign(issue,localIssue);+ const localIssue=(state.data.issues||[]).find(i=>i.id===issueId);+ // Keep local view state, but deletion feedback must come from this fresh detail response.+ const permissions={deletionAllowed:issue.deletionAllowed,deletionBlock:issue.deletionBlock,closureAllowed:issue.closureAllowed};+ if(localIssue){Object.assign(issue,localIssue,permissions);Object.assign(localIssue,permissions)}const task=latestIssueTask(issue);const runId=task?.runId||latestIssueRun(issue, task)?.id;let requirement=null;@@ -41,7 +44,12 @@ async function openIssueDetail(id,tab){if(['queued','running','waiting'].includes(run.status))startLiveRun(run.id);}}- state.issueDetailData={issue,comments,run,task,requirement};+ let deletionTask=null;+ if(issue.deletionBlock?.taskId&&!issue.deletionBlock.runId){+ try{deletionTask=await api(`/api/tasks/${encodeURIComponent(issue.deletionBlock.taskId)}`,{silent:true})}catch(e){}+ if(deletionTask?.issueId!==issueId)deletionTask=null;+ }+ state.issueDetailData={issue,comments,run,task,requirement,deletionTask};const health=issueRunHealth(issue),stage=issueCurrentStage(issue),needsConfirm=clarificationNeedsConfirm(issue);state.issueDetailTab=tab||(issueClarifying(issueId)||needsConfirm?'clarify':((health==='attention'||health==='active'||stage.key==='waiting')?'sop':'overview'));$$('#issueDetailTabs .drawer-tab').forEach(b=>b.classList.toggle('active',b.dataset.dtab===state.issueDetailTab));@@ -183,6 +191,7 @@ function renderIssueDetailTab(){host.querySelectorAll('[data-resync-tapd]').forEach(b=>b.onclick=()=>resyncTAPDIssueById(b.dataset.resyncTapd));host.querySelectorAll('[data-reopen-issue]').forEach(b=>b.onclick=()=>reopenDeliveredIssue(b.dataset.reopenIssue));host.querySelectorAll('[data-delete-issue]').forEach(b=>b.onclick=()=>deleteIssueById(b.dataset.deleteIssue||issue.id));+ bindIssueDeletionContext(host);host.querySelectorAll('[data-close-issue]').forEach(b=>b.onclick=()=>closeIssueById(b.dataset.closeIssue||issue.id));host.querySelectorAll('[data-resume-run]').forEach(b=>b.onclick=()=>resumeRun(b.dataset.resumeRun,b));host.querySelectorAll('[data-pause-run]').forEach(b=>b.onclick=()=>pauseRun(b.dataset.pauseRun));@@ -500,7 +509,7 @@ function issueProgressActionsHTML(issue,run,{includeIssueActions=false}={}){issueActions.push('<button class="button ghost small" data-edit-issue>编辑需求</button>');if(issueCanPushTAPD(issue))issueActions.push(`<button class="button ghost small" data-push-tapd="${escapeHTML(issue.id)}">同步到 TAPD</button>`);if(issueCanClose(issue)&&issue.status!=='done'&&!issueManuallyClosed(issue)&&!issueTrackerClosed(issue)&&!deliveryLocked(issue))issueActions.push(`<button class="button ghost small" data-close-issue="${escapeHTML(issue.id)}">关闭需求</button>`);- if(issueCanDelete(issue))issueActions.push(`<button class="button ghost small danger" data-delete-issue="${escapeHTML(issue.id)}">删除需求</button>`);+ issueActions.push(issueDeleteControlHTML(issue));if(issue.externalRef?.externalUrl)issueActions.push(`<a class="button ghost small" href="${escapeHTML(safeURL(issue.externalRef.externalUrl))}" target="_blank" rel="noopener noreferrer">打开外部链接 ↗</a>`);if(issue.source==='tapd'&&issue.externalRef?.externalId)issueActions.push(`<button class="button ghost small" data-resync-tapd="${escapeHTML(issue.id)}">从 TAPD 同步</button>`);}@@ -902,7 +911,9 @@ function activityPane(issue,data){const comments=data.comments||[],task=data.task,run=data.run;const commentHtml=comments.slice().reverse().map(c=>`<div class="comment-row"><div class="muted">${c.authorType==='agent'?'Agent':c.authorId||'成员'} · ${new Date(c.createdAt).toLocaleString()}</div><p>${escapeHTML(c.body)}</p></div>`).join('')||'<div class="detail-empty compact">暂无讨论</div>';const items=[];- if(task)items.push({t:new Date(task.createdAt).getTime(),type:'task.created',label:'创建任务',detail:`${taskStatusLabel(task.status)}${task.agentId?' · '+task.agentId:''}`});+ for(const item of [task,data.deletionTask].filter((t,i,all)=>t&&all.findIndex(x=>x?.id===t.id)===i)){+ items.push({t:new Date(item.createdAt).getTime(),type:'task.created',label:item.id===data.deletionTask?.id?'阻止删除的任务':'创建任务',detail:`${taskStatusLabel(item.status)} · ${item.id}${item.agentId?' · '+item.agentId:''}`});+ }for(const e of run?.events||[])items.push({t:new Date(e.timestamp).getTime(),type:e.type||'',label:activityEventLabel(e.type),detail:e.message||''});items.sort((a,b)=>b.t-a.t);const rows=items.map(e=>{@@ -919,7 +930,7 @@ async function deleteIssueById(issueId){if(state.issueBulkDeleting)return toast('正在批量删除需求,请稍候','info');const issue=(state.data.issues||[]).find(i=>i.id===issueId)||state.issueDetailData?.issue;if(!issue||issue.id!==issueId)return toast('未找到需求单');- if(issueClarifying(issueId))return toast('需求正在澄清,请先停止后再删除','err');+ if(!issueCanDelete(issue))return toast(issueDeletionBlock(issue).reason,'err');const external=issue.source==='tapd'||issue.source==='gongfeng';if(!await afConfirm({title:'删除需求',message:`确定删除需求「${issue.title||issue.id}」?需求、评论、澄清记录以及失败/取消的历史任务、运行记录、日志、产物和执行工作区将一并清理,且不可恢复。已有成功运行的需求不允许删除。${external?'此操作仅删除本地记录,不会删除 TAPD/工蜂原单,后续同步可能重新导入。':''}`,danger:true,confirmText:'确认删除'}))return;try{diff --git a/web/app/issue-model.js b/web/app/issue-model.jsindex 5f0cd2bd..0542534e 100644--- a/web/app/issue-model.js+++ b/web/app/issue-model.js@@ -4,6 +4,38 @@ function issueCanClose(issue){function issueCanDelete(issue){return issue?.deletionAllowed===true&&!issueClarifying(issue.id);}+function issueDeletionBlock(issue){+ if(issueClarifying(issue?.id))return{code:'clarifying',reason:'正在澄清,请先停止澄清后再删除'};+ if(issueCanDelete(issue))return null;+ return issue?.deletionBlock?.reason?issue.deletionBlock:{code:'unknown',reason:'暂时无法确认删除条件,请刷新后重试'};+}+function issueDeletionContextHTML(issue,{menu=false}={}){+ const block=issueDeletionBlock(issue);+ if(!block)return '';+ const label=block.code==='clarifying'?'查看澄清':block.runId?'查看相关运行':block.code==='active'||block.code==='succeeded'?'查看任务与记录':'查看需求详情';+ return `<button type="button" class="${menu?'issue-popover-item':'button ghost small'}" data-issue-deletion-context="${escapeHTML(issue.id)}" aria-label="${escapeHTML(`${label}:${issue.title||issue.id},${block.reason}`)}">${menu?huiIcon('arrow-right','popover-icon'):''}${label}</button>`;+}+function issueDeleteControlHTML(issue,{menu=false}={}){+ const block=issueDeletionBlock(issue),cls=menu?'issue-popover-item':'button ghost small';+ const reasonId=`issue-delete-reason-${menu?'menu':'detail'}-${issue.id}`;+ const button=`<button type="button" class="${cls}${block?'':' danger'}" ${menu?'data-action="delete"':`data-delete-issue="${escapeHTML(issue.id)}"`}${block?` disabled aria-describedby="${escapeHTML(reasonId)}"`:''}>${menu?huiIcon('trash','popover-icon'):''}删除需求</button>`;+ if(!block)return button;+ return `<div class="issue-delete-control">${button}<p class="issue-delete-reason" id="${escapeHTML(reasonId)}">${escapeHTML(block.reason)}</p>${issueDeletionContextHTML(issue,{menu})}</div>`;+}+function bindIssueDeletionContext(root){+ root.querySelectorAll('[data-issue-deletion-context]').forEach(button=>button.onclick=e=>{+ e.stopPropagation();+ const id=button.dataset.issueDeletionContext;+ const detailIssue=state.issueDetailData?.issue?.id===id?state.issueDetailData.issue:null;+ const issue=(root.id==='issueDetailBody'?detailIssue:null)||(state.data.issues||[]).find(i=>i.id===id)||detailIssue;+ if(!issue)return;+ const block=issueDeletionBlock(issue);+ if(!block)return;+ hideIssueActionMenu();+ if(block.runId){closeIssueDrawer();openRunFromId(block.runId,{forceRuns:true})}+ else openIssueDetail(id,block.code==='clarifying'?'clarify':block.code==='active'||block.code==='succeeded'?'activity':'overview');+ });+}const issueStatuses=[['backlog','Backlog'],['todo','Todo'],['in_progress','In progress'],['in_review','In review'],['done','Done'],['closed','Closed'],['blocked','Blocked'],['cancelled','Cancelled']];function latestIssueTask(i){const tasks=(state.data.tasks||[]).filter(t=>t.issueId===i.id);@@ -437,7 +469,7 @@ function setIssueRunFilter(value,toggle=true){if(!$('#issuesView')?.classList.contains('active'))switchView('issues');else renderIssues();}-let issueMenuPopover=null;+let issueMenuPopover=null,issueMenuTrigger=null;function ensureIssueMenuPopover(){if(issueMenuPopover)return issueMenuPopover;issueMenuPopover=document.createElement('div');@@ -453,11 +485,26 @@ function ensureIssueMenuPopover(){window.addEventListener('resize',hideIssueActionMenu,{passive:true});window.addEventListener('scroll',hideIssueActionMenu,{passive:true});document.addEventListener('keydown',e=>{- if(e.key==='Escape')hideIssueActionMenu();+ if(issueMenuPopover.hidden)return;+ if(e.key==='Escape'){+ e.preventDefault();+ hideIssueActionMenu();+ issueMenuTrigger?.focus({preventScroll:true});+ }else if(['ArrowDown','ArrowUp','Home','End'].includes(e.key)){+ e.preventDefault();+ const items=[...issueMenuPopover.querySelectorAll('button:not(:disabled)')];+ const current=items.indexOf(document.activeElement);+ const next=e.key==='Home'?0:e.key==='End'?items.length-1:(current+(e.key==='ArrowUp'?-1:1)+items.length)%items.length;+ items[next]?.focus();+ }else if(e.key==='Tab'){+ hideIssueActionMenu();+ issueMenuTrigger?.focus({preventScroll:true});+ }});return issueMenuPopover;}function hideIssueActionMenu(){+ issueMenuTrigger?.setAttribute('aria-expanded','false');if(issueMenuPopover&&!issueMenuPopover.hidden){issueMenuPopover.hidden=true;issueMenuPopover.innerHTML='';@@ -468,12 +515,16 @@ function showIssueActionMenu(e,issueId){e.stopPropagation();const issue=(state.data?.issues||[]).find(i=>i.id===issueId);if(!issue)return;+ issueMenuTrigger?.setAttribute('aria-expanded','false');+ issueMenuTrigger=e.currentTarget;+ issueMenuTrigger.setAttribute('aria-expanded','true');+ issueMenuTrigger.setAttribute('aria-controls','issueActionPopover');const menu=ensureIssueMenuPopover();const isClosed=issue.status==='done'||issueManuallyClosed(issue)||deliveryLocked(issue);menu.innerHTML=`<button type="button" class="issue-popover-item" data-action="edit">${huiIcon('edit','popover-icon')}编辑需求</button>${issueTrackerClosed(issue)||(!isClosed&&!issueCanClose(issue))?'':!isClosed?`<button type="button" class="issue-popover-item danger" data-action="close">${huiIcon('close','popover-icon')}关闭需求</button>`:`<button type="button" class="issue-popover-item" data-action="reopen">${huiIcon('undo','popover-icon')}重新打开</button>`}- ${issueCanDelete(issue)?`<button type="button" class="issue-popover-item danger" data-action="delete">${huiIcon('trash','popover-icon')}删除需求</button>`:''}+ ${issueDeleteControlHTML(issue,{menu:true})}`;window.AgentFlowHarnessIcons?.hydrate?.(menu);menu.querySelector('[data-action="edit"]').onclick=ev=>{@@ -482,11 +533,12 @@ function showIssueActionMenu(e,issueId){openIssue(issue);};const deleteBtn=menu.querySelector('[data-action="delete"]');- if(deleteBtn)deleteBtn.onclick=ev=>{+ if(deleteBtn&&!deleteBtn.disabled)deleteBtn.onclick=ev=>{ev.stopPropagation();hideIssueActionMenu();deleteIssueById(issue.id);};+ bindIssueDeletionContext(menu);const closeBtn=menu.querySelector('[data-action="close"]');if(closeBtn){closeBtn.onclick=ev=>{@@ -504,19 +556,20 @@ function showIssueActionMenu(e,issueId){};}menu.hidden=false;+ menu.querySelector('button:not(:disabled)')?.focus();const btn=e.currentTarget;const rect=btn.getBoundingClientRect();const menuWidth=menu.offsetWidth||136;const menuHeight=menu.offsetHeight||72;let left=rect.right-menuWidth;- if(left<8)left=8;+ left=Math.max(8,Math.min(left,window.innerWidth-menuWidth-8));let top=rect.bottom+4;if(top+menuHeight>window.innerHeight-8){top=rect.top-menuHeight-4;}menu.style.position='fixed';menu.style.left=`${Math.round(left)}px`;- menu.style.top=`${Math.round(top)}px`;+ menu.style.top=`${Math.round(Math.max(8,top))}px`;}function bindIssueRowActions(root=document){bindIssueTriggers(root);diff --git a/web/app/issues-list.css b/web/app/issues-list.cssindex c7166513..92a24a5b 100644--- a/web/app/issues-list.css+++ b/web/app/issues-list.css@@ -46,6 +46,16 @@.issue-action-popover { min-width: 160px; gap: 0; animation: huiPopoverIn .18s var(--hui-ease-flow); }.issue-action-popover .issue-popover-item .popover-icon { width: 16px; height: 16px; opacity: 1; font-size: 0; }+.issue-action-popover:has(.issue-delete-control) { width: min(288px, calc(100vw - 16px)); max-height: calc(100dvh - 16px); overflow-y: auto; }+.issue-action-popover .issue-delete-control { margin-top: 4px; padding-top: 4px; border-top: 1px solid var(--hui-border); }+.issue-action-popover .issue-popover-item:disabled { opacity: .45; cursor: not-allowed; background: transparent; color: var(--hui-text); }+.issue-action-popover .issue-delete-reason { margin: 0; padding: 0 10px 4px 35px; color: var(--hui-secondary); font: 400 12px/1.6 var(--hui-sans); overflow-wrap: anywhere; }+#issuesView .issue-bulk-blocked { margin-top: 8px; color: var(--hui-secondary); font-size: 12px; }+#issuesView .issue-bulk-blocked summary { cursor: pointer; padding: 4px 0; }+#issuesView .issue-bulk-blocked ul { max-height: 240px; overflow-y: auto; margin: 4px 0 0; padding: 0; list-style: none; }+#issuesView .issue-bulk-blocked li { display: flex; flex-wrap: wrap; align-items: center; justify-content: space-between; gap: 8px; padding: 8px 0; border-top: 1px solid var(--hui-border); }+#issuesView .issue-bulk-blocked li > div { flex: 1; min-width: min(200px, 100%); overflow-wrap: anywhere; }+#issuesView .issue-bulk-blocked p { margin: 3px 0 0; }@keyframes huiPopoverIn { from { opacity: 0; transform: translateY(-4px); } to { opacity: 1; transform: none; } }diff --git a/web/app/runs.js b/web/app/runs.jsindex 681113e8..f3d1d4e1 100644--- a/web/app/runs.js+++ b/web/app/runs.js@@ -973,12 +973,18 @@ function graphNodeView(r,nodeId){return view;}// Stage window: when this stage's nodes started and finished, shown next to the stage label.+// Go zero time (0001-01-01T00:00:00Z) means "not set"; older payloads still carry it.+function runTimeMs(value){+ if(!value)return null;+ const ms=new Date(value).getTime();+ return Number.isFinite(ms)&&new Date(ms).getUTCFullYear()>1?ms:null;+}function stageTimeRange(r,stage){- const entries=(stage||[]).map(node=>r?.nodes?.[node.id]).filter(item=>item&&item.startedAt);- const starts=entries.map(item=>new Date(item.startedAt).getTime()).filter(value=>Number.isFinite(value));+ const entries=(stage||[]).map(node=>r?.nodes?.[node.id]).filter(item=>item&&runTimeMs(item.startedAt)!==null);+ const starts=entries.map(item=>runTimeMs(item.startedAt));if(!starts.length)return null;- const running=entries.some(item=>!item.finishedAt);- const ends=running?[]:entries.map(item=>new Date(item.finishedAt).getTime()).filter(value=>Number.isFinite(value));+ const running=entries.some(item=>runTimeMs(item.finishedAt)===null);+ const ends=running?[]:entries.map(item=>runTimeMs(item.finishedAt));return {start:Math.min(...starts),end:ends.length?Math.max(...ends):null,running:running||!ends.length};}function stageTimeLabel(r,stage){diff --git a/web/i18n-en.js b/web/i18n-en.jsindex 90893477..84fc598c 100644--- a/web/i18n-en.js+++ b/web/i18n-en.js@@ -98,3 +98,20 @@ Object.assign(window.LF_I18N_EN,{"仅生成草稿 · 切换 CLI 开启新对话,保留画布":"Draft only · switching CLI starts a new chat and keeps the canvas","暂无模型":"No models yet"});+Object.assign(window.LF_I18N_EN,{+"查看澄清":"View clarification",+"查看相关运行":"View the related run",+"查看任务与记录":"View tasks and history",+"查看需求详情":"View requirement",+"阻止删除的任务":"Task blocking deletion",+"正在澄清,请先停止澄清后再删除":"Clarification is running. Stop it before deleting.",+"暂时无法确认删除条件,请刷新后重试":"Deletion rules could not be confirmed. Refresh and try again.",+"需求已完成,当前不支持删除":"This requirement is completed and cannot be deleted.",+"仍有未结束的任务,请先处理或停止后再删除":"A task is still open. Finish or stop it before deleting.",+"已有成功执行记录,当前不支持删除":"A successful run is on record, so this requirement cannot be deleted.",+"仍有未结束的运行,请先处理或停止后再删除":"A run is still open. Finish or stop it before deleting.",+"当前列表":"In this list,",+"项不可删除,查看原因":"cannot be deleted. Show why",+"选择此需求":"Select this requirement",+"选择需求":"Select requirement"+});diff --git a/web/issue_bulk_delete_test.js b/web/issue_bulk_delete_test.jsindex ecf3a93f..228eabf5 100644--- a/web/issue_bulk_delete_test.js+++ b/web/issue_bulk_delete_test.js@@ -18,6 +18,8 @@ function setup(items, options = {}) {issueSelectionMode:false, issueSelection:new Set(), issueBulkDeleting:false, issueView:'table'};const c = {state, Set, escapeHTML, $:s => s === '#issueBulkActions' ? host : s === '#startIssueSelection' ? (buttons[s] ||= {}) : root,issueCanDelete:i => i?.deletionAllowed === true && i.clarification?.status !== 'analyzing',+ issueDeletionBlock:i => i.deletionBlock || {reason:'暂时无法确认删除条件,请刷新后重试'},+ issueDeletionContextHTML:() => '', bindIssueDeletionContext:() => {},filteredIssues:() => state.data.issues.filter(i => !state.projectFilter || i.projectId === state.projectFilter),toast:(...args) => notices.push(args),afConfirm:async opts => {calls.push(['confirm',opts]);return options.confirm !== false;},diff --git a/web/issue_delete_test.js b/web/issue_delete_test.jsindex 481e6c2d..19b5fdc2 100644--- a/web/issue_delete_test.js+++ b/web/issue_delete_test.js@@ -22,10 +22,10 @@ assert.equal(visibility.issueCanClose({id:'settled',closureAllowed:true}),true);assert.equal(visibility.issueCanClose({id:'active',closureAllowed:false}),false);assert.equal(visibility.issueCanClose({id:'busy',closureAllowed:true}),false);async function run({confirm=true, busy=false, fail=false, batch=false}={}) {- const issue={id:'issue/1',title:'测试需求',source:'tapd'};+ const issue={id:'issue/1',title:'测试需求',source:'tapd',deletionAllowed:true};const calls=[];const state={data:{issues:[issue,{id:'other'}]},issueDetailData:{issue},selectedIssue:issue.id,issueBulkDeleting:batch,issueSelection:new Set([issue.id,'other'])};- const context={state,issueClarifying:()=>busy,toast:()=>{},refreshRuns:async()=>{},renderIssues:()=>calls.push('render'),closeIssueDrawer:()=>calls.push('close'),afConfirm:async opts=>{assert(opts.message.includes('后续同步可能重新导入'));return confirm;},api:async(path,opts)=>{calls.push([path,opts.method]);if(fail)throw new Error('conflict');}};+ const context={state,issueCanDelete:()=>!busy,issueDeletionBlock:()=>({reason:'正在澄清'}),toast:()=>{},refreshRuns:async()=>{},renderIssues:()=>calls.push('render'),closeIssueDrawer:()=>calls.push('close'),afConfirm:async opts=>{assert(opts.message.includes('后续同步可能重新导入'));return confirm;},api:async(path,opts)=>{calls.push([path,opts.method]);if(fail)throw new Error('conflict');}};vm.createContext(context);vm.runInContext(code,context);await context.deleteIssueById(issue.id);return {state,calls};diff --git a/web/platform.css b/web/platform.cssindex 93193908..3355351d 100644--- a/web/platform.css+++ b/web/platform.css@@ -456,6 +456,8 @@ html[data-theme="dark"] .issue-title-tag.tone-cyan{color:#67e8f9}.issue-action-group>span{padding-top:8px;color:var(--muted);font-size:11px;white-space:nowrap}.issue-action-group-buttons{display:flex;flex-wrap:wrap;gap:8px}.issue-action-group-buttons .button{display:inline-flex;align-items:center;justify-content:center;min-height:32px;padding:5px 11px;border-radius:8px;font-size:12px;white-space:normal;text-align:center}+#issueDetailDrawer .issue-delete-control{flex:1 1 100%;display:flex;align-items:center;flex-wrap:wrap;gap:6px 8px;padding-top:8px;border-top:1px solid var(--hui-border)}+#issueDetailDrawer .issue-delete-reason{flex:1 1 180px;margin:0;color:var(--hui-secondary);font-size:12px;line-height:1.6;overflow-wrap:anywhere}.node-progress-row .button{flex-shrink:0}.human-decision{display:flex;flex-direction:column;gap:8px;width:100%}.human-gate-brief{display:flex;flex-direction:column;gap:8px;max-height:320px;overflow:auto;padding:10px 12px;border:1px solid rgba(245,158,11,.35);border-radius:8px;background:rgba(251,191,36,.08)}diff --git a/webtest/tests/issue-deletion-feedback.test.mjs b/webtest/tests/issue-deletion-feedback.test.mjsnew file mode 100644index 00000000..c03b48ca--- /dev/null+++ b/webtest/tests/issue-deletion-feedback.test.mjs@@ -0,0 +1,121 @@+import test from 'node:test';+import assert from 'node:assert/strict';+import { loadApp, settle } from '../lib/load-app.mjs';++const reason = '已有成功执行记录,当前不支持删除';+const blockedIssue = {+ id: 'delete-feedback', projectId: 'project-1', title: '国际站套餐支持升级',+ status: 'closed', closeSource: 'manual', source: 'local', priority: 'medium',+ deletionAllowed: false, closureAllowed: true,+ deletionBlock: { code: 'succeeded', reason, runId: 'old-success' },+};++function showMenu(app, issue) {+ app.evaluate(`{+ state.data.issues=[${JSON.stringify(issue)}];+ state.data.tasks=[];state.data.runs=[];+ const trigger=document.createElement('button');+ document.body.appendChild(trigger);+ showIssueActionMenu({preventDefault(){},stopPropagation(){},currentTarget:trigger},'${issue.id}');+ }`);+ return app.document.querySelector('#issueActionPopover');+}++test('closed issue keeps a disabled delete entry, visible reason, and the exact historical run link', async t => {+ const app = await loadApp();+ t.after(app.close);+ app.evaluate(`openRunFromId=(id,opts)=>window.deletionDestination={id,opts}`);+ app.evaluate(`state.issueDetailData={issue:${JSON.stringify({ ...blockedIssue, deletionBlock: { code:'active', reason:'旧抽屉数据', runId:'stale-run' } })}}`);+ const menu = showMenu(app, blockedIssue);+ const deletion = menu.querySelector('[data-action="delete"]');+ assert.equal(deletion.disabled, true);+ assert.equal(app.document.getElementById(deletion.getAttribute('aria-describedby')).textContent, reason);+ assert.match(menu.textContent, /重新打开/);+ assert.match(menu.textContent, /查看相关运行/);+ assert.equal(app.document.activeElement, menu.querySelector('[data-action="edit"]'));+ app.document.dispatchEvent(new app.window.KeyboardEvent('keydown', { key: 'End', bubbles: true }));+ assert.equal(app.document.activeElement, menu.querySelector('[data-issue-deletion-context]'));+ menu.querySelector('[data-issue-deletion-context]').click();+ assert.deepEqual(structuredClone(app.evaluate('window.deletionDestination')), {+ id: 'old-success', opts: { forceRuns: true },+ });+ assert.equal(menu.hidden, true);+ assert.equal(app.router.calls.some(c => c.method === 'DELETE'), false);+});++test('allowed, live clarification, completed, and unknown deletion states have honest feedback', async t => {+ const app = await loadApp();+ t.after(app.close);+ let menu = showMenu(app, { ...blockedIssue, deletionAllowed: true, deletionBlock: undefined });+ assert.equal(menu.querySelector('[data-action="delete"]').disabled, false);+ assert.equal(menu.querySelector('.issue-delete-reason'), null);+ menu = showMenu(app, { ...blockedIssue, deletionAllowed: true, clarification: { status: 'analyzing' } });+ assert.equal(menu.querySelector('[data-action="delete"]').disabled, true);+ assert.match(menu.querySelector('.issue-delete-reason').textContent, /正在澄清/);+ assert.match(menu.querySelector('[data-issue-deletion-context]').textContent, /查看澄清/);+ menu = showMenu(app, { ...blockedIssue, status: 'done', deletionBlock: {code: 'completed', reason: '需求已完成,当前不支持删除'} });+ assert.match(menu.textContent, /需求已完成/);+ menu = showMenu(app, { ...blockedIssue, deletionAllowed: undefined, deletionBlock: undefined });+ assert.match(menu.querySelector('.issue-delete-reason').textContent, /刷新后重试/);+ assert.doesNotMatch(menu.querySelector('.issue-delete-reason').textContent, /成功/);+});++test('drawer uses fresh server restrictions and displays the task that prevents deletion', async t => {+ const app = await loadApp();+ t.after(app.close);+ const issue = { ...blockedIssue, deletionBlock: { code: 'succeeded', reason, taskId: 'historical-task' } };+ app.router.get('/api/issues/delete-feedback', { issue, comments: [] });+ app.router.get('/api/issues/delete-feedback/requirement', {});+ app.router.get('/api/tasks/historical-task', {+ id: 'historical-task', issueId: issue.id, status: 'completed', createdAt: '2026-01-01T00:00:00Z',+ });+ app.evaluate(`state.data.issues=[${JSON.stringify({ ...issue, deletionAllowed: true, deletionBlock: undefined })}];state.data.tasks=[];state.data.runs=[]`);+ await app.evaluate(`openIssueDetail('delete-feedback','overview')`);+ assert.equal(app.evaluate('state.issueDetailData.issue.deletionAllowed'), false);+ assert.equal(app.evaluate('state.data.issues[0].deletionAllowed'), false);+ const drawer = app.document.querySelector('#issueDetailBody');+ assert.equal(drawer.querySelector('[data-delete-issue]').disabled, true);+ assert.equal(drawer.querySelector('.issue-delete-reason').textContent, reason);+ drawer.querySelector('[data-issue-deletion-context]').click();+ await settle(4);+ assert.equal(app.evaluate('state.issueDetailTab'), 'activity');+ assert.match(drawer.textContent, /阻止删除的任务/);+ assert.match(drawer.textContent, /historical-task/);+ assert.match(drawer.textContent, /已完成/);+ await app.evaluate(`deleteIssueById('delete-feedback')`);+ assert.equal(app.router.calls.some(c => c.method === 'DELETE'), false);++ app.router.get('/api/issues/delete-feedback', { issue: { ...issue, deletionAllowed: true, deletionBlock: undefined }, comments: [] });+ await app.evaluate(`openIssueDetail('delete-feedback','overview')`);+ assert.equal(app.evaluate('state.issueDetailData.issue.deletionAllowed'), true);+ assert.equal(drawer.querySelector('[data-delete-issue]').disabled, false);+ assert.equal(drawer.querySelector('.issue-delete-reason'), null);+});++test('bulk selection explains protected rows and escapes server-provided reasons', async t => {+ const app = await loadApp();+ t.after(app.close);+ const malicious = '<img src=x onerror=alert(1)>';+ const issue = { ...blockedIssue, title: malicious, deletionBlock: { code: 'active', reason: malicious } };+ app.evaluate(`+ state.data.issues=[${JSON.stringify(issue)},${JSON.stringify({ ...blockedIssue, id: 'allowed', deletionAllowed: true, deletionBlock: undefined })}];+ state.projectFilter='';state.issueQuery='';state.issueRunFilter='';state.issueStatusFilter='';state.issueAssigneeFilter='';+ state.data.tasks=[];state.data.runs=[];state.issueView='table';+ setIssueSelectionMode(true);+ `);+ const host = app.document.querySelector('#issueBulkActions');+ const blocked = app.document.querySelector('[data-issue-select="delete-feedback"]');+ assert.equal(blocked.disabled, true);+ assert.match(blocked.getAttribute('aria-label'), /onerror/);+ assert.match(host.querySelector('.issue-bulk-blocked summary').textContent, /1 项不可删除/);+ assert.equal(host.querySelector('.issue-bulk-blocked p').textContent, malicious);+ assert.equal(host.querySelector('img'), null);+ assert.equal(app.document.querySelector('[data-issue-select="allowed"]').disabled, false);+ host.querySelector('.issue-bulk-blocked summary').click();+ assert.equal(host.querySelector('.issue-bulk-blocked').open, true);+ app.document.querySelector('[data-issue-select="allowed"]').click();+ assert.equal(host.querySelector('.issue-bulk-blocked').open, true, 'selection changes preserve expanded reasons');+ app.evaluate(`openIssueDetail=(id,tab)=>window.deletionDestination={id,tab}`);+ host.querySelector('[data-issue-deletion-context]').click();+ assert.deepEqual(structuredClone(app.evaluate('window.deletionDestination')), { id: issue.id, tab: 'activity' });+});diff --git a/webtest/tests/runs-detail.test.mjs b/webtest/tests/runs-detail.test.mjsindex 730cd25a..2dd40ca3 100644--- a/webtest/tests/runs-detail.test.mjs+++ b/webtest/tests/runs-detail.test.mjs@@ -172,3 +172,27 @@ test('run detail topology shows each stage time window beside its stage label',assert.ok(runtime, 'node inspector should keep the runtime details row');assert.doesNotMatch(runtime.textContent, /\u2192/, 'time window is no longer repeated under the node output');});++test('a stage that has not started or finished hides the zero default time', async (t) => {+ const app = await loadApp();+ t.after(app.close);+ const workflow = app.evaluate('structuredClone(state.data.workflows[0])');+ const [first, second] = workflow.nodes;+ const nodes = {+ [first.id]: { status: 'pending', startedAt: '0001-01-01T00:00:00Z', finishedAt: '0001-01-01T00:00:00Z' },+ [second.id]: { status: 'running', startedAt: '2026-10-21T10:04:00Z', finishedAt: '0001-01-01T00:00:00Z' },+ };+ const run = {+ ...app.evaluate('structuredClone(state.data.runs[0])'), status: 'running',+ workflowSnapshot: workflow, nodes,+ };+ app.router.get('/api/runs/run-1', run);+ app.evaluate(`state.data.runs=[${JSON.stringify(run)}];state.selectedRun='run-1';state.activeRun=state.data.runs[0]`);+ app.evaluate(`switchView('runs');showRunDetail('run-1')`);+ await settle(6);+ const labels = [...app.document.querySelectorAll('#runsView .graph-stage-label')];+ const times = labels.map((label) => label.querySelector('.graph-stage-time')?.textContent || '');+ assert.ok(times.some((text) => text === ''), 'an unstarted stage has no duration');+ assert.ok(times.some((text) => text.includes('现在') && !text.includes('0001')), `an open stage shows now, not year 1: ${times.join(' | ')}`);+ assert.ok(times.every((text) => !text.includes('0001')), times.join(' | '));+});