Self-hosted workflows for coding-agent delivery. Orchestrate CodeBuddy, Codex and Claude Code with scripts and human approval gates. Includes Local workflows for coding assistants.
JavaScript agent-orchestrationagentic-workflowai-agentsai-codingclaude-codecode-reviewcodebuddycodexcoding-agentscursordeveloper-toolshuman-on-the-loopllmmcpmulti-agentsdlcself-hostedsopworkflow-automationworkflow-engine
refactor(httpapi): extract trailingSlashEntity and use slices.Contains (#279)
fx-kurumif3665ac9b122
diff --git a/internal/httpapi/helpers_cases_test.go b/internal/httpapi/helpers_cases_test.goindex 8fd482c7..30293bf4 100644--- a/internal/httpapi/helpers_cases_test.go+++ b/internal/httpapi/helpers_cases_test.go@@ -209,9 +209,6 @@ func TestServerAuthBinaryAndSSEHelpers(t *testing.T) {func TestTrailingSlashAndMiddlewareBranches(t *testing.T) {gin.SetMode(gin.TestMode)- if !containsMethod([]string{"GET", "POST"}, "POST") || containsMethod([]string{"GET"}, "DELETE") {- t.Fatal("containsMethod")- }for _, tc := range []struct {method stringpath stringdiff --git a/internal/httpapi/trailing_slash_compat.go b/internal/httpapi/trailing_slash_compat.goindex 379a5a87..bd564b4b 100644--- a/internal/httpapi/trailing_slash_compat.go+++ b/internal/httpapi/trailing_slash_compat.go@@ -2,6 +2,7 @@ package httpapiimport ("net/http"+ "slices""strings""github.com/gin-gonic/gin"@@ -28,23 +29,7 @@ func masterTrailingSlashCompat(c *gin.Context, s *Server) bool {if !strings.HasPrefix(p, "/api/") || !strings.HasSuffix(p, "/") {return false}- rest := strings.TrimPrefix(p, "/api/")- entity := rest- if i := strings.Index(rest, "/"); i >= 0 {- entity = rest[:i]- }- // "auth/tokens" 这类两段子树:兼容表以两段为 key(/api/auth/ 本身没有- // 子树注册,取首段会 miss)。- if i := strings.Index(rest, "/"); i >= 0 {- if second := rest[i+1:]; second != "" {- if tail := strings.Index(second, "/"); tail >= 0 {- second = second[:tail]- }- if _, ok := apiTrailingSlash405[entity+"/"+second]; ok {- entity = entity + "/" + second- }- }- }+ entity := trailingSlashEntity(strings.TrimPrefix(p, "/api/"))// master authToken handler:非 DELETE 一律 405;DELETE 通过方法检查后做// 登录检查(未登录 401;登录后空 id 400 "Token ID 不能为空")。if entity == "auth/tokens" {@@ -58,7 +43,7 @@ func masterTrailingSlashCompat(c *gin.Context, s *Server) bool {return true}methods, ok := apiTrailingSlash405[entity]- if ok && containsMethod(methods, c.Request.Method) {+ if ok && slices.Contains(methods, c.Request.Method) {c.JSON(http.StatusMethodNotAllowed, map[string]string{"error": "method not allowed"})return true}@@ -69,11 +54,17 @@ func masterTrailingSlashCompat(c *gin.Context, s *Server) bool {return true}-func containsMethod(methods []string, m string) bool {- for _, method := range methods {- if method == m {- return true- }+// trailingSlashEntity 从 "/api/" 之后的路径解析兼容表 key:默认取首段;+// "auth/tokens" 这类两段子树以两段为 key(/api/auth/ 本身没有子树注册,+// 取首段会 miss),仅当两段 key 在 apiTrailingSlash405 中存在时才采用。+func trailingSlashEntity(rest string) string {+ entity, tail, found := strings.Cut(rest, "/")+ if !found || tail == "" {+ return entity+ }+ second, _, _ := strings.Cut(tail, "/")+ if _, ok := apiTrailingSlash405[entity+"/"+second]; ok {+ return entity + "/" + second}- return false+ return entity}diff --git a/internal/httpapi/trailing_slash_compat_test.go b/internal/httpapi/trailing_slash_compat_test.gonew file mode 100644index 00000000..3d421e0d--- /dev/null+++ b/internal/httpapi/trailing_slash_compat_test.go@@ -0,0 +1,26 @@+package httpapi++import "testing"++func TestTrailingSlashEntity(t *testing.T) {+ for _, tc := range []struct {+ rest string+ want string+ }{+ {"", ""},+ {"users/", "users"},+ {"users", "users"},+ {"users/42/", "users"},+ {"auth/", "auth"},+ {"auth/tokens/", "auth/tokens"},+ {"auth/tokens/abc/", "auth/tokens"},+ {"auth/tokens", "auth/tokens"},+ {"auth/other/", "auth"},+ {"otel/v1/traces/", "otel"},+ {"unknown/x/", "unknown"},+ } {+ if got := trailingSlashEntity(tc.rest); got != tc.want {+ t.Errorf("trailingSlashEntity(%q) = %q want %q", tc.rest, got, tc.want)+ }+ }+}