Skip to content

Self-hosted workflows for coding-agent delivery. Orchestrate CodeBuddy, Codex and Claude Code with scripts and human approval gates. Includes Local workflows for coding assistants.

refactor(tracker): 合并重复的 Authorization 请求头判断 (#276) (#277)

fx-kurumifb2856983aef
diff --git a/internal/tracker/catalog.go b/internal/tracker/catalog.go
index d44caf52..bbb9e7d7 100644
--- a/internal/tracker/catalog.go
+++ b/internal/tracker/catalog.go
@@ -101,7 +101,7 @@ func bindProjectUserTrackerMCP(kind string, cfg domain.SyncConfig, servers []dom
if strings.TrimSpace(binding.URL) == "" {
return binding, fmt.Errorf("项目 %s 未配置 %s MCP 地址", projectID, trackerDisplayName(kind))
}
- if !hasAuthorizationHeader(binding.Headers) {
+ if !headerHas(binding.Headers, "Authorization") {
return binding, fmt.Errorf("项目 %s 的 %s MCP 未配置认证:请在 MCP Headers 中提供 Authorization(%s %s)", projectID, trackerDisplayName(kind), role, strings.TrimSpace(user.LoginName))
}
binding.Headers = maps.Clone(binding.Headers)
@@ -196,9 +196,11 @@ func bearerHeader(value string) string {
return "Bearer " + value
}
+// headerHas reports whether headers carries a non-blank value for name,
+// matching the key case-insensitively and ignoring surrounding whitespace.
func headerHas(headers map[string]string, name string) bool {
for k, v := range headers {
- if strings.EqualFold(k, name) && strings.TrimSpace(v) != "" {
+ if strings.EqualFold(strings.TrimSpace(k), name) && strings.TrimSpace(v) != "" {
return true
}
}
@@ -213,12 +215,3 @@ func sameMCPHost(a, b string) bool {
}
return strings.EqualFold(ua.Host, ub.Host)
}
-
-func hasAuthorizationHeader(headers map[string]string) bool {
- for key, value := range headers {
- if strings.EqualFold(strings.TrimSpace(key), "authorization") && strings.TrimSpace(value) != "" {
- return true
- }
- }
- return false
-}
diff --git a/internal/tracker/header_has_test.go b/internal/tracker/header_has_test.go
new file mode 100644
index 00000000..eb2c864d
--- /dev/null
+++ b/internal/tracker/header_has_test.go
@@ -0,0 +1,27 @@
+package tracker
+
+import "testing"
+
+func TestHeaderHas(t *testing.T) {
+ cases := []struct {
+ name string
+ headers map[string]string
+ want bool
+ }{
+ {"nil map", nil, false},
+ {"exact", map[string]string{"Authorization": "Bearer x"}, true},
+ {"lower case key", map[string]string{"authorization": "Bearer x"}, true},
+ {"padded key", map[string]string{" Authorization ": "Bearer x"}, true},
+ {"empty value", map[string]string{"Authorization": ""}, false},
+ {"blank value", map[string]string{"Authorization": " "}, false},
+ {"other header", map[string]string{"X-Token": "x"}, false},
+ {"one of many", map[string]string{"X-Token": "x", "AUTHORIZATION": "t"}, true},
+ }
+ for _, tc := range cases {
+ t.Run(tc.name, func(t *testing.T) {
+ if got := headerHas(tc.headers, "Authorization"); got != tc.want {
+ t.Fatalf("headerHas(%v) = %v, want %v", tc.headers, got, tc.want)
+ }
+ })
+ }
+}