Skip to content

LordOS — a free, fast and secure GNU/Linux distribution based on Debian, with its own desktop environment: display server and Wayland compositor in C, a React UI engine on QuickJS, and private native apps.

Keyring box: one answer goes to every queued request and a new request no longer wipes the field (Cancel brought the box back for each request an app made); a key listener that throws no longer keeps the key from the others

Federico Pereira2a1e5cf80ffd
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 76a1981..ae70e81 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -53,7 +53,11 @@ of the matching [GitHub release](https://github.com/lordbasex/LordOS/releases),
session, a virtual machine) is faster with the same pixels: the backdrop blur 2.5×, rounded
rectangles 2×, and `canvas.c` builds at -O3. The video now follows the browser screen's refresh rate
(60, 120, 144 Hz…) instead of a fixed 30: a video window under blurred windows went from 18 to 35
- frames a second on a virtual machine without a GPU. The page starts muted, as browsers
+ frames a second on a virtual machine without a GPU. Heavy frames paint on several threads (up to 8,
+ only while needed): a 1080p session went from 45 to 55–58 frames a second.
+- **The keyring box couldn't be answered when several apps asked at once:** every new request wiped
+ the field and Cancel brought it back for the next one. One answer now goes to all of them, and a
+ key listener that fails no longer keeps the key from the others. The page starts muted, as browsers
require, and its sound button hides in the top bar: the first click or key in the session now
turns the sound on.
- **Files → This computer** shows `/proc`, `/sys`, `/dev` and `/run` with a lock and says why it
diff --git a/runtime/events.js b/runtime/events.js
index a817fe1..36df121 100644
--- a/runtime/events.js
+++ b/runtime/events.js
@@ -103,7 +103,10 @@ globalThis.__lordEvent = (type, id, x, y, button) => {
// XKB layout is loaded only the code and value arrive and keymap.js is used as a fallback.
globalThis.__lordKey = (code, value, key, chr, base, flags) => {
const ev = key === undefined ? translate(code, value) : nativeKey(code, value, key, chr, base, flags);
- run(DiscreteEventPriority, () => { for (const fn of listeners[ev.down ? 'keydown' : 'keyup']) fn(ev); });
+ // each listener on its own: one that throws doesn't take the key from the others (a text field)
+ run(DiscreteEventPriority, () => {
+ for (const fn of listeners[ev.down ? 'keydown' : 'keyup']) { try { fn(ev); } catch (e) { console.error('key listener:', e); } }
+ });
};
// Touchpad, touchscreen and remote-desktop trackpad (server/src/tp, docs/TRACKPAD.md):
diff --git a/sdk/vault.js b/sdk/vault.js
index 504f0e3..75dfd5f 100644
--- a/sdk/vault.js
+++ b/sdk/vault.js
@@ -147,10 +147,18 @@ export function KeyringPrompt() {
const [pw, setPw] = useState('');
const [err, setErr] = useState('');
const [busy, setBusy] = useState(false);
- useEffect(() => { setPw(''); setErr(''); }, [q.length]);
- if (!q.length) return null;
const cur = q[0];
- const done = (ok) => { try { lord.vault.promptDone(cur.prompt, ok); } catch (e) { /* */ } prompts.set((l) => l.slice(1)); };
+ // a new prompt clears the field; more of them queuing up behind it doesn't (they used to wipe what
+ // was being typed)
+ useEffect(() => { setPw(''); setErr(''); }, [cur?.prompt]);
+ if (!q.length) return null;
+ // every queued prompt asks for the same keyring: one answer goes to all of them, so Cancel doesn't
+ // bring the same box back once per request an app made
+ const done = (ok) => {
+ const all = prompts.get();
+ for (const p of all) { try { lord.vault.promptDone(p.prompt, ok); } catch (e) { /* */ } }
+ prompts.set((l) => l.filter((p) => !all.includes(p)));
+ };
const submit = async () => {
setBusy(true);
try { await vaultRequest('unlock', { v: 'login', method: 'session', password: pw }); setBusy(false); done(true); }