Skip to content

LordOS — a free, fast and secure GNU/Linux distribution based on Debian, with its own desktop environment: display server and Wayland compositor in C, a React UI engine on QuickJS, and private native apps.

Package engine: send '+' as %2B in request paths (lordos.org's S3 origin answered 404 for kms++ packages)

Federico Pereira55e068bc5c1e
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 5043dd5..8637799 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,6 +10,13 @@ of the matching [GitHub release](https://github.com/lordbasex/LordOS/releases),
## [Unreleased]
+### Fixed
+
+- The Store's package engine could not download packages with a `+` in their name (`kms++-utils`,
+ `libkms++0`) from lordos.org: the CDN reads a bare `+` as a space and answered 404. It now sends
+ `%2B`, as apt does, so Settings → Board firmware can install the bootloader tools from the LordOS
+ repository alone.
+
## [0.8.4.1-beta] - 2026-10-25
An update of 0.8.4 for the Raspberry Pi 5: its bootloader from Settings, and a new Pi image with the
diff --git a/server/src/pkg/http.c b/server/src/pkg/http.c
index 5fd25a4..82cc1bc 100644
--- a/server/src/pkg/http.c
+++ b/server/src/pkg/http.c
@@ -235,7 +235,16 @@ static void get_one(Conn *c, const FetchItem *it, uint32_t idx) {
int retry = c->fd >= 0; /* a reused connection may have been closed */
again:
if (conn_open(c, host, port, err, sizeof err)) break;
- char req[1600], ims[80] = "";
+ /* '+' as %2B, as apt does: an S3 origin (lordos.org) reads a bare '+' as a space, so
+ * pool/rpi/k/kms++-utils/… would be a 404 */
+ char epath[3 * sizeof url]; /* every byte of the URL could be a '+' */
+ size_t en = 0;
+ for (const char *q = path; *q; q++) {
+ if (*q == '+') { memcpy(epath + en, "%2B", 3); en += 3; }
+ else epath[en++] = *q;
+ }
+ epath[en] = 0;
+ char req[3600], ims[80] = "";
if (it->ims > 0) {
char d[48];
http_format_date(it->ims, d, sizeof d);
@@ -243,7 +252,7 @@ static void get_one(Conn *c, const FetchItem *it, uint32_t idx) {
}
int rl = snprintf(req, sizeof req, "GET %s HTTP/1.1\r\nHost: %s%s%s\r\nUser-Agent: LordOS-pkg/0.7\r\n"
"Accept-Encoding: identity\r\nConnection: keep-alive\r\n%s\r\n",
- path, host, strcmp(port, "80") ? ":" : "", strcmp(port, "80") ? port : "", ims);
+ epath, host, strcmp(port, "80") ? ":" : "", strcmp(port, "80") ? port : "", ims);
if (rl >= (int)sizeof req || conn_write(c, req, (size_t)rl) || conn_line(c, line, sizeof line)) {
conn_close(c);
if (retry) { retry = 0; goto again; }