Skip to content

利用 AI 大模型和自动化工作流,根据主题或关键词一键生成高清短视频。Generate HD short videos from a topic or keyword with an automated AI workflow.

fix(upload): validate provider responses (#1417)

Rudy Mizrahi Celekli11f64045a6d3
diff --git a/app/services/upload_post.py b/app/services/upload_post.py
index cd9ebb21..3910e572 100644
--- a/app/services/upload_post.py
+++ b/app/services/upload_post.py
@@ -121,6 +121,14 @@ class UploadPostService:
response.raise_for_status()
result = response.json()
+ if not isinstance(result, dict) or not isinstance(
+ result.get("success"), bool
+ ):
+ logger.error("Upload-Post returned an invalid response to upload")
+ return {
+ "success": False,
+ "error": "Upload-Post returned an invalid response",
+ }
if result.get('success'):
logger.info(f"✅ Video cross-posted successfully! Request ID: {result.get('request_id')}")
@@ -156,7 +164,14 @@ class UploadPostService:
)
response.raise_for_status()
- return response.json()
+ result = response.json()
+ if not isinstance(result, dict):
+ logger.error("Upload-Post returned an invalid response to status query")
+ return {
+ "success": False,
+ "error": "Upload-Post returned an invalid response",
+ }
+ return result
except requests.exceptions.RequestException as e:
logger.error(f"Failed to check status: {str(e)}")
diff --git a/test/services/test_upload_post.py b/test/services/test_upload_post.py
index 9bbb6115..911fa1c7 100644
--- a/test/services/test_upload_post.py
+++ b/test/services/test_upload_post.py
@@ -99,6 +99,50 @@ class TestUploadPostService(unittest.TestCase):
self.assertFalse(failed["success"])
self.assertIn("offline", failed["error"])
+ @patch("app.services.upload_post.config.app", _CONFIG_BASE)
+ @patch("app.services.upload_post.os.path.exists", return_value=True)
+ @patch("builtins.open", mock_open(read_data=b"fake"))
+ @patch("app.services.upload_post.requests.post")
+ def test_upload_rejects_unexpected_json_shape(self, mock_post, _exists):
+ """A malformed provider payload must not abort subsequent video uploads."""
+ response = _mock_response()
+ response.json.return_value = ["unexpected"]
+ mock_post.side_effect = [response, _mock_response()]
+
+ service = UploadPostService()
+ result = service.upload_video("/fake/v.mp4", "Title")
+
+ self.assertEqual(result["success"], False)
+ self.assertIn("invalid response", result["error"])
+ self.assertTrue(service.upload_video("/fake/next.mp4", "Next")["success"])
+ self.assertEqual(mock_post.call_count, 2)
+
+ @patch("app.services.upload_post.config.app", _CONFIG_BASE)
+ @patch("app.services.upload_post.requests.get")
+ def test_status_rejects_unexpected_json_shape(self, mock_get):
+ response = _mock_response()
+ response.json.return_value = ["unexpected"]
+ mock_get.return_value = response
+
+ result = UploadPostService().check_status("request-123")
+
+ self.assertEqual(result["success"], False)
+ self.assertIn("invalid response", result["error"])
+
+ @patch("app.services.upload_post.config.app", _CONFIG_BASE)
+ @patch("app.services.upload_post.os.path.exists", return_value=True)
+ @patch("builtins.open", mock_open(read_data=b"fake"))
+ @patch("app.services.upload_post.requests.post")
+ def test_upload_does_not_treat_string_false_as_success(self, mock_post, _exists):
+ response = _mock_response()
+ response.json.return_value = {"success": "false", "request_id": "abc123"}
+ mock_post.return_value = response
+
+ result = UploadPostService().upload_video("/fake/v.mp4", "Title")
+
+ self.assertIs(result["success"], False)
+ self.assertIn("invalid response", result["error"])
+
class TestUploadPostYouTubePayload(unittest.TestCase):
@patch("app.services.upload_post.config.app", _CONFIG_BASE)