Skip to content

利用 AI 大模型和自动化工作流,根据主题或关键词一键生成高清短视频。Generate HD short videos from a topic or keyword with an automated AI workflow.

fix(llm): retry provider errors before accepting script

Rudy Celekli344d8892f3e1
diff --git a/app/services/llm.py b/app/services/llm.py
index 5888d1ed..b86b2b8e 100644
--- a/app/services/llm.py
+++ b/app/services/llm.py
@@ -790,6 +790,10 @@ def generate_script(
response = _generate_response(prompt=prompt)
else:
response = _generate_response(prompt=prompt, app_config=app_config)
+ if isinstance(response, str) and response.startswith("Error: "):
+ # _generate_response returns provider failures as text. Passing
+ # that text through would make the task treat it as narration.
+ raise ValueError(response)
if response:
final_script = format_response(response)
else:
@@ -806,8 +810,8 @@ def generate_script(
if i < _max_retries - 1:
logger.warning(f"failed to generate video script, trying again... {i + 1}")
- if "Error: " in final_script:
- logger.error(f"failed to generate video script: {final_script}")
+ if not final_script:
+ logger.error("failed to generate video script after retries")
else:
logger.success(f"completed: \n{final_script}")
return final_script.strip()
diff --git a/test/services/test_llm.py b/test/services/test_llm.py
index 2ed73aef..d056200d 100644
--- a/test/services/test_llm.py
+++ b/test/services/test_llm.py
@@ -155,6 +155,25 @@ class TestScriptPromptOptions(unittest.TestCase):
self.assertIs(captured["app_config"], app_config)
self.assertEqual(captured["app_config"]["openai_api_key"], "snapshot-key")
+ def test_generate_script_retries_provider_error_instead_of_using_it_as_narration(self):
+ with patch.object(
+ llm,
+ "_generate_response",
+ side_effect=["Error: temporary provider failure", "Real narration."],
+ ) as generate_response:
+ result = llm.generate_script(video_subject="Coffee")
+
+ self.assertEqual(result, "Real narration.")
+ self.assertEqual(generate_response.call_count, 2)
+
+ def test_generate_script_returns_empty_when_provider_always_fails(self):
+ with patch.object(
+ llm, "_generate_response", return_value="Error: invalid API key"
+ ):
+ result = llm.generate_script(video_subject="Coffee")
+
+ self.assertEqual(result, "")
+
def test_generate_script_strips_each_bracket_group_independently(self):
"""
format_response must remove each [bracket] and (paren) group in