Skip to content

利用 AI 大模型和自动化工作流,根据主题或关键词一键生成高清短视频。Generate HD short videos from a topic or keyword with an automated AI workflow.

fix(api): report failed script and term generation as unavailable

Rudy Celekli5f38a2b761e7
diff --git a/app/controllers/v1/llm.py b/app/controllers/v1/llm.py
index 3d58eda5..159270dc 100644
--- a/app/controllers/v1/llm.py
+++ b/app/controllers/v1/llm.py
@@ -2,6 +2,7 @@ from fastapi import Depends, Request
from app.controllers import base
from app.controllers.v1.base import new_router
+from app.models.exception import HttpException
from app.models.schema import (
VideoScriptRequest,
VideoScriptResponse,
@@ -31,6 +32,11 @@ def generate_video_script(request: Request, body: VideoScriptRequest):
video_script_prompt=body.video_script_prompt,
custom_system_prompt=body.custom_system_prompt,
)
+ if not video_script or video_script.startswith("Error: "):
+ raise HttpException(
+ task_id=base.get_task_id(request), status_code=503,
+ message="script generation is unavailable",
+ )
response = {"video_script": video_script}
return utils.get_response(200, response)
@@ -47,6 +53,11 @@ def generate_video_terms(request: Request, body: VideoTermsRequest):
amount=body.amount,
match_script_order=body.match_materials_to_script,
)
+ if not video_terms:
+ raise HttpException(
+ task_id=base.get_task_id(request), status_code=503,
+ message="search term generation is unavailable",
+ )
response = {"video_terms": video_terms}
return utils.get_response(200, response)
diff --git a/test/services/test_llm_api_failures.py b/test/services/test_llm_api_failures.py
new file mode 100644
index 00000000..5ad58f4a
--- /dev/null
+++ b/test/services/test_llm_api_failures.py
@@ -0,0 +1,33 @@
+from types import SimpleNamespace
+from unittest.mock import patch
+import pytest
+from app.controllers.v1 import llm as controller
+from app.models.exception import HttpException
+from app.models.schema import VideoScriptRequest, VideoTermsRequest
+
+
+ "service,handler,body,failed",
+ [
+ (
+ "generate_script",
+ controller.generate_video_script,
+ VideoScriptRequest(video_subject="Coffee"),
+ "Error: quota exhausted",
+ ),
+ (
+ "generate_script",
+ controller.generate_video_script,
+ VideoScriptRequest(video_subject="Coffee"),
+ "",
+ ),
+ ("generate_terms", controller.generate_video_terms, VideoTermsRequest(), []),
+ ],
+)
+def test_provider_failure_does_not_return_success(service, handler, body, failed):
+ request = SimpleNamespace(headers={"x-task-id": "request-1"})
+ with patch.object(controller.llm, service, return_value=failed):
+ with pytest.raises(HttpException) as raised:
+ handler(request, body)
+ assert raised.value.status_code == 503
+ assert "unavailable" in raised.value.message