Skip to content

利用 AI 大模型和自动化工作流,根据主题或关键词一键生成高清短视频。Generate HD short videos from a topic or keyword with an automated AI workflow.

fix(queue): reject stale persisted callable arguments before dispatch

Rudy Celekli7660c17b27e1
diff --git a/app/controllers/manager/redis_manager.py b/app/controllers/manager/redis_manager.py
index 4a5b4bec..84476b18 100644
--- a/app/controllers/manager/redis_manager.py
+++ b/app/controllers/manager/redis_manager.py
@@ -1,3 +1,4 @@
+import inspect
import json
from typing import Dict
@@ -89,6 +90,12 @@ class RedisTaskManager(TaskManager):
# 会把条目重新入队并让异常逃出工作线程,必须在这里先拦下。
if not isinstance(task_info.get("args", []), list):
raise ValueError("queued task positional arguments are not a list")
+ # A persisted request can outlive a callable's signature. Fail
+ # it before dispatch: Python argument-binding errors happen
+ # before start() enters its pipeline failure handler.
+ inspect.signature(task_info["func"]).bind(
+ *task_info.get("args", []), **task_kwargs
+ )
except (TypeError, ValueError, KeyError) as e:
logger.error(f"dropping unusable queued task: {e}")
# 与下面的 params 校验失败路径一致:只要能读出可用的 task_id,就把
diff --git a/test/services/test_queue_signature.py b/test/services/test_queue_signature.py
new file mode 100644
index 00000000..7a03641b
--- /dev/null
+++ b/test/services/test_queue_signature.py
@@ -0,0 +1,52 @@
+import json
+from functools import partial
+from unittest.mock import MagicMock, patch
+
+import pytest
+
+from app.controllers.manager.redis_manager import RedisTaskManager
+from app.models import const
+from app.models.schema import VideoParams
+
+
+def make_manager():
+ client = MagicMock()
+ with patch("app.controllers.manager.redis_manager.redis.Redis.from_url", return_value=client):
+ manager = RedisTaskManager(1, "redis://test.invalid")
+ return manager, client
+
+
+def payload(task_id, **kwargs):
+ return {"func": "start", "args": [], "kwargs": {"task_id": task_id, "params": VideoParams(video_subject="Tea").model_dump(warnings=False), **kwargs}}
+
+
[email protected]("defect", ["retired_keyword", "missing_params", "duplicate_task_id"])
+def test_signature_drift_marks_stale_task_failed_and_drains_queue(defect):
+ manager, client = make_manager()
+ stale = payload("stale")
+ if defect == "retired_keyword":
+ stale["kwargs"]["retired_option"] = True
+ elif defect == "missing_params":
+ del stale["kwargs"]["params"]
+ else:
+ stale["args"] = ["another-task"]
+ client.lpop.side_effect = [json.dumps(stale), json.dumps(payload("valid"))]
+ with patch("app.controllers.manager.redis_manager.sm.state") as state:
+ task = manager.dequeue()
+ assert task["kwargs"]["task_id"] == "valid"
+ state.patch_task.assert_called_once()
+ assert state.patch_task.call_args.args == ("stale",)
+ assert state.patch_task.call_args.kwargs["state"] == const.TASK_STATE_FAILED
+ assert state.patch_task.call_args.kwargs["failed_stage"] == "dequeue"
+
+
+def test_signature_validation_accepts_supported_partial_callables():
+ manager, client = make_manager()
+ def accepts_request(task_id, params, stop_at="video"):
+ pass
+ bound = partial(accepts_request, stop_at="audio")
+ client.lpop.return_value = json.dumps(payload("valid"))
+ with patch.dict("app.controllers.manager.redis_manager.FUNC_MAP", {"start": bound}):
+ task = manager.dequeue()
+ assert task["func"] is bound
+ assert isinstance(task["kwargs"]["params"], VideoParams)