Skip to content

利用 AI 大模型和自动化工作流,根据主题或关键词一键生成高清短视频。Generate HD short videos from a topic or keyword with an automated AI workflow.

Avoid stuck update checks when worker thread cannot start

Rudy Celekli9121569b2175
diff --git a/app/services/version_checker.py b/app/services/version_checker.py
index 7bcdd47a..4ee4184e 100644
--- a/app/services/version_checker.py
+++ b/app/services/version_checker.py
@@ -165,13 +165,20 @@ class AsyncUpdateChecker:
self._checking = True
self._request_id += 1
- worker = threading.Thread(
- target=self._run_check,
- args=(normalized_current_version, self._request_id),
- name="mpt-version-check",
- daemon=True,
- )
- worker.start()
+ try:
+ worker = threading.Thread(
+ target=self._run_check,
+ args=(normalized_current_version, self._request_id),
+ name="mpt-version-check",
+ daemon=True,
+ )
+ worker.start()
+ except RuntimeError as exc:
+ # Thread exhaustion must not leave every subsequent poll pending.
+ logger.warning(f"could not start update check thread: {exc}")
+ self._checking = False
+ self._completed_at = now
+ return UpdateCheckSnapshot(complete=True)
return UpdateCheckSnapshot(complete=False)
diff --git a/test/services/test_version_checker.py b/test/services/test_version_checker.py
index a6535c88..969a4b42 100644
--- a/test/services/test_version_checker.py
+++ b/test/services/test_version_checker.py
@@ -182,6 +182,29 @@ class TestAsyncUpdateChecker(unittest.TestCase):
self.assertTrue(completed.complete)
self.assertIsNone(completed.available_version)
+ def test_thread_start_failure_does_not_leave_check_pending(self):
+ now = [100.0]
+ checker = version_checker.AsyncUpdateChecker(
+ check=lambda _: "1.4.0",
+ ttl_seconds=10,
+ clock=lambda: now[0],
+ )
+ with patch.object(version_checker.threading, "Thread") as make_thread:
+ make_thread.return_value.start.side_effect = RuntimeError(
+ "can't start new thread"
+ )
+ failed = checker.poll("1.3.2")
+
+ self.assertTrue(failed.complete)
+ self.assertIsNone(failed.available_version)
+ self.assertTrue(checker.poll("1.3.2").complete)
+
+ now[0] += 11
+ self.assertEqual(
+ self._wait_for_completion(checker).available_version,
+ "1.4.0",
+ )
+
def test_old_check_cannot_complete_new_check_for_same_version(self):
started = [Event() for _ in range(3)]
release = [Event() for _ in range(3)]