Skip to content

利用 AI 大模型和自动化工作流,根据主题或关键词一键生成高清短视频。Generate HD short videos from a topic or keyword with an automated AI workflow.

fix(upload-post): reject redirects (#1467)

Rudy Mizrahi Celekliabbbb652f057
diff --git a/app/services/upload_post.py b/app/services/upload_post.py
index 2f99a734..3eb1e8a7 100644
--- a/app/services/upload_post.py
+++ b/app/services/upload_post.py
@@ -215,8 +215,19 @@ class UploadPostService:
data=data,
files=files,
timeout=300,
+ allow_redirects=False,
)
+ if 300 <= response.status_code < 400:
+ logger.error(
+ "Upload-Post upload returned an unexpected redirect: "
+ f"status={response.status_code}"
+ )
+ return {
+ "success": False,
+ "error": "Upload-Post upload returned an unexpected redirect",
+ }
+
response.raise_for_status()
try:
result = response.json()
diff --git a/test/services/test_upload_post.py b/test/services/test_upload_post.py
index 17421b60..1455889d 100644
--- a/test/services/test_upload_post.py
+++ b/test/services/test_upload_post.py
@@ -22,6 +22,7 @@ _CONFIG_BASE = {
def _mock_response(success=True):
r = MagicMock()
+ r.status_code = 200
r.json.return_value = {
"success": success,
"request_id": "abc123",
@@ -84,6 +85,24 @@ class TestUploadPostService(unittest.TestCase):
self.assertFalse(result["success"])
self.assertIn("upload timed out", result["error"])
+ @patch("app.services.upload_post.config.app", _CONFIG_BASE)
+ @patch("app.services.upload_post.os.path.exists", return_value=True)
+ @patch("builtins.open", mock_open(read_data=b"fake"))
+ @patch("app.services.upload_post.requests.post")
+ def test_upload_does_not_replay_video_on_redirect(self, mock_post, _exists):
+ """A 307 must not resend the video or API key to the redirect target."""
+ response = _mock_response()
+ response.status_code = 307
+ response.headers = {"Location": "https://other.example/upload"}
+ mock_post.return_value = response
+
+ result = UploadPostService().upload_video("/fake/v.mp4", "Title")
+
+ self.assertFalse(result["success"])
+ self.assertIn("redirect", result["error"])
+ self.assertIs(mock_post.call_args.kwargs.get("allow_redirects"), False)
+ response.json.assert_not_called()
+
@patch("app.services.upload_post.config.app", _CONFIG_BASE)
@patch("app.services.upload_post.requests.get")
def test_check_status_returns_payload_or_network_failure(self, mock_get):
diff --git a/test/services/test_youtube_audience.py b/test/services/test_youtube_audience.py
index 93407b10..df7cbf11 100644
--- a/test/services/test_youtube_audience.py
+++ b/test/services/test_youtube_audience.py
@@ -43,6 +43,7 @@ def test_audience_payload_and_snapshot_override(
video = tmp_path / "video.mp4"
video.write_bytes(b"test-media")
with patch("app.services.upload_post.requests.post") as post:
+ post.return_value.status_code = 200
post.return_value.json.return_value = {
"success": True,
"results": {"youtube": {"success": True}},
@@ -77,6 +78,7 @@ def test_other_platforms_ignore_youtube_audience(tmp_path, upload_config):
video = tmp_path / "video.mp4"
video.touch()
with patch("app.services.upload_post.requests.post") as post:
+ post.return_value.status_code = 200
post.return_value.json.return_value = {
"success": True,
"results": {