Skip to content

利用 AI 大模型和自动化工作流,根据主题或关键词一键生成高清短视频。Generate HD short videos from a topic or keyword with an automated AI workflow.

fix(upload-post): require a successful result for every requested platform

Rudy Celeklid929f68a48ee
diff --git a/app/services/upload_post.py b/app/services/upload_post.py
index 3eb1e8a7..33895944 100644
--- a/app/services/upload_post.py
+++ b/app/services/upload_post.py
@@ -21,13 +21,13 @@ class UploadPostService:
API_BASE = "https://api.upload-post.com"
@staticmethod
- def _with_platform_outcome(result: dict) -> dict:
+ def _with_platform_outcome(result: dict, expected_platforms: list | None = None) -> dict:
"""A successful API request can still contain failed platform publishes."""
platform_results = result.get("results")
if isinstance(platform_results, dict):
- entries = platform_results.items()
+ entries = list(platform_results.items())
elif isinstance(platform_results, list):
- entries = (
+ entries = [
(
entry.get("platform", "unknown")
if isinstance(entry, dict)
@@ -35,7 +35,7 @@ class UploadPostService:
entry,
)
for entry in platform_results
- )
+ ]
else:
if "results" in result:
return {
@@ -52,6 +52,12 @@ class UploadPostService:
or entry.get("success") is not True
or entry.get("skipped") is True
]
+ reported_platforms = {platform for platform, _ in entries if isinstance(platform, str)}
+ failures.extend(
+ f"{platform} (missing result)"
+ for platform in dict.fromkeys(expected_platforms or [])
+ if platform not in reported_platforms
+ )
if not platform_results:
failures.append("no platform results")
if failures:
@@ -63,7 +69,7 @@ class UploadPostService:
}
return result
- def _wait_for_upload_completion(self, request_id: str) -> dict:
+ def _wait_for_upload_completion(self, request_id: str, expected_platforms: list | None = None) -> dict:
"""Resolve Upload-Post's automatic sync-to-background fallback."""
consecutive_errors = 0
deadline = time.monotonic() + _UPLOAD_STATUS_TIMEOUT_SECONDS
@@ -79,7 +85,8 @@ class UploadPostService:
"error": "Upload-Post completed without platform results",
}
return self._with_platform_outcome(
- {**status_result, "request_id": request_id, "success": True}
+ {**status_result, "request_id": request_id, "success": True},
+ expected_platforms,
)
if status == "failed":
return {
@@ -273,9 +280,9 @@ class UploadPostService:
"failed to record background upload request ID: "
f"{exc}"
)
- result = self._wait_for_upload_completion(request_id.strip())
+ result = self._wait_for_upload_completion(request_id.strip(), platforms)
else:
- result = self._with_platform_outcome(result)
+ result = self._with_platform_outcome(result, platforms)
if result.get("success"):
logger.info(
diff --git a/test/services/test_upload_post.py b/test/services/test_upload_post.py
index 1455889d..a63f72ce 100644
--- a/test/services/test_upload_post.py
+++ b/test/services/test_upload_post.py
@@ -26,7 +26,10 @@ def _mock_response(success=True):
r.json.return_value = {
"success": success,
"request_id": "abc123",
- "results": {"tiktok": {"success": success}},
+ "results": {
+ platform: {"success": success}
+ for platform in _CONFIG_BASE["upload_post_platforms"]
+ },
}
r.raise_for_status = MagicMock()
return r
diff --git a/test/services/test_upload_post_missing_platform.py b/test/services/test_upload_post_missing_platform.py
new file mode 100644
index 00000000..499545fa
--- /dev/null
+++ b/test/services/test_upload_post_missing_platform.py
@@ -0,0 +1,44 @@
+import tempfile
+import unittest
+from pathlib import Path
+from unittest.mock import Mock, patch
+
+from app.services.upload_post import UploadPostService
+
+
+class TestUploadPostMissingPlatform(unittest.TestCase):
+ def upload(self, response, status=None):
+ config = {"upload_post_enabled": True, "upload_post_api_key": "test-key", "upload_post_username": "creator"}
+ with tempfile.TemporaryDirectory() as directory:
+ video = Path(directory) / "video.mp4"
+ video.write_bytes(b"local fixture")
+ reply = Mock(status_code=200)
+ reply.json.return_value = response
+ with patch("app.services.upload_post.config.app", config), patch(
+ "app.services.upload_post.requests.post", return_value=reply
+ ) as post, patch.object(UploadPostService, "check_status", return_value=status), patch(
+ "app.services.upload_post.time.sleep"
+ ):
+ result = UploadPostService().upload_video(str(video), "title", platforms=["tiktok", "instagram"])
+ self.assertEqual(post.call_count, 1)
+ return result
+
+ def test_sync_missing_requested_platform_is_not_success(self):
+ result = self.upload({"success": True, "results": {"tiktok": {"success": True}}})
+ self.assertFalse(result["success"])
+ self.assertIn("instagram", result["error"])
+ self.assertTrue(result["results"]["tiktok"]["success"])
+
+ def test_background_list_missing_requested_platform_is_not_success(self):
+ result = self.upload({"success": True, "request_id": "remote-id"}, {
+ "status": "completed", "results": [{"platform": "tiktok", "success": True}],
+ })
+ self.assertFalse(result["success"])
+ self.assertIn("instagram", result["error"])
+ self.assertEqual(result["request_id"], "remote-id")
+
+ def test_complete_platform_response_stays_successful(self):
+ for results in ({"tiktok": {"success": True}, "instagram": {"success": True}},
+ [{"platform": "tiktok", "success": True}, {"platform": "instagram", "success": True}]):
+ with self.subTest(results=results):
+ self.assertTrue(self.upload({"success": True, "results": results})["success"])