Skip to content

利用 AI 大模型和自动化工作流,根据主题或关键词一键生成高清短视频。Generate HD short videos from a topic or keyword with an automated AI workflow.

fix(webui): bound settings import before JSON parsing

Rudy Celeklida16bbbf332c
diff --git a/test/services/test_webui_settings_transfer.py b/test/services/test_webui_settings_transfer.py
index 615779c8..a3901553 100644
--- a/test/services/test_webui_settings_transfer.py
+++ b/test/services/test_webui_settings_transfer.py
@@ -26,6 +26,7 @@ SETTINGS_TRANSFER_HELPERS = {
"_parse_settings_preset",
}
SETTINGS_TRANSFER_CONSTANTS = {
+ "MAX_SETTINGS_TRANSFER_BYTES",
"SETTINGS_PRESET_SCHEMA",
"SETTINGS_PRESET_VERSION",
"SETTINGS_PRESET_FILE_NAME",
@@ -106,6 +107,7 @@ SETTINGS_PRESET_SCHEMA = NAMESPACE["SETTINGS_PRESET_SCHEMA"]
SETTINGS_PRESET_VERSION = NAMESPACE["SETTINGS_PRESET_VERSION"]
KEY_BACKUP_SCHEMA = NAMESPACE["KEY_BACKUP_SCHEMA"]
KEY_BACKUP_VERSION = NAMESPACE["KEY_BACKUP_VERSION"]
+MAX_SETTINGS_TRANSFER_BYTES = NAMESPACE.get("MAX_SETTINGS_TRANSFER_BYTES", 2 * 1024 * 1024)
def _encode(payload):
@@ -236,6 +238,20 @@ def test_settings_preset_rejects_foreign_or_outdated_files():
parse_settings_preset(b"not json at all")
+def test_settings_import_rejects_oversized_json_before_parsing():
+ """An uploaded export must not turn a WebUI session into a huge JSON parse."""
+ raw = _encode({
+ "schema": SETTINGS_PRESET_SCHEMA,
+ "version": SETTINGS_PRESET_VERSION,
+ "params": {"font_size": 72},
+ "padding": "x" * MAX_SETTINGS_TRANSFER_BYTES,
+ })
+ assert len(raw) > MAX_SETTINGS_TRANSFER_BYTES
+
+ with pytest.raises(ValueError, match="exceeds.*2 MB"):
+ parse_settings_preset(raw)
+
+
def test_settings_preset_rejects_invalid_parameter_values():
payload = {
"schema": SETTINGS_PRESET_SCHEMA,
diff --git a/webui/Main.py b/webui/Main.py
index 935ad43a..3bb15966 100644
--- a/webui/Main.py
+++ b/webui/Main.py
@@ -254,6 +254,9 @@ SETTINGS_PRESET_FILE_NAME = "moneyprinterturbo-settings.json"
KEY_BACKUP_SCHEMA = "moneyprinterturbo.key-backup"
KEY_BACKUP_VERSION = 1
KEY_BACKUP_FILE_NAME = "moneyprinterturbo-keys.json"
+# Export files contain only settings or credentials, not media. Reject oversized
+# uploads before decoding and parsing them in the Streamlit process.
+MAX_SETTINGS_TRANSFER_BYTES = 2 * 1024 * 1024
# 预设只描述生成参数。素材、配音和配乐都是本机文件路径,预设通常要在另一台
# 机器或另一个容器里导入,带上这些路径只会指向不存在的文件。
PRESET_EXCLUDED_PARAM_KEYS = frozenset(
@@ -2911,6 +2914,8 @@ def _load_transfer_payload(raw_bytes, schema, version):
提示停留在导入入口,而不是把无法识别的内容写进配置或控件状态。
Windows 编辑器可能保存带 BOM 的 JSON,因此按 utf-8-sig 解码。
"""
+ if len(raw_bytes) > MAX_SETTINGS_TRANSFER_BYTES:
+ raise ValueError("settings import exceeds the 2 MB limit")
payload = json.loads(raw_bytes.decode("utf-8-sig"))
if not isinstance(payload, dict):
raise ValueError("exported file must contain a JSON object")