Skip to content

Terminal interface to find, download, and stream movies, TV shows, and live TV using local media players.

perf(player): cache android opener probing with lazylock

Samir Hossains032d53d97d04
diff --git a/src/player.rs b/src/player.rs
index a2ded21..d92c808 100644
--- a/src/player.rs
+++ b/src/player.rs
@@ -269,8 +269,11 @@ pub fn probe_android_openers() -> Vec<AndroidOpener> {
openers
}
-pub fn android_openers() -> Vec<AndroidOpener> {
- probe_android_openers()
+static ANDROID_OPENERS: std::sync::LazyLock<Vec<AndroidOpener>> =
+ std::sync::LazyLock::new(probe_android_openers);
+
+pub fn android_openers() -> &'static [AndroidOpener] {
+ ANDROID_OPENERS.as_slice()
}
fn append_android_intent_extras(
@@ -367,10 +370,10 @@ pub fn android_intent_commands(
return vec![(AndroidOpener::TermuxOpen("termux-open".to_string()), cmd)];
}
openers
- .into_iter()
+ .iter()
.map(|opener| {
- let cmd = android_intent_command_for_opener(&opener, url, subtitle, headers);
- (opener, cmd)
+ let cmd = android_intent_command_for_opener(opener, url, subtitle, headers);
+ (opener.clone(), cmd)
})
.collect()
}
diff --git a/src/tui/app/playback.rs b/src/tui/app/playback.rs
index 0b1e779..717ef30 100644
--- a/src/tui/app/playback.rs
+++ b/src/tui/app/playback.rs
@@ -606,14 +606,17 @@ impl App {
|| error_output.contains("termux-am"));
if is_termux_socket_err {
- let fallback_candidates = crate::player::android_openers();
- let secondary = fallback_candidates.into_iter().find(|op| {
- matches!(
- op,
- crate::player::AndroidOpener::TermuxOpen(_)
- | crate::player::AndroidOpener::TermuxOpenUrl(_)
- )
- });
+ let secondary =
+ crate::player::android_openers()
+ .iter()
+ .find(|op| {
+ matches!(
+ op,
+ crate::player::AndroidOpener::TermuxOpen(_)
+ | crate::player::AndroidOpener::TermuxOpenUrl(_)
+ )
+ })
+ .cloned();
if let Some(op) = secondary {
log::warn!(
"primary opener failed socket connection, retrying with fallback opener {op:?}"