Skip to content

Terminal interface to find, download, and stream movies, TV shows, and live TV using local media players.

fix(player): persist picker preference

Samir Hossains0bc8d03386d9
diff --git a/README.md b/README.md
index 90cd4ac..aeba58b 100644
--- a/README.md
+++ b/README.md
@@ -216,6 +216,9 @@ moviebox-tui
`/update` checks availability and shows the release location; it does not replace the running binary. Re-run the installer or Homebrew upgrade command to update.
+Choosing a player from `Open with` updates the saved default player for later launches,
+unless `MOVIEBOX_PLAYER` is set in the environment.
+
## Downloads
Downloads are stored under the operating system Downloads directory:
diff --git a/docs/config.md b/docs/config.md
index 9fcf0f1..24f9deb 100644
--- a/docs/config.md
+++ b/docs/config.md
@@ -12,7 +12,7 @@ macOS `~/Library/Application Support/moviebox-tui`, Linux `~/.config/moviebox-tu
| `active_provider` | string | Last provider (`moviebox`, `fourkhdhub`, …). |
| `active_theme` | string | Theme name. |
| `bdix_enabled` | bool | Show BDIX providers (Bangladesh-only). |
-| `default_player` | string | Preferred player: `mpv`, `iina`, `vlc`, `android`. |
+| `default_player` | string | Preferred player: `mpv`, `iina`, `vlc`, `android`; updated when you choose a player from the in-app picker. |
## Other persisted files
diff --git a/docs/players.md b/docs/players.md
index 54df025..1160f7f 100644
--- a/docs/players.md
+++ b/docs/players.md
@@ -14,7 +14,8 @@ builds the exact command; `tui/app/playback.rs` spawns it.
Resolution runs once at startup and is cached (`OnceLock`). A preferred player can be
forced via `MOVIEBOX_PLAYER` env or `default_player` in config (e.g. `mpv`, `iina`,
`vlc`, `android`), which reorders the list. Player picker (`Open with`) lists every
-detected player.
+detected player and saves the chosen player as the next default unless
+`MOVIEBOX_PLAYER` is set.
## Command construction
diff --git a/src/tui/app/navigation.rs b/src/tui/app/navigation.rs
index 423e55c..1969fec 100644
--- a/src/tui/app/navigation.rs
+++ b/src/tui/app/navigation.rs
@@ -3,6 +3,20 @@ use crate::providers::models::{ProviderKind, Release};
use crate::tui::{action::Action, state::Screen};
impl App {
+ fn remember_player_preference(&mut self, player: crate::tui::state::PlayerKind) {
+ self.state.default_player = Some(player.config_key().to_string());
+ if let Some(index) = self
+ .state
+ .available_players
+ .iter()
+ .position(|&kind| kind == player)
+ {
+ let preferred = self.state.available_players.remove(index);
+ self.state.available_players.insert(0, preferred);
+ }
+ self.persist_config();
+ }
+
pub(super) fn switch_provider(&mut self, provider: ProviderKind) {
if self.state.is_tv_mode {
return;
@@ -627,6 +641,7 @@ impl App {
self.state.player_picker_popup = false;
let idx = self.state.player_picker_state.selected().unwrap_or(0);
if let Some(player) = self.state.available_players.get(idx).copied() {
+ self.remember_player_preference(player);
if let Some(source) = self.state.player_picker_playback.take() {
self.action_sender
.send(Action::LaunchPlayback(player, source))
diff --git a/src/tui/state.rs b/src/tui/state.rs
index e21cbf2..7e6963b 100644
--- a/src/tui/state.rs
+++ b/src/tui/state.rs
@@ -19,6 +19,15 @@ impl PlayerKind {
}
}
+ pub fn config_key(&self) -> &'static str {
+ match self {
+ PlayerKind::Mpv => "mpv",
+ PlayerKind::Iina => "iina",
+ PlayerKind::Vlc => "vlc",
+ PlayerKind::AndroidIntent => "android",
+ }
+ }
+
pub fn parse(value: &str) -> Option<PlayerKind> {
match value.to_ascii_lowercase().as_str() {
"mpv" => Some(PlayerKind::Mpv),