Skip to content

Terminal interface to find, download, and stream movies, TV shows, and live TV using local media players.

fix(moviebox): explain placeholder-only titles instead of "no streams"

monalisab263f7a2bd70
diff --git a/src/providers/moviebox/mod.rs b/src/providers/moviebox/mod.rs
index 3c965d9..9f9d625 100644
--- a/src/providers/moviebox/mod.rs
+++ b/src/providers/moviebox/mod.rs
@@ -72,9 +72,9 @@ impl crate::providers::ReleaseProvider for client::MovieBoxClient {
let mut releases = Vec::new();
let mut seen_urls = std::collections::HashSet::new();
+ let mut placeholders = 0;
+ let mut play_info_error = None;
- // Subject details still list the real files while play-info and the
- // resource listing only return the upgrade clip.
match details_res {
Ok(json) => {
for rel in adapt::moviebox_detector_json_to_releases(
@@ -95,20 +95,27 @@ impl crate::providers::ReleaseProvider for client::MovieBoxClient {
Err(error) => log::warn!("moviebox subject details failed: {error}"),
}
- if let Ok(json) = play_info_res {
- for rel in adapt::moviebox_play_info_json_to_releases(
- &json,
- season,
- episode,
- self.user_agent(),
- ) {
- if let Some(url) = rel.direct_url() {
- let base = url.split('?').next().unwrap_or(url).to_string();
- if !base.is_empty() {
- seen_urls.insert(base);
+ match play_info_res {
+ Ok(json) => {
+ placeholders += placeholder_stream_count(&json);
+ for rel in adapt::moviebox_play_info_json_to_releases(
+ &json,
+ season,
+ episode,
+ self.user_agent(),
+ ) {
+ if let Some(url) = rel.direct_url() {
+ let base = url.split('?').next().unwrap_or(url).to_string();
+ if !base.is_empty() && !seen_urls.insert(base) {
+ continue;
+ }
}
+ releases.push(rel);
}
- releases.push(rel);
+ }
+ Err(error) => {
+ log::warn!("moviebox play-info failed: {error}");
+ play_info_error = Some(error);
}
}
@@ -118,14 +125,18 @@ impl crate::providers::ReleaseProvider for client::MovieBoxClient {
.and_then(Value::as_array)
.cloned()
.unwrap_or_default(),
- Err(_) if releases.is_empty() => {
+ Err(error) if releases.is_empty() => {
+ log::warn!("moviebox resource listing failed: {error}");
let page = episode.saturating_sub(1) / 20 + 1;
self.fetch_resource_page(id, season, episode, 0, page)
.await
.map_err(ProviderError::from)?
.0
}
- Err(_) => Vec::new(),
+ Err(error) => {
+ log::warn!("moviebox resource listing failed: {error}");
+ Vec::new()
+ }
};
for item in items {
let mut rel = adapt::moviebox_resource_item_to_release(&item);
@@ -135,8 +146,6 @@ impl crate::providers::ReleaseProvider for client::MovieBoxClient {
continue;
}
if rel.mirrors.is_empty() {
- // Both playback and resource APIs can return an upgrade clip.
- // Ask the resource failover API for the original file instead.
let origin = item
.get("resourceLink")
.or_else(|| item.get("url"))
@@ -145,6 +154,7 @@ impl crate::providers::ReleaseProvider for client::MovieBoxClient {
let (Some(resource_id), Some(origin)) = (rel.resource_id.as_deref(), origin) else {
continue;
};
+ placeholders += 1;
let payload = match self.get_resource_position(id, resource_id, origin).await {
Ok(payload) => payload,
Err(error) => {
@@ -171,9 +181,10 @@ impl crate::providers::ReleaseProvider for client::MovieBoxClient {
}
if releases.is_empty() {
- return Err(ProviderError::Unavailable(
- "No stream sources available".to_string(),
- ));
+ log::warn!(
+ "moviebox returned no playable files for {id} s{season}e{episode} ({placeholders} placeholder clips)"
+ );
+ return Err(empty_streams_error(placeholders, play_info_error));
}
releases.sort_by(|left, right| {
@@ -394,6 +405,37 @@ fn resource_position_path(subject_id: &str, resource_id: &str, failed_url: &str)
format!("/wefeed-mobile-bff/subject-api/resource-position/v2?{query}")
}
+pub const PLACEHOLDER_ONLY_MESSAGE: &str =
+ "MovieBox is serving a placeholder clip instead of this title";
+
+fn placeholder_stream_count(payload: &Value) -> usize {
+ payload
+ .get("data")
+ .unwrap_or(payload)
+ .get("streams")
+ .and_then(Value::as_array)
+ .map_or(0, |streams| {
+ streams
+ .iter()
+ .filter_map(|stream| stream.get("url").and_then(Value::as_str))
+ .filter(|url| adapt::is_deprecation_notice_url(url))
+ .count()
+ })
+}
+
+fn empty_streams_error(
+ placeholders: usize,
+ play_info_error: Option<ScraperError>,
+) -> ProviderError {
+ if placeholders > 0 {
+ ProviderError::Unavailable(PLACEHOLDER_ONLY_MESSAGE.to_string())
+ } else if let Some(error) = play_info_error {
+ ProviderError::from(error)
+ } else {
+ ProviderError::Unavailable("No stream sources available".to_string())
+ }
+}
+
fn episode_resource_path(subject_id: &str, season: usize, episode: usize) -> String {
// The legacy resource listing ignores se/ep and paginates the entire series.
format!(
@@ -491,4 +533,35 @@ mod tests {
"/wefeed-mobile-bff/subject-api/resource?subjectId=67890&se=1&ep=10&page=2&perPage=20&resolution=1080"
);
}
+
+ #[test]
+ fn test_placeholder_stream_count_detects_upgrade_clip() {
+ let payload = json!({"data": {"streams": [
+ {"url": "https://macdn.aoneroom.com/other/2026/10/10/80da52722ee7de7a4303290af6783424.mp4"},
+ {"url": "https://bcdn.hakunaymatata.com/resource/real.mp4"},
+ ]}});
+ assert_eq!(placeholder_stream_count(&payload), 1);
+ assert_eq!(placeholder_stream_count(&json!({})), 0);
+ }
+
+ #[test]
+ fn test_empty_streams_error_explains_placeholder_only_titles() {
+ let err = empty_streams_error(2, Some(ScraperError::HostsExhausted));
+ assert_eq!(
+ err.to_string(),
+ format!("Provider is temporarily unavailable: {PLACEHOLDER_ONLY_MESSAGE}")
+ );
+ assert!(!err.to_string().contains("No stream sources"));
+ }
+
+ #[test]
+ fn test_empty_streams_error_surfaces_api_failure() {
+ let err = empty_streams_error(0, Some(ScraperError::ApiStatus(503)));
+ assert_eq!(
+ err.to_string(),
+ "Provider is temporarily unavailable: HTTP status 503"
+ );
+ let err = empty_streams_error(0, None);
+ assert!(err.to_string().contains("No stream sources"));
+ }
}