Skip to content

Terminal interface to find, download, and stream movies, TV shows, and live TV using local media players.

fix(tui): streamline stream failure message to concise provider notice

Samir Hossainsc8c80f2d0b84
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 3a24cd9..44e93ac 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,8 +10,8 @@
### Fixed
- **Human-Readable Subtitle Filenames & Intent Storage**:
- Formatted subtitle filenames with media titles and season/episode tags (e.g. `<Title> - S<N:02>E<E:02>.<ext>`) in `src/service.rs` and `src/tui/app/playback.rs`, replacing random process/timestamp IDs for easy identification in external player file pickers (`moviebox_subs/`).
-- **Concise Stream Failure Notifications**:
- - Simplified verbose episode stream failure messages (`Provider is temporarily unavailable: No stream sources available`) to clean, high-signal alerts (`No streams available`) in `src/tui/app/requests.rs`.
+- **Concise Stream Failure Messages**:
+ - Simplified verbose stream failure messages (`Provider is temporarily unavailable: No stream sources available`) across the details screen (`src/tui/screens/details.rs`) and notification bar (`src/tui/app/requests.rs`) to concise, direct notices (`No streams available on <Provider>.`).
- **Stream Proxy Subtitle Whitelist & Scope Isolation**:
- Permitted external subtitle CDN hosts in `src/proxy.rs` proxy connection validation, preventing HTTP 403 errors when media players fetch external subtitle tracks alongside DASH stream manifests.
- Scoped authentication headers exclusively to target video hosts, preventing credential spillage to subtitle CDNs.
diff --git a/src/tui/app/requests.rs b/src/tui/app/requests.rs
index a11169b..57ca93a 100644
--- a/src/tui/app/requests.rs
+++ b/src/tui/app/requests.rs
@@ -1892,15 +1892,14 @@ impl App {
self.state.has_streams_settled = true;
self.state.selected_resources.clear();
self.state.resource_list_state.select(None);
- self.state.stream_error = Some(err.clone());
log::error!(
"episode streams failed ({} s{}e{}): {err}",
context.provider.cache_key(),
target_se,
target_ep
);
- let clean_err = if err.contains("No stream sources available") {
- "No streams available".to_string()
+ let clean_err = if err.contains("No stream sources") {
+ format!("No streams available on {}.", context.provider.label())
} else if let Some(stripped) =
err.strip_prefix("Provider is temporarily unavailable: ")
{
@@ -1908,6 +1907,7 @@ impl App {
} else {
err
};
+ self.state.stream_error = Some(clean_err.clone());
self.state.notify(
crate::tui::overlay::NotificationKind::Error,
"Streams Failed",
diff --git a/src/tui/screens/details.rs b/src/tui/screens/details.rs
index fe76f05..fa2534a 100644
--- a/src/tui/screens/details.rs
+++ b/src/tui/screens/details.rs
@@ -1381,12 +1381,14 @@ pub fn draw(frame: &mut Frame, area: Rect, state: &mut AppState, theme: &Theme)
let msg = if waiting_for_language {
"Choose an audio track to load streams.".to_string()
} else if let Some(error) = &state.stream_error {
- if state.active_provider == crate::providers::ProviderKind::Addons {
- error.clone()
- } else if error.contains("No stream sources") || error.contains("not listed") {
- format!("{error}.")
+ if error.contains("No stream sources") || error.contains("No streams available") {
+ format!("No streams available on {provider_label}.")
+ } else if let Some(stripped) =
+ error.strip_prefix("Provider is temporarily unavailable: ")
+ {
+ stripped.trim_end_matches('.').to_string()
} else {
- error.clone()
+ error.trim_end_matches('.').to_string()
}
} else if is_loading_streams {
let spinner = stream_loading_spinner(state.tick_count, state.basic_terminal);