Skip to content

Terminal interface to find, download, and stream movies, TV shows, and live TV using local media players.

feat(logging): file logging for every error path

Samir Hossainscadbcce6c930
diff --git a/Cargo.lock b/Cargo.lock
index 88620e0..eeb1605 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -23,6 +23,15 @@ version = "0.2.21"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "683d7910e743518b0e34f1186f92494becacb047c7b6bf616c96772180fef923"
+[[package]]
+name = "android_system_properties"
+version = "0.1.6"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "ae221649c9976a6f6c56ae1facf410f3ddb33cc661c4b7b61020a912d4237fbc"
+dependencies = [
+ "libc",
+]
+
[[package]]
name = "anyhow"
version = "1.0.104"
@@ -249,6 +258,17 @@ dependencies = [
"rand_core 0.10.1",
]
+[[package]]
+name = "chrono"
+version = "0.4.45"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "1aa79e62e7697b8e29b513a68abacf485adcd1fe8284a4316c5ae868e6633327"
+dependencies = [
+ "iana-time-zone",
+ "num-traits",
+ "windows-link",
+]
+
[[package]]
name = "cmake"
version = "0.1.58"
@@ -719,6 +739,19 @@ dependencies = [
"miniz_oxide",
]
+[[package]]
+name = "flexi_logger"
+version = "0.31.10"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "a4945fa9cdfd7571192cf559c186d45ab36c8034482a2d217a19bdc566f190cc"
+dependencies = [
+ "chrono",
+ "log",
+ "nu-ansi-term",
+ "regex",
+ "thiserror 2.0.19",
+]
+
[[package]]
name = "fnv"
version = "1.0.7"
@@ -1088,6 +1121,30 @@ dependencies = [
"tracing",
]
+[[package]]
+name = "iana-time-zone"
+version = "0.1.65"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "e31bc9ad994ba00e440a8aa5c9ef0ec67d5cb5e5cb0cc7f8b744a35b389cc470"
+dependencies = [
+ "android_system_properties",
+ "core-foundation-sys",
+ "iana-time-zone-haiku",
+ "js-sys",
+ "log",
+ "wasm-bindgen",
+ "windows-core",
+]
+
+[[package]]
+name = "iana-time-zone-haiku"
+version = "0.1.2"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "f31827a206f56af32e590ba56d5d2d085f558508192593743f16b2306495269f"
+dependencies = [
+ "cc",
+]
+
[[package]]
name = "icu_collections"
version = "2.2.0"
@@ -1577,9 +1634,11 @@ dependencies = [
"base64 0.23.1",
"crossterm",
"dirs",
+ "flexi_logger",
"futures",
"hmac",
"image",
+ "log",
"lru",
"md-5",
"mimalloc",
@@ -1657,6 +1716,15 @@ dependencies = [
"minimal-lexical",
]
+[[package]]
+name = "nu-ansi-term"
+version = "0.50.3"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "7957b9740744892f114936ab4a57b3f487491bbeafaf8083688b16841a4240e5"
+dependencies = [
+ "windows-sys 0.61.2",
+]
+
[[package]]
name = "num-conv"
version = "0.2.2"
@@ -2148,7 +2216,7 @@ dependencies = [
"once_cell",
"socket2",
"tracing",
- "windows-sys 0.52.0",
+ "windows-sys 0.61.2",
]
[[package]]
@@ -2615,7 +2683,7 @@ dependencies = [
"security-framework",
"security-framework-sys",
"webpki-root-certs",
- "windows-sys 0.52.0",
+ "windows-sys 0.61.2",
]
[[package]]
@@ -3035,10 +3103,10 @@ source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "32497e9a4c7b38532efcdebeef879707aa9f794296a4f0244f6f69e9bc8574bd"
dependencies = [
"fastrand",
- "getrandom 0.3.4",
+ "getrandom 0.4.3",
"once_cell",
"rustix 1.1.4",
- "windows-sys 0.52.0",
+ "windows-sys 0.61.2",
]
[[package]]
@@ -3672,7 +3740,7 @@ version = "0.1.11"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "c2a7b1c03c876122aa43f3020e6c3c3ee5c05081c9a00739faf7503aeba10d22"
dependencies = [
- "windows-sys 0.52.0",
+ "windows-sys 0.61.2",
]
[[package]]
diff --git a/Cargo.toml b/Cargo.toml
index 5b35816..8396ade 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -37,6 +37,8 @@ unicode-width = "0.2.0"
mimalloc = "0.1.52"
open = "5.4.0"
percent-encoding = "2.3.2"
+log = "0.4.33"
+flexi_logger = "0.31.10"
[lib]
name = "moviebox_tui"
diff --git a/src/cache.rs b/src/cache.rs
index 7ba91a7..a29c265 100644
--- a/src/cache.rs
+++ b/src/cache.rs
@@ -30,6 +30,7 @@ fn read_json_cache(path: &PathBuf, expiry_secs: u64) -> Option<serde_json::Value
fn write_json_cache(path: &PathBuf, data: &serde_json::Value) {
let Ok(content) = serde_json::to_vec(data) else {
+ log::warn!("failed to serialize cache for {}", path.display());
return;
};
let stamp = std::time::SystemTime::now()
@@ -38,11 +39,13 @@ fn write_json_cache(path: &PathBuf, data: &serde_json::Value) {
.as_nanos();
let temporary = path.with_extension(format!("tmp-{}-{stamp}", std::process::id()));
if fs::write(&temporary, content).is_err() {
+ log::warn!("failed to write cache to {}", temporary.display());
return;
}
if fs::rename(&temporary, path).is_err() {
let _ = fs::remove_file(path);
if fs::rename(&temporary, path).is_err() {
+ log::warn!("failed to commit cache to {}", path.display());
let _ = fs::remove_file(temporary);
}
}
@@ -315,11 +318,13 @@ pub fn set_namespaced_image_cache(namespace: &str, id: &str, bytes: &[u8]) {
.as_nanos();
let temporary = path.with_extension(format!("tmp-{}-{stamp}", std::process::id()));
if std::fs::write(&temporary, bytes).is_err() {
+ log::warn!("failed to write image cache to {}", temporary.display());
return;
}
if std::fs::rename(&temporary, &path).is_err() {
let _ = std::fs::remove_file(&path);
if std::fs::rename(&temporary, &path).is_err() {
+ log::warn!("failed to commit image cache to {}", path.display());
let _ = std::fs::remove_file(temporary);
}
}
diff --git a/src/history.rs b/src/history.rs
index 2c7e7f0..0b014c1 100644
--- a/src/history.rs
+++ b/src/history.rs
@@ -50,7 +50,9 @@ impl HistoryManager {
pub fn save(&self) {
if let Some(path) = Self::history_file_path() {
if let Ok(content) = serde_json::to_string(self) {
- let _ = fs::write(path, content);
+ if let Err(error) = fs::write(&path, content) {
+ log::warn!("failed to save watch history: {error}");
+ }
}
}
}
diff --git a/src/lib.rs b/src/lib.rs
index 3bea6c7..fdccc15 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -1,5 +1,6 @@
pub mod cache;
pub mod download;
pub mod history;
+pub mod logging;
pub mod providers;
pub mod tui;
diff --git a/src/logging.rs b/src/logging.rs
new file mode 100644
index 0000000..e179ac2
--- /dev/null
+++ b/src/logging.rs
@@ -0,0 +1,64 @@
+use flexi_logger::{Cleanup, Criterion, FileSpec, Logger, Naming, WriteMode};
+
+pub fn init() {
+ let default_level = if cfg!(debug_assertions) {
+ "info"
+ } else {
+ "warn"
+ };
+ let spec = std::env::var("MOVIEBOX_LOG")
+ .ok()
+ .filter(|value| !value.is_empty())
+ .unwrap_or_else(|| default_level.to_string());
+
+ let log_dir = dirs::data_dir()
+ .map(|dir| dir.join("moviebox-tui").join("logs"))
+ .unwrap_or_else(std::env::temp_dir);
+
+ match Logger::try_with_str(&spec) {
+ Ok(logger) => {
+ if let Err(error) = logger
+ .log_to_file(
+ FileSpec::default()
+ .directory(&log_dir)
+ .basename("moviebox-tui"),
+ )
+ .rotate(
+ Criterion::Size(5 * 1024 * 1024),
+ Naming::Numbers,
+ Cleanup::KeepLogFiles(3),
+ )
+ .write_mode(WriteMode::Direct)
+ .format(flexi_logger::opt_format)
+ .start()
+ {
+ eprintln!("[moviebox-tui] logging unavailable: {error}");
+ }
+ }
+ Err(error) => {
+ eprintln!("[moviebox-tui] invalid MOVIEBOX_LOG level: {error}");
+ }
+ }
+
+ log::info!(
+ "session started | moviebox-tui {} | {} | log file: {}",
+ env!("CARGO_PKG_VERSION"),
+ std::env::consts::OS,
+ log_file_path().display()
+ );
+ eprintln!(
+ "[moviebox-tui] logging to {} (MOVIEBOX_LOG={})",
+ log_file_path().display(),
+ spec
+ );
+}
+
+pub fn log_file_path() -> std::path::PathBuf {
+ dirs::data_dir()
+ .map(|dir| {
+ dir.join("moviebox-tui")
+ .join("logs")
+ .join("moviebox-tui_rCURRENT.log")
+ })
+ .unwrap_or_else(std::env::temp_dir)
+}
diff --git a/src/main.rs b/src/main.rs
index 11a4c0e..6d909cd 100644
--- a/src/main.rs
+++ b/src/main.rs
@@ -45,9 +45,12 @@ impl Drop for TerminalGuard {
#[tokio::main]
async fn main() -> std::io::Result<()> {
+ moviebox_tui::logging::init();
+
std::panic::set_hook(Box::new(|info| {
+ log::error!("panic: {info}");
restore_terminal();
- eprintln!("{}", info);
+ eprintln!("{info}");
}));
let args: Vec<String> = std::env::args().collect();
diff --git a/src/providers/bdix/dhakaflix/client.rs b/src/providers/bdix/dhakaflix/client.rs
index bf87ac5..cd54484 100644
--- a/src/providers/bdix/dhakaflix/client.rs
+++ b/src/providers/bdix/dhakaflix/client.rs
@@ -199,7 +199,8 @@ impl DhakaFlixClient {
}
}
}
- Err(_) => {
+ Err(error) => {
+ log::warn!("dhakaflix search request failed: {error} [{base_url}]");
if let Ok(mut fails) = recent_fails.write() {
fails.insert(base_url.to_string(), Instant::now());
}
diff --git a/src/providers/fourkhdhub/client.rs b/src/providers/fourkhdhub/client.rs
index 7543c22..0d4fdfb 100644
--- a/src/providers/fourkhdhub/client.rs
+++ b/src/providers/fourkhdhub/client.rs
@@ -123,6 +123,7 @@ impl FourKHdHubClient {
}
match self.preflight(&url, &merged).await {
Ok(playable_url) => {
+ log::info!("4KHDHub mirror playable: {label} ({playable_url})");
return Ok(PlaybackSource {
provider: ProviderKind::FourKHdHub,
url: playable_url,
@@ -131,11 +132,22 @@ impl FourKHdHubClient {
source_label: label,
});
}
- Err(error) => last_error = Some(error.to_string()),
+ Err(error) => {
+ log::warn!("4KHDHub mirror rejected ({label}): {error} [{url}]");
+ last_error = Some(error.to_string());
+ }
}
}
+ } else if let Err(error) = candidates {
+ log::warn!("4KHDHub mirror candidates failed: {error}");
+ last_error = Some(error.to_string());
}
}
+ log::error!(
+ "4KHDHub: no playable mirror for release {:?} (last: {:?})",
+ release.filename,
+ last_error
+ );
Err(FourKHdHubError::NoPlayableMirror(
last_error.unwrap_or_else(|| "all mirrors rejected the stream probe".into()),
))
diff --git a/src/providers/moviebox/client.rs b/src/providers/moviebox/client.rs
index be0791b..b957f5e 100644
--- a/src/providers/moviebox/client.rs
+++ b/src/providers/moviebox/client.rs
@@ -190,6 +190,7 @@ impl MovieBoxClient {
let status = resp.status().as_u16();
if RETRY_STATUS_CODES.contains(&status) {
+ log::warn!("moviebox host {idx} returned retryable status {status}: {url}");
continue;
}
@@ -197,13 +198,20 @@ impl MovieBoxClient {
match self.parse_response(resp).await {
Ok(val) => return Ok(val),
- Err(_) => continue,
+ Err(error) => {
+ log::warn!("moviebox host {idx} parse failed: {error} [{url}]");
+ continue;
+ }
}
}
- Err(_) => continue,
+ Err(error) => {
+ log::warn!("moviebox host {idx} request failed: {error} [{url}]");
+ continue;
+ }
}
}
+ log::error!("moviebox: all hosts exhausted for {path_and_query}");
Err(ScraperError::HostsExhausted)
}
diff --git a/src/tui/app.rs b/src/tui/app.rs
index 187f3b5..7fdccc4 100644
--- a/src/tui/app.rs
+++ b/src/tui/app.rs
@@ -279,6 +279,11 @@ impl App {
}
}
if !downloaded {
+ log::warn!(
+ "subtitle download failed for {:?} player, playing without subtitles (url was {})",
+ kind,
+ url
+ );
let _ = sender.send(Action::SetStatus(
"Subtitles unavailable; playing without subtitles.".to_string(),
));
@@ -339,6 +344,7 @@ impl App {
});
}
Err(error) => {
+ log::error!("failed to spawn player {:?} for {}: {error}", kind, link);
if let Some(path) = temporary_subtitle {
let _ = tokio::fs::remove_file(path).await;
}
@@ -2556,6 +2562,10 @@ impl App {
if !self.context_is_current(context) {
return None;
}
+ log::error!(
+ "search failed (provider {}): {err}",
+ context.provider.cache_key()
+ );
self.state.is_loading = false;
self.state.search_error = Some(err.clone());
self.state
@@ -2742,6 +2752,7 @@ impl App {
);
}
Action::HomepageFailure(err) => {
+ log::error!("discover failed: {err}");
self.state.is_loading = false;
self.state
.set_status(format!("Discover failed: {}", err), 150);
@@ -3451,6 +3462,7 @@ impl App {
}
}
Err(error) => {
+ log::error!("4KHDHub resolve failed: {error}");
sender
.send(Action::SetStatus(format!(
"Error: 4KHDHub source failed: {error}"
@@ -3709,6 +3721,7 @@ impl App {
.ok();
}
Err(error) => {
+ log::error!("stream resolve failed: {error}");
sender
.send(Action::SetStatus(format!("Resolve failed: {error}")))
.ok();
@@ -4059,6 +4072,10 @@ impl App {
if !self.context_is_current(context) {
return None;
}
+ log::error!(
+ "details fetch failed (provider {}): {err}",
+ context.provider.cache_key()
+ );
self.state.is_loading = false;
self.state
.set_status(format!("Details fetch failed: {}", err), 150);
@@ -4066,6 +4083,7 @@ impl App {
Action::SetStatus(msg) => {
self.state.is_resolving_playback = false;
if msg.starts_with("Error:") {
+ log::error!("{msg}");
self.state.notify(
NotificationKind::Error,
"Operation failed",
@@ -4699,6 +4717,12 @@ impl App {
self.state.is_loading = false;
self.state.is_fetching_streams = false;
self.state.selected_resources = None;
+ log::error!(
+ "episode streams failed ({} s{}e{}): {err}",
+ context.provider.cache_key(),
+ target_se,
+ target_ep
+ );
self.state.stream_error = Some(err.clone());
self.state.set_status(format!("Error: {}", err), 150);
}
@@ -4830,6 +4854,7 @@ impl App {
let code_str = code
.map(|c| c.to_string())
.unwrap_or_else(|| "unknown".into());
+ log::error!("player crashed (code {code_str}): {error_msg}");
let display_err = if error_msg.is_empty() {
"No error output provided by player.".to_string()
diff --git a/src/tui/updater.rs b/src/tui/updater.rs
index 12c117a..66bcbeb 100644
--- a/src/tui/updater.rs
+++ b/src/tui/updater.rs
@@ -35,6 +35,7 @@ async fn fetch_release() -> Result<Release, String> {
let status = resp.status();
if !status.is_success() {
let body = resp.text().await.unwrap_or_default();
+ log::warn!("GitHub update check failed: {status} {body}");
return Err(format!("GitHub API {status}: {body}"));
}